Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gallery application test example #17957

Closed

Conversation

kangsun-ctrl
Copy link
Contributor

update gallery application test example

@nisha-bhatia
Copy link
Member

nisha-bhatia commented Jan 14, 2021

@kangsun-ctrl This PR has changes to the generated code which is not allowed. Could you revert the change in the generated folder or include the usual artifacts associated with regeneration? Or if there were changes to the Swagger, could you please post the Swagger PR? Thanks

@kangsun-ctrl
Copy link
Contributor Author

@kangsun-ctrl This PR has changes to the generated code which is not allowed. Could you revert the change in the generated folder or include the usual artifacts associated with regeneration? Or if there were changes to the Swagger, could you please post the Swagger PR? Thanks

@kangsun-ctrl
Copy link
Contributor Author

kangsun-ctrl commented Jan 16, 2021

This sdk change is for the swagger change we have made and we need to unblock SDK test failure: Azure/azure-rest-api-specs#12438

@grizzlytheodore
Copy link
Member

changes in the generated folder are derived from change in swagger here Azure/azure-rest-api-specs#12438

@Sandido
Copy link
Member

Sandido commented Jan 20, 2021

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@ashvermamsft
Copy link
Contributor

@markcowl we need this to get checked in so that the cloudServices PR (#17341) can go in. On the latest SDK generation from master, we have started facing the gallery test build failures.

@markcowl
Copy link
Member

/azp run net - compute - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@markcowl
Copy link
Member

/ azp run net - mgmt -ci

@grizzlytheodore
Copy link
Member

grizzlytheodore commented Feb 2, 2021

@kangsun-ctrl @allenjzhang why was this closed? Also what is the reason for 'Do not Merge' ?
the changes in this PR are a reflection of changes in swagger: Azure/azure-rest-api-specs#12438

@kangsun-ctrl
Copy link
Contributor Author

@kangsun-ctrl @allenjzhang why was this closed? Also what is the reason for 'Do not Merge' ?
the changes in this PR are a reflection of changes in swagger: Azure/azure-rest-api-specs#12438

@grizzlytheodore This pr got merged to another pr which contains whole change for 2020-10-preview. The change is already merged to sdk 2020-12-preview release.

@grizzlytheodore
Copy link
Member

@kangsun-ctrl ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants