Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ContainerInstance]Generated the track 2 SDK for ContainerInstance. #18273

Closed
wants to merge 9 commits into from

Conversation

LucasYao93
Copy link
Contributor

Description

Generated code and wrote test cases.

Work Content details

  • Generated track 2 SDK code.
  • Wrote test cases and successfully record.
  • Modified assembly version(1.0.0-beta.1) and namespace(ContainerInstance to Microsoft.ContainerInstance ).

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

@LucasYao93
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 18273 in repo Azure/azure-sdk-for-net

@isra-fel
Copy link
Member

Should the pipeline config be updated to pick up this new SDK project in CI and how?

@HarveyLink
Copy link
Member

Should the pipeline config be updated to pick up this new SDK project in CI and how?

The previous Pipeline CI PR should be merged before this one: #18349

@YalinLi0312
Copy link
Member

/check-enforcer reset

@isra-fel
Copy link
Member

/azp run net - containerinstance - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LucasYao93
Copy link
Contributor Author

LucasYao93 commented Feb 23, 2021

HI @allenjzhang,
For fix swagger issue, I used the specified autorest/modelerfour version(4.15.448) which cause CI(Build Analyze) to fail.

Thanks,
Lucas

@LucasYao93 LucasYao93 closed this Feb 25, 2021
@LucasYao93 LucasYao93 reopened this Feb 25, 2021
@isra-fel
Copy link
Member

Issue was fixed after syncing master. @YalinLi0312 could you take a look again? Thank you.

@isra-fel
Copy link
Member

Thanks Allen for approving.
As we disscuessed in mails, we are going to put this pull request on hold.

@ghost
Copy link

ghost commented Jun 11, 2021

Hi @LucasYao93. Thank you, for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost closed this Jun 18, 2021
@ghost
Copy link

ghost commented Jun 18, 2021

Hi @LucasYao93. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-recent-activity There has been no recent activity on this issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants