-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Text Analytics] Analyze design update #18406
Merged
Merged
Changes from 23 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
f5afe87
initial design changes for analyze operation
suhas92 4824c73
pull master
suhas92 f592d50
pull in changes
suhas92 1ad990d
addressed comments
suhas92 0f60be5
pull in changes resolve conflicts and addressed comments
suhas92 287c8bd
run scripts
suhas92 c8d91b2
implemented errors map to action result
suhas92 197f598
run scripts
suhas92 d130ff8
cleanup
suhas92 ae98a49
more cleanup
suhas92 3e48545
cleanup
suhas92 bee2c53
more cleanup
suhas92 8872096
cleanup
suhas92 0e50aa0
updated doc strings for textanalytics client
suhas92 f78b061
added assertions for new properties of operation class
suhas92 58bb3f2
addressed comments
suhas92 9e8a127
run scripts
suhas92 1e7d26d
cleanup
suhas92 678c4ae
updated tests
suhas92 872f78d
Update sdk/textanalytics/Azure.AI.TextAnalytics/src/AnalyzeBatchActio…
suhas92 2047018
addressed commenta
suhas92 569efdd
updated scripts
suhas92 c3f130c
update AAD tests
maririos f573e1b
fix Sample_AnalyzeOperation
suhas92 212b111
Merge branch 'sumeh/analyze-design-update' of https://github.com/Azur…
suhas92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
188 changes: 68 additions & 120 deletions
188
sdk/textanalytics/Azure.AI.TextAnalytics/api/Azure.AI.TextAnalytics.netstandard2.0.cs
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
sdk/textanalytics/Azure.AI.TextAnalytics/src/AnalyzeBatchActionsOptions.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
// Licensed under the MIT License. | ||
|
||
namespace Azure.AI.TextAnalytics | ||
{ | ||
/// <summary> | ||
/// Options that allow callers to specify details about how the operation | ||
/// is run and what information is returned from it by the service. | ||
/// <para>For example whether to include statistics.</para> | ||
/// </summary> | ||
public class AnalyzeBatchActionsOptions | ||
{ | ||
/// <summary> | ||
/// Gets or sets a value that, if set to true, indicates that the service | ||
/// should return document and document batch statistics with the results | ||
/// of the operation. | ||
/// </summary> | ||
public bool IncludeStatistics { get; set; } | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: _actionsSucceeded