Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core.Experimental] Improvements for Protocol Clients #18412

Merged
merged 2 commits into from
Feb 5, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[Core.Experimental] Improvements for Protocol Clients
- Add a ProtocolClientOptions type for use by clients which have no
  additional options. This means we don't have to generate a type per
  client

- Add a zero argument constructor to `DynamicJson` that behaves like
  DynamicJson.Object(), since we expect that `DynamicJson` will
  appear in API signatures and users will want to be able to `new` up
  the type.
  • Loading branch information
ellismg committed Feb 4, 2021

Unverified

No user is associated with the committer email.
commit aa93a9880dc886c6f16d3a6d7fef6df0a0c14e44
Original file line number Diff line number Diff line change
@@ -11,6 +11,7 @@ public override void WriteTo(System.IO.Stream stream, System.Threading.Cancellat
}
public partial class DynamicJson : System.Dynamic.IDynamicMetaObjectProvider
{
public DynamicJson() { }
public DynamicJson(string json) { }
public DynamicJson(System.Text.Json.JsonElement element) { }
public Azure.Core.DynamicJson this[int arrayIndex] { get { throw null; } set { } }
@@ -99,6 +100,10 @@ protected virtual void Dispose(bool disposing) { }
protected override bool TryGetHeader(string name, out string? value) { throw null; }
protected override bool TryGetHeaderValues(string name, out System.Collections.Generic.IEnumerable<string>? values) { throw null; }
}
public partial class ProtocolClientOptions : Azure.Core.ClientOptions
{
public ProtocolClientOptions() { }
}
}
namespace Azure.Core.GeoJson
{
7 changes: 7 additions & 0 deletions sdk/core/Azure.Core.Experimental/src/DynamicJson.cs
Original file line number Diff line number Diff line change
@@ -29,6 +29,13 @@ public class DynamicJson : IDynamicMetaObjectProvider
private List<DynamicJson>? _arrayRepresentation;
private object? _value;

/// <summary>
/// Construcs a new DynamicJson which represents an empty JSON object.
/// </summary>
public DynamicJson() : this(System.Array.Empty<KeyValuePair<string, DynamicJson>>())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

{
}

public DynamicJson(string json): this(JsonDocument.Parse(json).RootElement)
{
}
14 changes: 14 additions & 0 deletions sdk/core/Azure.Core.Experimental/src/ProtocolClientOptions.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

namespace Azure.Core
{
/// <summary>
/// A concrete ClientOptions for use by client with no additonal options other than the common ones.
/// </summary>
#pragma warning disable AZC0008 // ClientOptions should have a nested enum called ServiceVersion
public class ProtocolClientOptions : ClientOptions
#pragma warning restore AZC0008 // ClientOptions should have a nested enum called ServiceVersion
{
}
}