Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CloudService tests #18423

Merged
merged 20 commits into from
Feb 4, 2021
Merged

Remove CloudService tests #18423

merged 20 commits into from
Feb 4, 2021

Conversation

Sandido
Copy link
Member

@Sandido Sandido commented Feb 4, 2021 •
edited
Loading

Also removed CloudServices and ContainerServices versions from props file.

Sync with #18390

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
  • If the check fails at the Verify Code Generation step, please ensure:
    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

Sandido added 20 commits February 3, 2021 13:34
@Sandido
Delete CloudServiceExtensionTests.cs
55cd7b1
@Sandido
Delete CloudServiceOperationTests.cs
123a6e1
@Sandido
Delete CloudServiceRoleInstanceTests.cs
1ecce95
@Sandido
Delete CloudServiceScenarioTests.cs
43f8992
@Sandido
Delete CloudServiceTestsBase.cs
9f4506d
@Sandido
Delete CloudServiceUpdateTests.cs
4d82c2d
@Sandido
Delete MultiRole_CreateUpdateGetAndDeleteWithExtension_WorkerAndWebRo…
0c2be53 
…le.json
@Sandido
Delete MultiRole_CreateUpdateGetAndDeleteWithExtension_WorkerAndWebRo…
1c4ef2d 
…le_MultiRoleExtension.json
@Sandido
Delete Test_Create_PowerOff_Start_CloudServiceOperation.json
458bb2d
@Sandido
Delete Test_ListCloudServicesOperation.json
c481255
@Sandido
Delete Test_CloudServiceRoleInstanceOperations.json
8d109cf
@Sandido
Delete TestCloudServiceScenarioOperations.json
c48cd06
@Sandido
Delete TestCloudServiceScenarioOperations_DeleteCloudService.json
ff91815
@Sandido
Delete TestCloudServiceScenarioOperations_ExtensionProfile.json
a89851e
@Sandido
Delete TestCloudServiceScenarioOperations_InstanceView.json
8484255
@Sandido
Delete TestCloudServiceOperations_ScaleIn_ScaleOut.json
2ddb46c
@Sandido
Delete TestCloudServiceUpdateOperations.json
4a5dacd
@Sandido
Update AzSdk.RP.props
9ecae90
@Sandido
Update AzSdk.RP.props
724c1f9 
remove containerService
@Sandido
Delete ServiceConfigurationHelpers.cs
59312da
@ghost ghost added the Compute label Feb 4, 2021
@Sandido Sandido merged commit 02881d8 into compute-2020-12 Feb 4, 2021
@Sandido Sandido deleted the SandidoRemoveCloudServiceTests branch February 4, 2021 15:47
markcowl pushed a commit that referenced this pull request Feb 18, 2021
@Sandido @grizzlytheodore @pavanrachapudy90
Functionality for the 2020-12-01 Compute Rest API release (#18498)
e8cc86f 
* Delete test json files (#18003)

* Delete TestVMExtensionOperations.json

* Delete TestVMScaleSetExtensions.json

* Resolve conflicts for -updated merge (#18015)

* Update SdkInfo_ComputeManagementClient.cs

* Update VirtualMachineRunCommandsOperations.cs

* Update VirtualMachineScaleSetVMRunCommandsOperations.cs

* Create TestVMExtensionOperations.json

* Delete TestVMExtensionOperations.json

* Create TestVMExtensionOperations.json

* Create TestVMScaleSetExtensions.json

* Compute 2020 12 updated (#17975)

* adding 2020-12-01 compute generated files

* update default sku

* update tests

* test updates

* records

* tests fixes

* all the recorded tests

* more update

* more update

* more update

* last test fixes

* Updated TestVMIdentitySystemAssignedUserAssigned SDK Test to create User Assigned Identity using SDK (#17861)

* Updated TestVMIdentitySystemAssignedUserAssigned SDK Test to create User Assigned MI using MSI SDK

* Resolved Merge Conflicts and updated the test

Co-authored-by: Pavan Rachapudy <vrachapu@microsoft.com>

* Delete AppGW tests (#17977)

* Delete VMScaleSetAppGwWithAS.json

* Delete VMScaleSetAppGwWithAS_A1V2.json

* Delete VMScaleSetAppGwWithAS_SPG_False.json

* Delete VMScaleSetAppGwWithAS_Spot.json

* Delete VMScaleSetAppGWTests.cs

* Delete deprecated ContainerService tests (#17976)

* Delete ContainerServiceOperationalTests.cs

* Delete ContainerServiceTestsBase.cs

* Delete ContainerServiceUpdateTests.cs

* Delete TestDCOSOperations.json

* Delete TestSwarmOperations.json

* Delete TestContainerServiceUpdateOperations.json

* test

* remove test text

Co-authored-by: pavanrachapudy <pavanrachapudy@gmail.com>
Co-authored-by: Pavan Rachapudy <vrachapu@microsoft.com>
Co-authored-by: Adam Sandor <adsandor@microsoft.com>

* new recording files

* 2020-12 release features generated, tests pass

* Update DiskRPTestsBase.cs (#18355)

* Remove CloudService tests (#18423)

* Delete CloudServiceExtensionTests.cs

* Delete CloudServiceOperationTests.cs

* Delete CloudServiceRoleInstanceTests.cs

* Delete CloudServiceScenarioTests.cs

* Delete CloudServiceTestsBase.cs

* Delete CloudServiceUpdateTests.cs

* Delete MultiRole_CreateUpdateGetAndDeleteWithExtension_WorkerAndWebRole.json

* Delete MultiRole_CreateUpdateGetAndDeleteWithExtension_WorkerAndWebRole_MultiRoleExtension.json

* Delete Test_Create_PowerOff_Start_CloudServiceOperation.json

* Delete Test_ListCloudServicesOperation.json

* Delete Test_CloudServiceRoleInstanceOperations.json

* Delete TestCloudServiceScenarioOperations.json

* Delete TestCloudServiceScenarioOperations_DeleteCloudService.json

* Delete TestCloudServiceScenarioOperations_ExtensionProfile.json

* Delete TestCloudServiceScenarioOperations_InstanceView.json

* Delete TestCloudServiceOperations_ScaleIn_ScaleOut.json

* Delete TestCloudServiceUpdateOperations.json

* Update AzSdk.RP.props

* Update AzSdk.RP.props

remove containerService

* Delete ServiceConfigurationHelpers.cs

* regenerate on released 2020-12-01 swagger

* re-recorded test jsons

* test fixes

* Update AssemblyInfo.cs

* Update AzSdk.RP.props

* Update Microsoft.Azure.Management.Compute.csproj

* Update compute_resource-manager.txt

* Update Microsoft.Azure.Management.Compute.csproj

* customization for VMSSVMOperations

* update for OMode and others

* Update compute_resource-manager.txt

* Update VirtualMachineScaleSetVMsOperations.cs

full customization for this class

* Update VirtualMachineScaleSetVMsOperations.cs

full customization revision

* Create VirtualMachineScaleSet.cs

customizations for VMSS.cs

* Create VirtualMachineUpdate.cs

customizations for VMU

* Create VirtualMachine.cs

customization for VM.cs

* Update VirtualMachineScaleSet.cs

customization finalized

* Update VirtualMachineScaleSetVMsOperations.cs

customization edit

* Create VirtualMachineImage.cs

VMI.cs customization

* Update VirtualMachine.cs

cleanup

* Update VirtualMachine.cs

c;eamup2

* Update VirtualMachineUpdate.cs

fix build error? removed Plan

* Update VirtualMachineUpdate.cs

resolve errors

* Update VirtualMachine.cs

resolve errors

* Update VirtualMachineImage.cs

resolve errors

* Update VirtualMachineScaleSet.cs

resolve errors

* Update VirtualMachine.cs

* Update VirtualMachineImage.cs

* Update VirtualMachineScaleSet.cs

* Update VirtualMachineUpdate.cs

* Update VirtualMachineScaleSet.cs

* Update VirtualMachineScaleSetVMsOperations.cs

* Update VirtualMachineUpdate.cs

* Create IVirtualMachineScaleSetVMsOperations.cs

customizations

* Update IVirtualMachineScaleSetVMsOperations.cs

additional customizations

* Create VirtualMachineScaleSetVMsOperationsExtensions.cs

* Update VMInstanceViewPatchStatusTests.cs

Co-authored-by: Theodore Chang <thchan@microsoft.com>
Co-authored-by: pavanrachapudy <pavanrachapudy@gmail.com>
Co-authored-by: Pavan Rachapudy <vrachapu@microsoft.com>
nisha-bhatia pushed a commit that referenced this pull request Mar 3, 2021
@Sandido @grizzlytheodore @pavanrachapudy90
Trusted Launch Test (#18562)
31e9a8c 
* Delete test json files (#18003)

* Delete TestVMExtensionOperations.json

* Delete TestVMScaleSetExtensions.json

* Resolve conflicts for -updated merge (#18015)

* Update SdkInfo_ComputeManagementClient.cs

* Update VirtualMachineRunCommandsOperations.cs

* Update VirtualMachineScaleSetVMRunCommandsOperations.cs

* Create TestVMExtensionOperations.json

* Delete TestVMExtensionOperations.json

* Create TestVMExtensionOperations.json

* Create TestVMScaleSetExtensions.json

* Compute 2020 12 updated (#17975)

* adding 2020-12-01 compute generated files

* update default sku

* update tests

* test updates

* records

* tests fixes

* all the recorded tests

* more update

* more update

* more update

* last test fixes

* Updated TestVMIdentitySystemAssignedUserAssigned SDK Test to create User Assigned Identity using SDK (#17861)

* Updated TestVMIdentitySystemAssignedUserAssigned SDK Test to create User Assigned MI using MSI SDK

* Resolved Merge Conflicts and updated the test

Co-authored-by: Pavan Rachapudy <vrachapu@microsoft.com>

* Delete AppGW tests (#17977)

* Delete VMScaleSetAppGwWithAS.json

* Delete VMScaleSetAppGwWithAS_A1V2.json

* Delete VMScaleSetAppGwWithAS_SPG_False.json

* Delete VMScaleSetAppGwWithAS_Spot.json

* Delete VMScaleSetAppGWTests.cs

* Delete deprecated ContainerService tests (#17976)

* Delete ContainerServiceOperationalTests.cs

* Delete ContainerServiceTestsBase.cs

* Delete ContainerServiceUpdateTests.cs

* Delete TestDCOSOperations.json

* Delete TestSwarmOperations.json

* Delete TestContainerServiceUpdateOperations.json

* test

* remove test text

Co-authored-by: pavanrachapudy <pavanrachapudy@gmail.com>
Co-authored-by: Pavan Rachapudy <vrachapu@microsoft.com>
Co-authored-by: Adam Sandor <adsandor@microsoft.com>

* new recording files

* 2020-12 release features generated, tests pass

* Update DiskRPTestsBase.cs (#18355)

* Remove CloudService tests (#18423)

* Delete CloudServiceExtensionTests.cs

* Delete CloudServiceOperationTests.cs

* Delete CloudServiceRoleInstanceTests.cs

* Delete CloudServiceScenarioTests.cs

* Delete CloudServiceTestsBase.cs

* Delete CloudServiceUpdateTests.cs

* Delete MultiRole_CreateUpdateGetAndDeleteWithExtension_WorkerAndWebRole.json

* Delete MultiRole_CreateUpdateGetAndDeleteWithExtension_WorkerAndWebRole_MultiRoleExtension.json

* Delete Test_Create_PowerOff_Start_CloudServiceOperation.json

* Delete Test_ListCloudServicesOperation.json

* Delete Test_CloudServiceRoleInstanceOperations.json

* Delete TestCloudServiceScenarioOperations.json

* Delete TestCloudServiceScenarioOperations_DeleteCloudService.json

* Delete TestCloudServiceScenarioOperations_ExtensionProfile.json

* Delete TestCloudServiceScenarioOperations_InstanceView.json

* Delete TestCloudServiceOperations_ScaleIn_ScaleOut.json

* Delete TestCloudServiceUpdateOperations.json

* Update AzSdk.RP.props

* Update AzSdk.RP.props

remove containerService

* Delete ServiceConfigurationHelpers.cs

* regenerate on released 2020-12-01 swagger

* re-recorded test jsons

* test fixes

* Update VMScenarioTests.cs

* Update VMTestBase.cs

* Create TestVMScenarioOperations_TrustedLaunch.json

* Update OrchestrationMode.cs

Co-authored-by: Theodore Chang <thchan@microsoft.com>
Co-authored-by: pavanrachapudy <pavanrachapudy@gmail.com>
Co-authored-by: Pavan Rachapudy <vrachapu@microsoft.com>
nisha-bhatia pushed a commit that referenced this pull request Mar 4, 2021
@Sandido @grizzlytheodore @pavanrachapudy90
Force Detach test (#18553)
e1b1017 
* Delete test json files (#18003)

* Delete TestVMExtensionOperations.json

* Delete TestVMScaleSetExtensions.json

* Resolve conflicts for -updated merge (#18015)

* Update SdkInfo_ComputeManagementClient.cs

* Update VirtualMachineRunCommandsOperations.cs

* Update VirtualMachineScaleSetVMRunCommandsOperations.cs

* Create TestVMExtensionOperations.json

* Delete TestVMExtensionOperations.json

* Create TestVMExtensionOperations.json

* Create TestVMScaleSetExtensions.json

* Compute 2020 12 updated (#17975)

* adding 2020-12-01 compute generated files

* update default sku

* update tests

* test updates

* records

* tests fixes

* all the recorded tests

* more update

* more update

* more update

* last test fixes

* Updated TestVMIdentitySystemAssignedUserAssigned SDK Test to create User Assigned Identity using SDK (#17861)

* Updated TestVMIdentitySystemAssignedUserAssigned SDK Test to create User Assigned MI using MSI SDK

* Resolved Merge Conflicts and updated the test

Co-authored-by: Pavan Rachapudy <vrachapu@microsoft.com>

* Delete AppGW tests (#17977)

* Delete VMScaleSetAppGwWithAS.json

* Delete VMScaleSetAppGwWithAS_A1V2.json

* Delete VMScaleSetAppGwWithAS_SPG_False.json

* Delete VMScaleSetAppGwWithAS_Spot.json

* Delete VMScaleSetAppGWTests.cs

* Delete deprecated ContainerService tests (#17976)

* Delete ContainerServiceOperationalTests.cs

* Delete ContainerServiceTestsBase.cs

* Delete ContainerServiceUpdateTests.cs

* Delete TestDCOSOperations.json

* Delete TestSwarmOperations.json

* Delete TestContainerServiceUpdateOperations.json

* test

* remove test text

Co-authored-by: pavanrachapudy <pavanrachapudy@gmail.com>
Co-authored-by: Pavan Rachapudy <vrachapu@microsoft.com>
Co-authored-by: Adam Sandor <adsandor@microsoft.com>

* new recording files

* 2020-12 release features generated, tests pass

* Update DiskRPTestsBase.cs (#18355)

* Remove CloudService tests (#18423)

* Delete CloudServiceExtensionTests.cs

* Delete CloudServiceOperationTests.cs

* Delete CloudServiceRoleInstanceTests.cs

* Delete CloudServiceScenarioTests.cs

* Delete CloudServiceTestsBase.cs

* Delete CloudServiceUpdateTests.cs

* Delete MultiRole_CreateUpdateGetAndDeleteWithExtension_WorkerAndWebRole.json

* Delete MultiRole_CreateUpdateGetAndDeleteWithExtension_WorkerAndWebRole_MultiRoleExtension.json

* Delete Test_Create_PowerOff_Start_CloudServiceOperation.json

* Delete Test_ListCloudServicesOperation.json

* Delete Test_CloudServiceRoleInstanceOperations.json

* Delete TestCloudServiceScenarioOperations.json

* Delete TestCloudServiceScenarioOperations_DeleteCloudService.json

* Delete TestCloudServiceScenarioOperations_ExtensionProfile.json

* Delete TestCloudServiceScenarioOperations_InstanceView.json

* Delete TestCloudServiceOperations_ScaleIn_ScaleOut.json

* Delete TestCloudServiceUpdateOperations.json

* Update AzSdk.RP.props

* Update AzSdk.RP.props

remove containerService

* Delete ServiceConfigurationHelpers.cs

* regenerate on released 2020-12-01 swagger

* re-recorded test jsons

* test fixes

* Update Helpers.cs

* Update VMDataDiskTests.cs

* Create TestVMDataDiskScenario_ManagedDisk_ForceDetach.json

* Update OrchestrationMode.cs

Co-authored-by: Theodore Chang <thchan@microsoft.com>
Co-authored-by: pavanrachapudy <pavanrachapudy@gmail.com>
Co-authored-by: Pavan Rachapudy <vrachapu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allenjzhang allenjzhang Awaiting requested review from allenjzhang

@bquantump bquantump Awaiting requested review from bquantump

@m-nash m-nash Awaiting requested review from m-nash

@markcowl markcowl Awaiting requested review from markcowl

@nisha-bhatia nisha-bhatia Awaiting requested review from nisha-bhatia

@YalinLi0312 YalinLi0312 Awaiting requested review from YalinLi0312

Assignees

@allenjzhang allenjzhang

Labels
Compute
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sandido @allenjzhang