-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User/avinp/generate turn api #18865
User/avinp/generate turn api #18865
Conversation
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps: For data-plane/track 2 SDKs Issue the following command as a pull request comment:
For track 1 management-plane SDKsPlease open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification. |
...ommunication/Azure.Communication.Identity/api/Azure.Communication.Identity.netstandard2.0.cs
Show resolved
Hide resolved
sdk/communication/Azure.Communication.Identity/src/CommunicationIdentityClient.cs
Outdated
Show resolved
Hide resolved
sdk/communication/Azure.Communication.Identity/src/CommunicationIdentityClient.cs
Outdated
Show resolved
Hide resolved
sdk/communication/Azure.Communication.Identity/src/CommunicationIdentityClient.cs
Outdated
Show resolved
Hide resolved
...unication.Identity/tests/CommunicationIdentityClient/CommunicationIdentityClientLiveTests.cs
Show resolved
Hide resolved
sdk/communication/Azure.Communication.Identity/src/CommunicationIdentityClient.cs
Outdated
Show resolved
Hide resolved
sdk/communication/Azure.Communication.Common/tests/CommunicationRecordedTestSanitizer.cs
Outdated
Show resolved
Hide resolved
7cfa3be
to
edc21a8
Compare
...munication.Identity/tests/Infrastructure/CommunicationIdentityClientRecordedTestSanitizer.cs
Outdated
Show resolved
Hide resolved
sdk/communication/Azure.Communication.Identity/src/CommunicationIdentityClient.cs
Show resolved
Hide resolved
…ic API definition file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few thoughts; nothing that I'd consider blocking. As I don't have familiarity with the service, I'll defer to @RezaJooyandeh for final approval. I'm am happy to serve as the merge-button-preeser, if one is needed.
sdk/communication/Azure.Communication.Identity/samples/README.md
Outdated
Show resolved
Hide resolved
sdk/communication/Azure.Communication.Identity/samples/README.md
Outdated
Show resolved
Hide resolved
sdk/communication/Azure.Communication.Identity/samples/README.md
Outdated
Show resolved
Hide resolved
sdk/communication/Azure.Communication.Identity/samples/README.md
Outdated
Show resolved
Hide resolved
sdk/communication/Azure.Communication.Identity/samples/Sample1_CommunicationIdentityClient.md
Outdated
Show resolved
Hide resolved
...mmunication/Azure.Communication.Identity/samples/Sample1_CommunicationIdentityClientAsync.md
Outdated
Show resolved
Hide resolved
...mmunication/Azure.Communication.Identity/samples/Sample1_CommunicationIdentityClientAsync.md
Outdated
Show resolved
Hide resolved
sdk/communication/Azure.Communication.Identity/samples/Sample1_CommunicationIdentityClient.md
Outdated
Show resolved
Hide resolved
sdk/communication/Azure.Communication.Identity/src/CommunicationIdentityClient.cs
Outdated
Show resolved
Hide resolved
sdk/communication/Azure.Communication.Identity/src/CommunicationIdentityClient.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge once you applied @jsquire 's comments.
978b8ff
into
Azure:feature/communciation/turn_api_private_preview
… TURN Urls response to array (#19391) The following changes are present in this PR (all are based on comments on my original SDK check-in here: #18865). 1. Update SDK to use TURN preview version 2. Update SDK to handle Urls field as an array in TURN response (The corresponding swagger changes can be found here Azure/azure-rest-api-specs#13157) 3. Add Managed Identity TURN API tests. 4. Update code snippets and ReadMe files to match above changes. This checklist is used to make sure that common guidelines for a pull request are followed. - [x] **Please open PR in `Draft` mode if it is:** - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. - [x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above. - [x] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/master/CONTRIBUTING.md).** - [x] **The pull request does not introduce [breaking changes](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md).** - [x] Title of the pull request is clear and informative. - [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). - [x] Pull request includes test coverage for the included changes. - [ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only) - [ ] The `*.csproj` and `AssemblyInfo.cs` files have been updated with the new version of the SDK. Please double check nuget.org current release version. Note: Only applies to `Microsoft.Azure.Management.[RP]` or `Azure.ResourceManager.[RP]` - [ ] Include updated [management metadata](https://github.com/Azure/azure-sdk-for-net/tree/master/eng/mgmt/mgmtmetadata). - [ ] Update AzureRP.props to add/remove version info to maintain up to date API versions. - If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add `new service` label and/or contact assigned reviewer. - If the check fails at the `Verify Code Generation` step, please ensure: - Do not modify any code in generated folders. - Do not selectively include/remove generated files in the PR. - Do use `generate.ps1/cmd` to generate this PR instead of calling `autorest` directly. Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version, Please note: If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.
… TURN Urls response to array (#19391) The following changes are present in this PR (all are based on comments on my original SDK check-in here: #18865). 1. Update SDK to use TURN preview version 2. Update SDK to handle Urls field as an array in TURN response (The corresponding swagger changes can be found here Azure/azure-rest-api-specs#13157) 3. Add Managed Identity TURN API tests. 4. Update code snippets and ReadMe files to match above changes. This checklist is used to make sure that common guidelines for a pull request are followed. - [x] **Please open PR in `Draft` mode if it is:** - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. - [x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above. - [x] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/master/CONTRIBUTING.md).** - [x] **The pull request does not introduce [breaking changes](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md).** - [x] Title of the pull request is clear and informative. - [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). - [x] Pull request includes test coverage for the included changes. - [ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only) - [ ] The `*.csproj` and `AssemblyInfo.cs` files have been updated with the new version of the SDK. Please double check nuget.org current release version. Note: Only applies to `Microsoft.Azure.Management.[RP]` or `Azure.ResourceManager.[RP]` - [ ] Include updated [management metadata](https://github.com/Azure/azure-sdk-for-net/tree/master/eng/mgmt/mgmtmetadata). - [ ] Update AzureRP.props to add/remove version info to maintain up to date API versions. - If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add `new service` label and/or contact assigned reviewer. - If the check fails at the `Verify Code Generation` step, please ensure: - Do not modify any code in generated folders. - Do not selectively include/remove generated files in the PR. - Do use `generate.ps1/cmd` to generate this PR instead of calling `autorest` directly. Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version, Please note: If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.
This PR updates the Azure.Communication.Identity library with an additional API GetTurnCredentials.
This endpoint in the service is gated behind an AFEC and enabled for a preview version.
This version of the SDK is intended to be generated only in private preview at this time and released through the dev feed (not the public nuget feed). Hence, the suggestion from Wes Haggard was to submit this to a feature branch and release SDK from the feature branch into the dev feed.
Link to PR with updated swagger: Azure/azure-rest-api-specs#12881
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
new service
label and/or contact assigned reviewer.Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,
Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.