-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Event Hubs Client] Performance Tests #18960
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquire
added
Event Hubs
Client
This issue points to a problem in the data-plane of the library.
labels
Feb 23, 2021
jsquire
requested review from
christothes,
AlexGhiondea,
conniey and
serkantkaraca
February 23, 2021 20:57
jsquire
requested review from
amishra-dev,
amnguye,
kasobol-msft,
seanmcc-msft and
tg-msft
as code owners
February 23, 2021 20:57
jsquire
force-pushed
the
evnthubs/perf
branch
2 times, most recently
from
February 23, 2021 21:17
6b917d2
to
2a9ee8b
Compare
jsquire
commented
Feb 23, 2021
@@ -10,6 +10,6 @@ When you submit a pull request, a CLA-bot will automatically determine whether y | |||
|
|||
This project has adopted the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/). For more information see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additional questions or comments. | |||
|
|||
Please see our [contributing guide](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/eventhub/Azure.Messaging.EventHubs/CONTRIBUTING.md) for more information. | |||
Please see our [contributing guide](https://github.com/Azure/azure-sdk-for-net/blob/master/CONTRIBUTING.md) for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orthogonal, but I noticed the copy/paste error from MQ work.
jsquire
commented
Feb 23, 2021
@@ -10,6 +10,6 @@ When you submit a pull request, a CLA-bot will automatically determine whether y | |||
|
|||
This project has adopted the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/). For more information see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additional questions or comments. | |||
|
|||
Please see our [contributing guide](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/eventhub/Azure.Messaging.EventHubs/CONTRIBUTING.md) for more information. | |||
Please see our [contributing guide](https://github.com/Azure/azure-sdk-for-net/blob/master/CONTRIBUTING.md) for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orthogonal, but I noticed the copy/paste error from MQ work.
jsquire
force-pushed
the
evnthubs/perf
branch
from
February 23, 2021 21:29
2a9ee8b
to
cd15032
Compare
jsquire
requested review from
chidozieononiwu,
danieljurek,
mitchdenny and
weshaggard
as code owners
February 23, 2021 21:29
jsquire
removed request for
mitchdenny,
tg-msft,
danieljurek,
weshaggard,
amishra-dev and
chidozieononiwu
February 23, 2021 21:36
jsquire
force-pushed
the
evnthubs/perf
branch
from
February 23, 2021 22:28
cd15032
to
282b322
Compare
christothes
approved these changes
Feb 24, 2021
jsquire
force-pushed
the
evnthubs/perf
branch
from
February 24, 2021 14:52
282b322
to
62be4a0
Compare
The focus of these changes is to introduce a set of performance tests for the Event Hubs client library, covering key scenarios for publishing and reading events. Notable omissions to the perforance scenarios are coverage for the `EventProcessorClient` and `EventProcessor<TPartition>`. To effectively test, these require patterns not currently supported in the performance Testing framework and will be addressed at a later time.
jsquire
force-pushed
the
evnthubs/perf
branch
from
February 24, 2021 15:06
62be4a0
to
9c447e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to introduce a set of performance tests for the Event Hubs client library, covering key scenarios for publishing and reading events. Notable omissions to the perforance scenarios are coverage for the
EventProcessorClient
andEventProcessor<TPartition>
. To effectively test, these require patterns not currently supported in the performance testing framework and will be addressed at a later time.Last Upstream Rebase
Wednesday, February 24, 9:45pm (EST)
References and Related