-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for new Copy/Update-LongTermRetentionBackup #19040
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ageRedundancy), add tests for LTR Backup Copy/Update
xaliciayang
changed the title
Backup storage red
Add tests for new Copy/Update-LongTermRetentionBackup
Feb 26, 2021
xaliciayang
requested review from
allenjzhang,
bquantump,
m-nash,
markcowl,
nisha-bhatia and
YalinLi0312
as code owners
February 26, 2021 18:28
bquantump
suggested changes
Feb 26, 2021
sdk/sqlmanagement/Microsoft.Azure.Management.Sql/src/Generated/Models/Database.cs
Show resolved
Hide resolved
bquantump
approved these changes
Mar 3, 2021
allenjzhang
added a commit
that referenced
this pull request
Mar 4, 2021
This reverts commit 66c7d5a.
allenjzhang
added a commit
that referenced
this pull request
Mar 4, 2021
xaliciayang
added a commit
to xaliciayang/azure-sdk-for-net
that referenced
this pull request
Mar 5, 2021
…Azure#19040)" (Azure#19205)" This reverts commit 85e2a5b.
markcowl
pushed a commit
that referenced
this pull request
Mar 14, 2021
…#19246) * Revert "Revert "Add tests for new Copy/Update-LongTermRetentionBackup (#19040)" (#19205)" This reverts commit 85e2a5b. * use azure endpoint * skip test * updated sdk from swagger master * update generate script * update sql_resource-manager.txt * re-update Generated * regenerated clients, and updated AzSdk.RP.props * updated sdk with version 2.0.4417 * re-generated again after autorest --reset * revert generate script and reinstate commit id into sql_resource-manager * remove extra resource-manager.txt file * updated assembly info version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
new service
label and/or contact assigned reviewer.Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,
Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.