[Communication] - SMS - Add Tests and Clean Up

sdk/communication/Azure.Communication.Sms/CHANGELOG.md

@@ -11,7 +11,7 @@
 
 ### Breaking
 - Updated `Task<Response<SendSmsResponse>> SendAsync(PhoneNumberIdentifier from, PhoneNumberIdentifier to, string message, SendSmsOptions sendSmsOptions = null, CancellationToken cancellationToken = default)`
-to `Task<Response<SmsSendResult>> SendAsync(string from, string to, string message, Models.SmsSendOptions options = default)`
+to `Task<Response<SmsSendResult>> SendAsync(string from, string to, string message, SmsSendOptions options = default)`
 - Replaced `SendSmsResponse` with `SmsSendResult`
 
 ## 1.0.0-beta.3 (2020-11-16)

sdk/communication/Azure.Communication.Sms/README.md

@@ -47,31 +47,32 @@ SmsClient client = new SmsClient(new Uri(endpoint), tokenCredential);
 ```
 
 ## Examples
-### Send a SMS Message
+### Send a 1:1 SMS Message
 To send a SMS message, call the `Send` or `SendAsync` function from the `SmsClient`.
 ```C# Snippet:Azure_Communication_Sms_Tests_SendAsync
-SmsSendResult result = await client.SendAsync(
-   from: "+18001230000" // Phone number acquired on your Azure Communication resource
-   to: "+18005670000",
-   message: "Hi");
-Console.WriteLine($"Sms id: {result.MessageId}");
+SmsSendResult sendResult = await smsClient.SendAsync(
+    from: "<from-phone-number>", // Your E.164 formatted from phone number used to send SMS
+    to: "<to-phone-number>", // E.164 formatted recipient phone number
+    message: "Hi");
+Console.WriteLine($"Sms id: {sendResult.MessageId}");
 ```
-### Send a Group SMS Message
+### Send a 1:N SMS Message
 To send a SMS message to a list of recipients, call the `Send` or `SendAsync` function from the `SmsClient` with a list of recipient's phone numbers.
 You may also add pass in an options object to specify whether the delivery report should be enabled and set custom tags.
 ```C# Snippet:Azure_Communication_SmsClient_Send_GroupSmsWithOptions
-Response<IEnumerable<SmsSendResult>> response = await client.SendAsync(
-   from: "+18001230000" // Phone number acquired on your Azure Communication resource
-   to: new string[] {"+18005670000", "+18008900000}",
-   message: "Hi",
-   options: new SmsSendOptions(enableDeliveryReport: true) // OPTIONAL
-   {
-       Tag = "marketing", // custom tags
-   });
+Response<IEnumerable<SmsSendResult>> response = await smsClient.SendAsync(
+    from: "<from-phone-number>", // Your E.164 formatted from phone number used to send SMS
+    to: new string[] { "<to-phone-number-1>", "<to-phone-number-2>" }, // E.164 formatted recipient phone numbers
+    message: "Weekly Promotion!",
+    options: new SmsSendOptions(enableDeliveryReport: true) // OPTIONAL
+    {
+        Tag = "marketing", // custom tags
+    });
 IEnumerable<SmsSendResult> results = response.Value;
 foreach (SmsSendResult result in results)
 {
     Console.WriteLine($"Sms id: {result.MessageId}");
+    Console.WriteLine($"Send Result Successful: {result.Successful}");
 }
 ```
 ## Troubleshooting
@@ -81,8 +82,8 @@ All SMS operations will throw a RequestFailedException on failure.
 try
 {
     SmsSendResult result = await client.SendAsync(
-       from: "+18001230000" // Phone number acquired on your Azure Communication resource
-       to: "+18005670000",
+       from: "<from-phone-number>" // Your E.164 formatted phone number used to send SMS
+       to: "<to-phone-number>", // E.164 formatted recipient phone number
        message: "Hi");
     Console.WriteLine($"Sms id: {result.MessageId}");
 }