-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for Microsoft.StorageCache 2021-03-01. #19447
Update for Microsoft.StorageCache 2021-03-01. #19447
Conversation
PR for the new version. |
Added newline to remove warning listed in the file.
Trying to fix error ##[error]Discrepancy detected between generated code in PR and reference generation. Please note, the files in the Generated folder should not be modified OR adding/excluding files. You may need to re-run sdk<RP_Name>\generate.ps1.
...toragecache/Microsoft.Azure.Management.StorageCache/tests/Fixtures/StorageAccountsFixture.cs
Outdated
Show resolved
Hide resolved
sdk/storagecache/Microsoft.Azure.Management.StorageCache/tests/OperationsTests.cs
Outdated
Show resolved
Hide resolved
sdk/storagecache/Microsoft.Azure.Management.StorageCache/tests/OperationsTests.cs
Outdated
Show resolved
Hide resolved
...oragecache/Microsoft.Azure.Management.StorageCache/tests/Fixtures/StorageCacheTestFixture.cs
Outdated
Show resolved
Hide resolved
sdk/storagecache/Microsoft.Azure.Management.StorageCache/tests/StorageTargetTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
some cosmetic changes.
Discrepancy detected between generated code in PR and reference generation. Please note, the files in the Generated folder should not be modified OR adding/excluding files. You may need to re-run sdk<RP_Name>\generate.ps1. [Hub Generated] Review request for Microsoft.StorageCache to add version stable/2021-03-01 by brpanask · Pull Request #12875 · Azure/azure-rest-api-specs (github.com) The internal review is complete. This one last check in the test suite is failing. I asked on Teams but haven't heard back what to do to fix it. |
@allenjzhang Hi Allen, Can you please take a look at the CI task failure ? |
@nisha-bhatia |
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
new service
label and/or contact assigned reviewer.Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,
Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.