Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Microsoft.StorageCache 2021-03-01. #19447

Merged
merged 7 commits into from
Apr 12, 2021

Conversation

brpanask
Copy link
Contributor

@brpanask brpanask commented Mar 11, 2021

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
  • If the check fails at the Verify Code Generation step, please ensure:
    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@brpanask
Copy link
Contributor Author

PR for the new version.
Azure/azure-rest-api-specs#12875

@brpanask brpanask changed the title Add tests for new blobnfs, dnsRefresh, and ntp/dns content. Update for Microsoft.StorageCache 2021-03-01. Mar 11, 2021
@brpanask brpanask marked this pull request as draft March 11, 2021 05:53
brpanask and others added 4 commits April 2, 2021 11:15
Added newline to remove warning listed in the file.
Trying to fix error 
##[error]Discrepancy detected between generated code in PR and reference generation. Please note, the files in the Generated folder should not be modified OR adding/excluding files. You may need to re-run sdk<RP_Name>\generate.ps1.
Copy link
Contributor

@romahamu romahamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
some cosmetic changes.

@brpanask brpanask marked this pull request as ready for review April 6, 2021 15:14
@brpanask
Copy link
Contributor Author

brpanask commented Apr 6, 2021

Discrepancy detected between generated code in PR and reference generation. Please note, the files in the Generated folder should not be modified OR adding/excluding files. You may need to re-run sdk<RP_Name>\generate.ps1.

[Hub Generated] Review request for Microsoft.StorageCache to add version stable/2021-03-01 by brpanask · Pull Request #12875 · Azure/azure-rest-api-specs (github.com)

The internal review is complete. This one last check in the test suite is failing. I asked on Teams but haven't heard back what to do to fix it.

@romahamu
Copy link
Contributor

romahamu commented Apr 6, 2021

@allenjzhang Hi Allen, Can you please take a look at the CI task failure ?
We do have correct API tag in the readme but still its giving us known issue of discrepancy in generate code.

@brpanask
Copy link
Contributor Author

brpanask commented Apr 8, 2021

image
Adding coverage after fixing the error in the checks.

@nisha-bhatia
This is ready for review now.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants