Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add migration guide #19456

Merged
merged 6 commits into from
Mar 11, 2021
Merged

Add migration guide #19456

merged 6 commits into from
Mar 11, 2021

Conversation

JoshLove-msft
Copy link
Member

@JoshLove-msft JoshLove-msft commented Mar 11, 2021 •
edited
Loading

Resolves #16740

@ghost ghost added the Event Grid label Mar 11, 2021
jsquire
jsquire approved these changes Mar 11, 2021
View reviewed changes
sdk/eventgrid/Azure.Messaging.EventGrid/src/MigrationGuide.md Outdated Show resolved Hide resolved
sdk/eventgrid/Azure.Messaging.EventGrid/src/MigrationGuide.md Outdated Show resolved Hide resolved
sdk/eventgrid/Azure.Messaging.EventGrid/src/MigrationGuide.md Outdated Show resolved Hide resolved
sdk/eventgrid/Azure.Messaging.EventGrid/src/MigrationGuide.md Outdated Show resolved Hide resolved
sdk/eventgrid/Azure.Messaging.EventGrid/src/MigrationGuide.md Outdated Show resolved Hide resolved
sdk/eventgrid/Azure.Messaging.EventGrid/src/MigrationGuide.md Outdated Show resolved Hide resolved
sdk/eventgrid/Azure.Messaging.EventGrid/src/MigrationGuide.md Outdated Show resolved Hide resolved
sdk/eventgrid/Azure.Messaging.EventGrid/src/MigrationGuide.md Outdated Show resolved Hide resolved
sdk/eventgrid/Azure.Messaging.EventGrid/src/MigrationGuide.md Outdated Show resolved Hide resolved
sdk/eventgrid/Azure.Messaging.EventGrid/src/MigrationGuide.md Outdated Show resolved Hide resolved
ellismg
ellismg approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@ellismg ellismg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! A +1 to most of @jsquire's feedback.

JoshLove-msft and others added 3 commits March 11, 2021 13:45
@JoshLove-msft @jsquire
Apply suggestions from code review
01e1d06 
Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
@JoshLove-msft
PR FB
4fa0e19
@JoshLove-msft
explicit type
1482c72
@JoshLove-msft JoshLove-msft enabled auto-merge (squash) March 11, 2021 22:29
@JoshLove-msft JoshLove-msft merged commit dc11d67 into Azure:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsquire jsquire jsquire approved these changes

@ellismg ellismg ellismg approved these changes

@ahamad-MS ahamad-MS Awaiting requested review from ahamad-MS

@jfggdl jfggdl Awaiting requested review from jfggdl

@Kishp01 Kishp01 Awaiting requested review from Kishp01

@YijunXieMS YijunXieMS Awaiting requested review from YijunXieMS

@pakrym pakrym Awaiting requested review from pakrym

Assignees
No one assigned
Labels
Event Grid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migration Guide for Event Grid
5 participants
@JoshLove-msft @jsquire @ellismg @pakrym @YijunXieMS