Add ACR delete tag methods

[annelo-msft]

• Add delete tag methods to ContainerRepositoryClient
• Use Track 1 mgmt plane ACR client library to import images for delete tests
• Refactor client tests so that tests setting read/write attributes to false are marked NonParallelizable

Addresses tag delete in #19547

[heaths]

In Search and Key Vault, we have our own DelayAsync that effectively goes something like this:

protected async ValueTask DelayAsync(TimeSpan? duration = null)
{
  duration ??= TimeSpan.FromSeconds(5);
  if (TestMode == RecordingTestMode.Playback)
  {
    return ValueTask.Completed;
  }
  else
  {
    await Task.Delay(duration);
  }
}

This way, you don't waste time during playback.

[annelo-msft]

Very cool, Heath, thanks for the pointer!

[JoshLove-msft]

We should probably add this to https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/core/Azure.Core.TestFramework/src/TestRecording.cs

[heaths]

If so, take a look at Search or Key Vault's. It's a bit more robust (involved) than this sample, but this shows the gist of it.

[heaths]

...effectively, you can optionally set a delay, or for retries (something else maybe to add, but separate) a polling interval with default. Both should probably take a CancellationToken, not that we use them much (but occasionally).

[ghost]

Hello @annelo-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[annelo-msft]

azp run net - core - ci

[JoshLove-msft]

hmm does the "azp" command not work for container registry, "/azp run net - containerregistry - ci"

[pakrym]

you need a slash '/azp run net - core - ci'

[JoshLove-msft]

Updated

[annelo-msft]

/azp run net - core - ci

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).