Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Key Vault, Search samples using SNIPPET def #20439

Merged
merged 2 commits into from
Apr 15, 2021

Conversation

heaths
Copy link
Member

@heaths heaths commented Apr 15, 2021

Resolves Key Vault's and Search's portions of #20431

Resolves Key Vault's and Search's portions of Azure#20431
@heaths
Copy link
Member Author

heaths commented Apr 15, 2021

There were only 3 markdown changes in 3 different files that are actually desirable. The indentation fix might've been a tool bug, but the other two were user error e.g. VS trying to constantly reformat the file and put the code on a new line after /*@@*/, and I missed it in review.

Copy link
Contributor

@pakrym pakrym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but consider reordering code a bit to allow to merge a few #ifs together.

@heaths heaths enabled auto-merge (squash) April 15, 2021 20:59
@heaths heaths merged commit 133c33c into Azure:master Apr 15, 2021
@heaths heaths deleted the issue20431 branch April 15, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants