[Messaging] AMQP Exception Special Case Handling #20440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The focus of these changes is to follow advice offered by the maintainers of the `Microsoft.Azure.Amqp` library to consider any `InvalidOperationException` or derrivitive that occurs when opening an AMQP connection, link, or session to be transient and allow retries. This is needed because the AMQP library state becomes invalidated when certain network conditions occur, such as the TCP socket being reset. This results in the AMQP library throwing when a connection or link is requested. Rather than surfacing exceptions for the caller's context, an `InvalidOperationException` or `ObjectDisposedException` is thrown to represent the internal state.
jsquire
added
Service Bus
Event Hubs
Client
|
/azp run net - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
||
| switch (ex) | ||
| { | ||
| case InvalidOperationException: |
There was a problem hiding this comment.
Is it worth patching up the IsClosed behavior that we were discussing this morning as part of this PR (so as not to make that bug worse)?
There was a problem hiding this comment.
I'm going to do those in dedicated PRs. I suspect it'll be easier to review if we don't mash them together; I think we'll need a different approach for Event Hubs and Service Bus due to the client hierarchies.
JoshLove-msft
approved these changes
Apr 15, 2021
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Sep 19, 2022
Network 2022 05 01 (Azure#20695) * Adds base for updating Microsoft.Network from version stable/2022-01-01 to version 2022-05-01 * Updates readme * Updates API version in new specs and examples * add DisableTcpStateTracking on nic (Azure#19734) Co-authored-by: Dan Tu <dantu@microsoft.com> * Adding new VIP Swap APIs to support extension resource design (Azure#19698) * Adding new VIP Swap APIs to support extension resource design * fixing validation checks * minor fix * Reverting changes * Minor fix to add a new line * fix description (Azure#19987) Co-authored-by: Dan Tu <dantu@microsoft.com> * Add BillingType Property to ExpressRoutePorts (Azure#19932) * change port json * changes * add Virtual network gateway policy group api (Azure#19766) * finish update on connection configuration references * resolve reference error * finish prettier * resolve sematic error * finish update change * enablePrivateLinkFastPath property for VirtualNetworkGatewayConnection resource (Azure#20050) * Support for Per Rule Actions in Application Gateway WAF (Azure#20027) * Adding changes for per rule actions * Fixing spaces * prettier fix * Addressing PR comments * Address review comments * Add ColoLocation to ExpressRoutePort result (Azure#20033) * Add ColoLocation to ExpressRoutePort result * Fix automation code check error * Merge from network-2022-05-01 * Revert "Merge from network-2022-05-01" This reverts commit f0671a040b2bad684921f8f8ad4b53bb0f4b4a93. Co-authored-by: Jianqi Zhao <jianzhao@microsoft.com> * DDoS Per IP SKU + Custom Policy Deprecation Swagger PR (Azure#19985) * initial changes * example file changes * new files for new apis * adding a period * changing reference * prettier fixes * ddos fix * lint diff fixes * more lint diff errors * fixing operation id * changing bool to string enum * example changes * adding 202s as these are long running ops * examples Co-authored-by: Manas Chakka <manaschakka@microsoft.com> * Adding UnhealthyThreshold property to LB health probes, and updated examples with new property (Azure#20001) * Property to enable/disable OCSP revocation check on client certificate (Azure#20301) * add new property to enable/disable OCSP revocation check on client certificate for MTLS * revert breaking change of updating enum property * Add new parameter asn, geo and expressRouteAdvertise to CustomIPPrefix for new 2022-05-01 nrp sdk version (Azure#20266) * fix * fix * fix * fix * fix * fix Co-authored-by: Weiheng Li <weihl@microsoft.com> * Network 2022-05-01 Azure Virtual Network Manager Contributions (Azure#20440) * Add third NIP enum for avnm security admin config, AllowRulesOnly * add optional top parameters to various network manager post APIs * revise all example input subscriptions to all zero guid * change all top parameter max value to 100 * Revert "change all top parameter max value to 100" This reverts commit 12943d2f2b91b22f1dae232cb291a8551fedfdca. Co-authored-by: Jared Gorthy <jaredgorthy@microsoft.com> * Alpelled waf manifest 05 01 2022 (Azure#20047) * init * init * fix comments * fix err * try ref to appgw def * try ref to appgw def * try ref to appgw def * try ref to appgw def * update example * update example * update example * update state and action * update state and action * change ruleset name and add tiers * cammel case fix * cammel case fix * s_ruleid * s_RuleId * suppress s_RuleId camel case issue * suppress s_RuleId camel case issue * address comments * address comments * address comments * fix typo * cont fix * cont fix * cont fix * cont fix * cont fix * add pageable * add next link Co-authored-by: Alon Pelled <alpelled@microsoft.com> * Add prefixType property to CustomIPPrefix for NRP 2022-05-01 (Azure#20486) * add prefixType parameter * add example * Adding swagger changes for routemaps feature (Azure#20091) * initial changes for routemaps * run npm prettier script * adding examples * fixing validation errors * more validations * more fixes * trying to fix lint error * fix for match condition * renaming ActionType to fix lint * fix for python sdk generation * renaming Rule to RouteMapRule * modify examples to remove vnetroutes from non hub vnet conns * cleanup * Added Upper-case transform (Azure#20674) Co-authored-by: dtuCloud <tudan0103@gmail.com> Co-authored-by: Dan Tu <dantu@microsoft.com> Co-authored-by: shnaya434 <67019054+shnaya434@users.noreply.github.com> Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com> Co-authored-by: tyrannicrex <jiaczh@microsoft.com> Co-authored-by: Jesus Arango <jearango@microsoft.com> Co-authored-by: Sindhu Aluguvelli <sindhureddy216@gmail.com> Co-authored-by: Jianqi Zhao <archie.j.zhao@gmail.com> Co-authored-by: Jianqi Zhao <jianzhao@microsoft.com> Co-authored-by: Manas Chakka <mchakka@gmail.com> Co-authored-by: Manas Chakka <manaschakka@microsoft.com> Co-authored-by: bhavanabheem <109241669+bhavanabheem@users.noreply.github.com> Co-authored-by: biaogao <biga@microsoft.com> Co-authored-by: Weiheng Li <weihengli.tj@gmail.com> Co-authored-by: Weiheng Li <weihl@microsoft.com> Co-authored-by: jago2136 <42753636+jago2136@users.noreply.github.com> Co-authored-by: Jared Gorthy <jaredgorthy@microsoft.com> Co-authored-by: alon-microsoft <31221093+alon-microsoft@users.noreply.github.com> Co-authored-by: Alon Pelled <alpelled@microsoft.com> Co-authored-by: Eric Hoffmann <112216215+erichoffmannms@users.noreply.github.com> Co-authored-by: arganapathy <109313670+arganapathy@users.noreply.github.com> Co-authored-by: rahulbissa2727 <106511944+rahulbissa2727@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to follow advice offered by the maintainers of the
Microsoft.Azure.Amqplibrary to consider anyInvalidOperationExceptionor derrivitive that occurs when opening an AMQP connection, link, or session to be transient and allow retries.
This is needed because the AMQP library state becomes invalidated when certain network conditions occur, such as the TCP socket being reset. This results in the AMQP library throwing when a connection or link is requested. Rather than surfacing exceptions for the caller's context, an
InvalidOperationExceptionor
ObjectDisposedExceptionis thrown to represent the internal state.Last Upstream Rebase
Thursday, April 15, 3:30pm (EDT)
References and Related