[TA and Translatior] Update snippets #20552
Conversation
ghost
added
the
There was a problem hiding this comment.
Given you assign sample strings like string foo = "<replace this>"; which compiles, but then use Uri bar = <replace this> which won't compile, I recommend using the same pattern. If you make sure the code compiles - even with obvious replacement text - you won't even have to use the SNIPPET preproc condition in most of your samples given some clearly isn't executed since the Uri instances you create aren't valid URIs.
| @@ -59,26 +62,30 @@ public void BadRequestSnippet() | |||
| [Ignore("Samples not working yet")] | |||
| public void DocumentTranslationInput() | |||
| { | |||
| #region Snippet:DocumentTranslationSingleInput | |||
| #if SNIPPET | |||
| Uri sourceSasUri = <source SAS URI>; | |||
There was a problem hiding this comment.
Nit: why not use the same format for the snippet as the actual executed code? At least it will compile, and you wouldn't even need the preproc condition.
There was a problem hiding this comment.
True. I was leaving it as is so when we turn on the samples we will pass real values. But not sure when we will do this, so I changed it based on your suggestions.
Thanks!
sdk/translation/Azure.AI.Translation.Document/tests/samples/SampleSnippets.cs
Outdated
Show resolved
Hide resolved
sdk/translation/Azure.AI.Translation.Document/tests/samples/Sample_MultipleInputsAsync.cs
Outdated
Show resolved
Hide resolved
Thank you! |
D'oh! You're right. I completely forgot about that (and did the same as you last week). 🤦♂️ |
ComputeRP 2022-08-01 release (Azure#20552) * add files to new version folder * update version references and readme tags * update common types version line and reference to common.json * add fetures for 2022-08-01 release * remove admin password for ModelValidation CI Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
#20431