Code

Revisions from the MAA API Review#20558

Code

Merged

LarryOsterman merged 55 commits intoAzure:masterAzure/azure-sdk-for-net:masterfrom LarryOsterman:LarryO-ApiReviewFeedbackLarryOsterman/azure-sdk-for-net:LarryO-ApiReviewFeedbackCopy head branch name to clipboardApr 29, 2021

+2,921-1,729

Commits

Commits on Apr 20, 2021

• Revisions from the MAA API Review

  LarryOsterman

  committed
  30e5042

  Copy full SHA for 30e5042

• Added MAA code owners

  LarryOsterman

  committed
  65b8d3c

  Copy full SHA for 65b8d3c

• Fixed typo in codeowners

  LarryOsterman

  committed
  6929e97

  Copy full SHA for 6929e97

• Updated API definitions

  LarryOsterman

  committed
  c560614

  Copy full SHA for c560614

Commits on Apr 21, 2021

• Fixed typo in README.md introduced while cleaning up md errors

  LarryOsterman

  committed
  9f3524a

  Copy full SHA for 9f3524a

• More pull request feedback

  LarryOsterman

  committed
  18b7990

  Copy full SHA for 18b7990

Commits on Apr 22, 2021

• Next round of API review feedback

  LarryOsterman

  committed
  d659679

  Copy full SHA for d659679

• Regenerated swagger

  LarryOsterman

  committed
  c5e50e4

  Copy full SHA for c5e50e4

Commits on Apr 23, 2021

• Obsoleted deprecated claims in output token

  LarryOsterman

  committed
  6f1cde1

  Copy full SHA for 6f1cde1

• Renamed AttestRequest -> AttestationRequst

  LarryOsterman

  committed
  c4fb52c

  Copy full SHA for c4fb52c

• Update sdk/attestation/Azure.Security.Attestation/README.md

  Show description for b1610a5
  

  LarryOsterman

  and

  jsquire

  authored
  b1610a5

  Copy full SHA for b1610a5

• Updated with code review feedback from Jesse Squires

  LarryOsterman

  committed
  e6d80da

  Copy full SHA for e6d80da

• Merge branch 'LarryO-ApiReviewFeedback' of https://github.com/LarryOsterman/azure-sdk-for-net into LarryO-ApiReviewFeedback

  LarryOsterman

  committed
  6561fd5

  Copy full SHA for 6561fd5

• Updated APIs

  LarryOsterman

  committed
  f37d8a4

  Copy full SHA for f37d8a4

• Updated snippets

  LarryOsterman

  committed
  9f47173

  Copy full SHA for 9f47173

Commits on Apr 24, 2021

• Nightly tests also run samples

  LarryOsterman

  committed
  069f515

  Copy full SHA for 069f515

• Added locationShortName to tests.yml to fix live test failures on *nix

  LarryOsterman

  committed
  ad0450d

  Copy full SHA for ad0450d

Commits on Apr 26, 2021

• Update sdk/attestation/Azure.Security.Attestation/src/AttestationToken.cs

  Show description for 85fbf83
  

  LarryOsterman

  and

  jsquire

  authored
  85fbf83

  Copy full SHA for 85fbf83

• Update sdk/attestation/Azure.Security.Attestation/src/AttestationToken.cs

  Show description for 121f324
  

  LarryOsterman

  and

  jsquire

  authored
  121f324

  Copy full SHA for 121f324

• Update sdk/attestation/Azure.Security.Attestation/src/AttestationToken.cs

  Show description for ad3d0c7
  

  LarryOsterman

  and

  jsquire

  authored
  ad3d0c7

  Copy full SHA for ad3d0c7

• Update sdk/attestation/Azure.Security.Attestation/src/AttestationToken.cs

  Show description for 47b675c
  

  LarryOsterman

  and

  jsquire

  authored
  47b675c

  Copy full SHA for 47b675c

• Update sdk/attestation/Azure.Security.Attestation/src/Models/AttestationSigner.cs

  Show description for 012853e
  

  LarryOsterman

  and

  jsquire

  authored
  012853e

  Copy full SHA for 012853e

• Update sdk/attestation/Azure.Security.Attestation/src/AttestationToken.cs

  Show description for b646363
  

  LarryOsterman

  and

  jsquire

  authored
  b646363

  Copy full SHA for b646363

• Update sdk/attestation/Azure.Security.Attestation/src/AttestationTokenValidationOptions.cs

  Show description for a1b4fb8
  

  LarryOsterman

  and

  jsquire

  authored
  a1b4fb8

  Copy full SHA for a1b4fb8

• Update sdk/attestation/Azure.Security.Attestation/src/Models/PolicyCertificateModification.cs

  Show description for b3f76a4
  

  LarryOsterman

  and

  jsquire

  authored
  b3f76a4

  Copy full SHA for b3f76a4

• Update sdk/attestation/Azure.Security.Attestation/src/Models/PolicyCertificateModification.cs

  Show description for 4809fdf
  

  LarryOsterman

  and

  jsquire

  authored
  4809fdf

  Copy full SHA for 4809fdf

• Pull request feedback

  LarryOsterman

  committed
  7eb6f68

  Copy full SHA for 7eb6f68

• Merge branch 'LarryO-ApiReviewFeedback' of https://github.com/LarryOsterman/azure-sdk-for-net into LarryO-ApiReviewFeedback

  LarryOsterman

  committed
  5a74e5c

  Copy full SHA for 5a74e5c

• Regenerate API surface

  LarryOsterman

  committed
  d09153d

  Copy full SHA for d09153d

• Added a reference to the MAA Sample code to readme file; Cleaned up some doccomments in AttestationSigner class

  LarryOsterman

  committed
  b37d489

  Copy full SHA for b37d489

Commits on Apr 27, 2021

• All validation exceptions return a new AttestationTokenValidationFailedException; standardized token validation logic

  LarryOsterman

  committed
  f7669b5

  Copy full SHA for f7669b5

• Updated changelog to flag more breaking changes; cleaned up some doccomments

  LarryOsterman

  committed
  4bf60b2

  Copy full SHA for 4bf60b2

Commits on Apr 28, 2021

• Added model factory for private model types; Added test collateral for model factory, which exposed a raft of issues in the exported types

  LarryOsterman

  committed
  dc149c1

  Copy full SHA for dc149c1

• Updated exported API - PolicyTokenHash is now a BinaryData

  LarryOsterman

  committed
  58b5844

  Copy full SHA for 58b5844

• Update sdk/attestation/Azure.Security.Attestation/src/AttestationToken.cs

  Show description for 4b59011
  

  LarryOsterman

  and

  jsquire

  authored
  4b59011

  Copy full SHA for 4b59011

• Update sdk/attestation/Azure.Security.Attestation/src/AttestationAdministrationClient.cs

  Show description for 9640944
  

  LarryOsterman

  and

  jsquire

  authored
  9640944

  Copy full SHA for 9640944

• Update sdk/attestation/Azure.Security.Attestation/src/AttestationAdministrationClient.cs

  Show description for d479052
  

  LarryOsterman

  and

  jsquire

  authored
  d479052

  Copy full SHA for d479052

• Update sdk/attestation/Azure.Security.Attestation/src/AttestationAdministrationClient.cs

  Show description for d076102
  

  LarryOsterman

  and

  jsquire

  authored
  d076102

  Copy full SHA for d076102

• Update sdk/attestation/Azure.Security.Attestation/src/AttestationToken.cs

  Show description for 0c37f46
  

  LarryOsterman

  and

  jsquire

  authored
  0c37f46

  Copy full SHA for 0c37f46

• Update sdk/attestation/Azure.Security.Attestation/src/AttestationAdministrationClient.cs

  Show description for 086c1f3
  

  LarryOsterman

  and

  jsquire

  authored
  086c1f3

  Copy full SHA for 086c1f3

• Update sdk/attestation/Azure.Security.Attestation/src/AttestationToken.cs

  Show description for b98c829
  

  LarryOsterman

  and

  jsquire

  authored
  b98c829

  Copy full SHA for b98c829

• Update sdk/attestation/Azure.Security.Attestation/src/AttestationToken.cs

  Show description for 5cc34cf
  

  LarryOsterman

  and

  jsquire

  authored
  5cc34cf

  Copy full SHA for 5cc34cf

• Update sdk/attestation/Azure.Security.Attestation/src/AttestationToken.cs

  Show description for 7459a75
  

  LarryOsterman

  and

  jsquire

  authored
  7459a75

  Copy full SHA for 7459a75

• Update sdk/attestation/Azure.Security.Attestation/src/AttestationToken.cs

  Show description for 6d060a0
  

  LarryOsterman

  and

  jsquire

  authored
  6d060a0

  Copy full SHA for 6d060a0

• Update sdk/attestation/Azure.Security.Attestation/src/AttestationToken.cs

  Show description for 92f6e93
  

  LarryOsterman

  and

  jsquire

  authored
  92f6e93

  Copy full SHA for 92f6e93

• Update sdk/attestation/Azure.Security.Attestation/src/AttestationToken.cs

  Show description for 69f3587
  

  LarryOsterman

  and

  jsquire

  authored
  69f3587

  Copy full SHA for 69f3587

• Update sdk/attestation/Azure.Security.Attestation/src/AttestationToken.cs

  Show description for 1af7d0e
  

  LarryOsterman

  and

  jsquire

  authored
  1af7d0e

  Copy full SHA for 1af7d0e

• Apply suggestions from code review

  Show description for bc62864
  

  LarryOsterman

  and

  jsquire

  authored
  bc62864

  Copy full SHA for bc62864

• Added descriptive comments

  LarryOsterman

  committed
  ad30053

  Copy full SHA for ad30053

• Update sdk/attestation/Azure.Security.Attestation/src/AttestationToken.cs

  Show description for 48c6d9a
  

  LarryOsterman

  and

  jsquire

  authored
  48c6d9a

  Copy full SHA for 48c6d9a

• Update sdk/attestation/Azure.Security.Attestation/src/Models/AttestationSigner.cs

  Show description for 49335dc
  

  LarryOsterman

  and

  jsquire

  authored
  49335dc

  Copy full SHA for 49335dc

• Merged token validation failed exception to shared helper.

  LarryOsterman

  committed
  21b0c0e

  Copy full SHA for 21b0c0e

• Merge branch 'master' into LarryO-ApiReviewFeedback

  LarryOsterman

  committed
  b5641a6

  Copy full SHA for b5641a6

• Updated generated elements

  LarryOsterman

  committed
  05c9172

  Copy full SHA for 05c9172

Commits on Apr 29, 2021

• Issue Azure#20745

  LarryOsterman

  committed
  cb00497

  Copy full SHA for cb00497