-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APIM SDK changes for the Spec update of version 2020-12-01 #21001
Conversation
to catch up upstream master om 11th Mar 2021
@KacieKK See my comments in teams on how to fix the current issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change to the csproj, otherwise, this looks good.
@@ -8,7 +8,7 @@ | |||
<Description>Provides ApiManagement management capabilities for Microsoft Azure.</Description> | |||
<AssemblyTitle>Microsoft Azure API Management Management</AssemblyTitle> | |||
<AssemblyName>Microsoft.Azure.Management.ApiManagement</AssemblyName> | |||
<Version>6.0.0-preview</Version> | |||
<Version>7.0.0-preview</Version> | |||
<PackageTags>Microsoft Azure ApiManagement management;API Management;</PackageTags> | |||
<PackageReleaseNotes>Refer https://aka.ms/apimdotnetsdkchangelog for release notes.</PackageReleaseNotes> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this AKA link still valid? You should provide some text here, as people use this to decide whether to download the package or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this AKA will point to CHANGELOG.md, where documents the changes of this new version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markcowl once this PR is merged, the aka.ms link will point to the correct changelog. I hope that is okay?
All SDK Contribution checklist:
api spec PR: Azure/azure-rest-api-specs#12904
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new service
label and/or contact assigned reviewer.If the check fails at the
Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1
. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1
to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.