Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove id type from container base to match operation base #21150

Merged
merged 2 commits into from
May 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,29 +6,27 @@ namespace Azure.ResourceManager.Core
/// <summary>
/// Base class representing collection of resources.
/// </summary>
/// <typeparam name="TIdentifier"> The type of the resource identifier. </typeparam>
public abstract class ContainerBase<TIdentifier> : OperationsBase
where TIdentifier : ResourceIdentifier
public abstract class ContainerBase : OperationsBase
{
/// <summary>
/// Initializes a new instance of the <see cref="ContainerBase{TIdentifier}"/> class for mocking.
/// Initializes a new instance of the <see cref="ContainerBase"/> class for mocking.
/// </summary>
protected ContainerBase()
{
}

/// <summary>
/// Initializes a new instance of the <see cref="ContainerBase{TIdentifier}"/> class.
/// Initializes a new instance of the <see cref="ContainerBase"/> class.
/// </summary>
/// <param name="clientContext"></param>
/// <param name="id"> The identifier of the resource that is the target of operations. </param>
internal ContainerBase(ClientContext clientContext, TIdentifier id)
internal ContainerBase(ClientContext clientContext, ResourceIdentifier id)
: base(clientContext, id)
{
}

/// <summary>
/// Initializes a new instance of the <see cref="ContainerBase{TOperations}"/> class.
/// Initializes a new instance of the <see cref="ContainerBase"/> class.
/// </summary>
/// <param name="parent"> The resource representing the parent resource. </param>
protected ContainerBase(ResourceOperationsBase parent)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ namespace Azure.ResourceManager.Core
/// <typeparam name="TIdentifier"> The type of the resource identifier. </typeparam>
/// <typeparam name="TOperations"> The type of the class containing operations for the underlying resource. </typeparam>
/// <typeparam name="TResource"> The type of the class containing properties for the underlying resource. </typeparam>
public abstract class ResourceContainerBase<TIdentifier, TOperations, TResource> : ContainerBase<TIdentifier>
public abstract class ResourceContainerBase<TIdentifier, TOperations, TResource> : ContainerBase
where TIdentifier : ResourceIdentifier
where TOperations : ResourceOperationsBase<TIdentifier, TOperations>
where TResource : class
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ protected SingletonOperationsBase()
}

/// <summary>
/// Initializes a new instance of the <see cref="ContainerBase{TOperations}"/> class.
/// Initializes a new instance of the <see cref="SingletonOperationsBase{TIdentifier, TOperations}"/> class.
/// </summary>
/// <param name="parent"> The resource representing the parent resource. </param>
protected SingletonOperationsBase(OperationsBase parent)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ namespace Proto.Compute
/// <summary>
/// A class representing collection of VirtualMachine and their operations over a ResourceGroup.
/// </summary>
public class VirtualMachineExtensionImageContainer : ContainerBase<SubscriptionResourceIdentifier>
public class VirtualMachineExtensionImageContainer : ContainerBase
{
private string _subsriptionId;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ namespace Proto.Compute
/// <summary>
/// A class representing collection of VirtualMachine and their operations over a ResourceGroup.
/// </summary>
public class VirtualMachineImageContainer : ContainerBase<SubscriptionResourceIdentifier>
public class VirtualMachineImageContainer : ContainerBase
{
private string _subscriptionId;

Expand Down