[TSI] Address more feedback for API review #21189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bikamani
requested review from
abhipsaMisra,
azabbasi,
barustum,
drwill-ms,
jamdavi,
rasidhan,
timtay-microsoft,
vinagesh and
yeskarthik
as code owners
ghost
added
the
bikamani
commented
May 19, 2021
| @@ -24,7 +24,7 @@ public partial class PropertyValues : TimeSeriesInsightsEventProperty | |||
| /// <summary> | |||
| /// Values of a single property corresponding to the timestamps. May contain nulls. Type of values matches the type of property. | |||
| /// </summary> | |||
| public TimeSeriesValue[] Values => _values ??= CreateValues(); | |||
| public IReadOnlyList<TimeSeriesValue> Values => _values ??= CreateValues(); | |||
There was a problem hiding this comment.
IReadOnlyList because arrays are mutable
bikamani
commented
May 19, 2021
| @@ -183,11 +183,11 @@ Page<TimeSeriesInstance> NextPageFunc(string nextLink, int? pageSizeHint) | |||
| /// <exception cref="ArgumentException"> | |||
| /// The exception is thrown when <paramref name="timeSeriesNames"/> is empty. | |||
| /// </exception> | |||
| public virtual async Task<Response<InstancesOperationResult[]>> GetAsync( | |||
| public virtual async Task<Response<InstancesOperationResult[]>> GetByNameAsync( | |||
There was a problem hiding this comment.
Renaming to make it consistent across different model types.
drwill-ms
reviewed
May 20, 2021
...imeseriesinsights/Azure.IoT.TimeSeriesInsights/src/Customized/Models/TimeSeriesIdProperty.cs
Show resolved
Hide resolved
drwill-ms
reviewed
May 20, 2021
...imeseriesinsights/Azure.IoT.TimeSeriesInsights/src/Customized/Models/TimeSeriesIdProperty.cs
Show resolved
Hide resolved
drwill-ms
reviewed
May 20, 2021
sdk/timeseriesinsights/Azure.IoT.TimeSeriesInsights/src/Models/TimeSeriesQueryAnalyzer.cs
Outdated
Show resolved
Hide resolved
drwill-ms
approved these changes
May 20, 2021
Sandido
added a commit
that referenced
this pull request
May 25, 2021
…021-03-01 (#21333) * [FR] Rename ReadingOrder to FormReadingOrder (#20813) * [Purview] Design Refactor for Scanning (#20811) Based on feedback with the C# architects, we've made some changes to the class factoring here and renamed some methods. The goal was to try to reduce the number of clients we have and clean up some naming issues. * Fix broken CODEOWNERS entry * Remove subscription id since it is not needed in test-resources.json (#20797) * Remove subscription id since it is not needed in test-resources.json * Renames, Delete swallows 404s, Add StringFormatter overloads to Query methods (#20786) * renames * catch 404s * string format overloads for Query methods * Confidential Ledger CI (#20829) * CI only * Standardize on repositoryName parameter name in ContainerRegistryClient methods (#20832) * fix #20831 * update API listing * Remove lock token remarks from settlement method docs (#20826) * Remove lock token remarks from settlement method docs * Remove references to LinkCloseMode. * [FR] Add API version to new methods in 2.1-preview.x (#20817) * Topic filter sample (#20816) * Topic filter sample * Update README.md * Update README.md * Fix link * PR FB * PR fb * Update identity to enable live testing in sovereign clouds for multiple services (#19203) * only identity change * resolve error * change hardcode string * change to supportedclouds * remove hardcode * remove change * remove hardcode * change to have the default in a common place * Remove the StartsWith * Remove the TestEnvironment.KeyvaultScope * Remove change * add hardcode string * Delete TestEnvVar file. * Remove hardcoded value of KeyvaultScope, add a initial value for it * Remove invalid changes. Co-authored-by: Wenjie Yu (Wicresoft North America Ltd) <v-wenjyu@microsoft.com> Co-authored-by: Tong Xu (Wicresoft North America Ltd) <v-xuto@microsoft.com> * [autorest.csharp] Bump to latest, write transforms to correct 2 swaggers. (#20833) A recent bump to autorest core broke the autobump script, as two existing sdks refused validation. This PR does the bump, writes transforms for the short term, and then regenerates code. These issues are filed to update the swagger and remove the transform. https://github.com/Azure/azure-sdk/issues/2803 handles this for ACR. https://github.com/Azure/azure-sdk/issues/2805 handles this for Azure.AI.MetricsAdvisor . * Pick up updated T2 mgmt generator (#20839) * Reference correct version (#20844) * Turn BearerTokenAuthenticationPolicy into BearerTokenChallengeAuthenticationPolicy (#20670) * expose BearerTokenChallengeAuthenticationPolicy through BearerTokenAuthenticationPolicy * Update AutoRest C# version to 3.0.0-beta.20210504.2 (#20851) * Add QueryTimeSpan type (#20841) Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * add comments to properties (#20849) * Temporary remove the NetworkTimeout (#20860) * [TSI] Readme for samples (#20765) * Regenerated from an updated 2020-03-01 swagger that removed faulty property validation (#20862) * Updated TPM attestation APIs to remove BinaryData parameters. (#20843) * Updated TPM attestation APIs at the request of the TPM attestation team * [Event Hubs Client] Move Partition Initialization to the Background (#20733) The focus of these changes is to o refactor partition initialization into the background task responsible for processing the partition. Because failures would still be surfaced through the error handler mechanism and the flow for recovering would follow the existing partition processing failure, there should be no change to usage patterns nor visible behavioral changes. * Update ConfidentialLedger CI path (#20868) * [FR] Flatten TextSyle in TextAppearance (#20857) * redesing for TextAppearance * changelog * updated readme and changelog for may release (#20871) * updated readme and changelog for may release * user version number 1.0.1 for the hot bug fixes * Update samples to use #if SNIPPET (#20847) * Update samples to use #if SNIPPET * Fix docs * [Event Hubs Processor] Validate at Startup (#20861) The focus of these changes is to introduce validation for configuration and permissions errors that would prevent an event processor from being able to recover without intervention. For example, an incorrect connection string or the inability to write to the storage container would be detected. Validation is performed in an unobtrusive way intended to avoid delaying the processor's ability to begin taking ownership of partitions while ensuring that host applications are made aware of fatal problems within the scope of the Start call, rather than having to rely on the error handler. Also included in these changes is retiring of the ListCheckpointsAsync implementation, which was deprecated in favor of GetCheckpointAsync previously. * Update AutoRest C# version (#20869) * [ACR] Cache Refresh Token (#20753) * cache work * WIP * WIP * first e2e impl * renames and comment tidy for clarity * update to expiry and force refresh condition * tests pass * removing printfs * re-record tests to accomodate cached token * fix live tests to run in CI * work in progress * index on acr-cache-refresh-token: f906f3b587 work in progress * update tests * get expiry time from jwt * pr fb * make work with new base class PR * sanitize all but the expiration time in refresh_token in the recorded test logs * record tokens that don't expire + extra comments * pr fb * Initial Confidential Ledger generated client (#20865) * initial Confidential Ledger client * [TSI] Address internal feedback for samples and readme (#20878) * Regenerate SDK for new Swagger File, to remove 400 as expected response (#20806) * Regenerate SDK for new Swagger File, to remove 400 as expected response * Bumping up SDK version to 1.0.0-beta.2 Co-authored-by: Aditi Malladi <amalladi@microsoft.com> * [Event Hubs Client] Test Configuration Adjustments (#20888) The focus of these changes is to adjust the clouds used for nightly and manual test runs, reverting to the Public and Canary clouds. Weekly runs will include the UsGov and China sovereign clouds as well. After discussion, this aligns with the configuration that the engineering team intended. Due to the China cloud performing slowly during runs, we've seen some tests start to exceed the previous execution time cap; this cap has been increased to reduce flakiness in weekly runs. I'll continue to monitor and adjust as we learn more about test stability and performance in the sovereign clouds. * Prepare Azure.Core release (#20885) * [TSI] Address Managed Team API Review comments (#20879) * Rename (#20890) * update changelongs for release (#20891) * update changelongs for release * update codeowners * [TSI] Clarify where a variant type came from (#20894) * Create SUPPORT.md for .NET repo (#20848) * [Event Hubs Processor] Incorporate Validation Feedback (#20884) The focus of these changes is to incorporate some feedback overlooked in the initial validation pull request (#20861). * improve docstrings (#20881) * Add public API spell check to Analyze job (#20088) * Add cspell to Analyze * Forward slashes * Add spellchecking public APIs to aggregate-reports * Add public api spell checking to formrecognizer and aggregate reports pipeline (aggregate reports uses continueOnError: true) * Add spelling exception for ZhHant (a language specification) * Remove empty pwsh step for spellcheck * Simplify checking for npx command Co-authored-by: Heath Stewart <heaths@outlook.com> * Readd negative * Add cspell.json to exceptions, add comments to word list Co-authored-by: Heath Stewart <heaths@outlook.com> * Samples for labeled tables (#20840) * Samples for labeled tables * too excited renaming * Update sdk/formrecognizer/Azure.AI.FormRecognizer/README.md Co-authored-by: Krista Pratico <krpratic@microsoft.com> * selection mark Co-authored-by: Krista Pratico <krpratic@microsoft.com> * Revert changes to SetDevVersion. (#20900) Co-authored-by: Mitch Denny <midenn@microsoft.com> * Back out SetDevVersion changes. (#20899) * Add source generator for system event mapping/constants (#20873) * Add source generator for system event mapping/constants * PR FB * PR FB * Missing files * docsettings * remove code * Fix build * changelog * More fixing * Use correct property * DocSettings * Comment out assert in test (#20876) * Comment out assert in test * Update test * Increment version for core releases (#20903) Increment package version after release of Azure.Core.Experimental * Remove APICompat from released packages (#20886) * Extend Check Enforcer timeout (#20875) Extend the timeout that Check Enforcer applies when waiting for a pipeline to start. * Increment version for eventhub releases (#20893) * Increment package version after release of Microsoft.Azure.EventHubs.Processor * Increment package version after release of Microsoft.Azure.EventHubs * Support modifying feature flag filter parameters (#20866) * Prepare releases of extensions packages and AppConfig (#20887) * Add a JsonPath sanitization callback (#20892) * Update Azure.Core and Experimental (#20915) * tests (#20896) * update the version in the .csproj file to 1.0.1, fix formatting in changelog (#20898) * update the version in the .csproj file to 1.0.1, fix formatting in changelog * add ApiCompatVersion back * Remove Azure.Core.props (#20917) * [Service Bus] Populate TransportType (#20920) The focus of these changes is to populate the `TransportType` property on the `ServiceBusClient` at construction. Previously, the requested `TransportType` was honored but was nor correctly reflected in the property. * [Messaging Function Extension] README Updates (#20924) The focus of these changes is to correct an error in the configuration examples for Event Hubs and to include additional information about the permission grants needed when using managed identity. * Upgrade MSAL and MSAL extesion library dependencies to latest (#20922) * Upgrade MSAL and MSAL extesion library dependencies to latest * exclude x-ms-PKeyAuth from record matching * SDK update for TemplateSpecs GA API 2021-05-01 (#20846) * Preparing for Storage STG 77 beta (#20812) * Cleaned up breaking change description (#20929) * Add spell check for changed files (#20822) * Add spell check for changed files * task -> template * Add exceptions * Add better error handling in Prepare-Release (#20933) Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com> * Increment version for attestation releases (#20932) Increment package version after release of Azure.Security.Attestation * Fix build warnings (#20921) * Confidential Ledger samples (#20930) * Samples * CL samples (#20943) * introduce header name constant * Enable anonymous access for ACR (#20919) * initial commit * backup test-resources.json * work in progress * small cleanup * more tidy * add tests * update API and re-record tests * Prepare for 11.3.0-beta.2 release for Search (#20948) * Update 11.3.0-beta.2 release date for Search * Add period at the end of sentence * [synapse] Add changelog for release (#20867) * [synapse] Add changelog for release * Add line ref for https://github.com/Azure/azure-sdk-for-net/issues/20051 * [Event Hubs] May Release Preparation (#20944) The focus of these changes is to prepare the core Event Hubs package for the May release and update changelogs for the core and processor packages. * regenerating recoveryservices-backup C# SDK for swagger spec V2021-03 (#20827) * generating C# code for V2021-03 * updating file with new SDK version, adding new API version to RP.props * updating test settings with the new API-version * updated the encodedHttpRequestUri with the new API version * updating ListOperations api version for mocking * resetting vault API versions * adding unescaped url to the mock records * adding mock record with unescaped uri for getOperationResults * corrected the status code and added location header in the mocks Co-authored-by: Chandrika Gonuguntla <chgonugu@microsoft.com> * [Communication] - SDK - Renamed EVs to consolidated set (#20925) * Prepare for EG release (#20956) * [Communication] Update the repeatabilityFirstSent timestamp to correct format (#20959) * Update the repeatabilityFirstSent timestamp to correct format * Fix formatting Co-authored-by: Minnie Liu <peiliu@microsoft.com> * Add KV extension RBAC info (#20952) Co-authored-by: Heath Stewart <heaths@outlook.com> * ACR Beta2 Changelog updates (#20966) * beta2 changelog * update changelog * more updates * Increment version for eventhub releases (#20975) Increment package version after release of Azure.Messaging.EventHubs * Increment version for tables releases (#20977) Increment package version after release of Azure.Data.Tables * [Event Hubs Processor] May Release Preparation (#20976) The focus of these changes is to prepare the processor package for the May milestone release. * Increment version for eventhub releases (#20978) Increment package version after release of Azure.Messaging.EventHubs.Processor * Increment version for synapse releases (#20983) Increment package version after release of Azure.Analytics.Synapse.Artifacts * Increment version for search releases (#20980) Increment package version after release of Azure.Search.Documents * Setup INT live tests (#20906) Setup .net live tests pipeline for INT. Add 'INT' configuration in 'subscription configuration' Disable SMS tests and phone number update capability tests in INT because INT does not support SMS yet. Control by EV COMMUNICATION_SKIP_SMS_TEST (false in Prod, true in INT) Disable phone number search test in INT for now since there is no Toll Free number in INT. Control by EV COMMUNICATION_SKIP_PHONENUMBERS_TEST (false in Prod, true in INT) * [MetricsAdvisor] Renamed all TopCount occurrences to MaxPageSize (#20626) * Don't log task canceled exceptions as errors when stopping processor. (#20940) * Don't log task canceled exceptions as errors when stopping processor. Don't log service timeout exceptions as errors when accepting sessions in processor. * Update webjobs test to validate no errors are logged from SDK. * PR FB * More formatting * Change default timeout to prevent flakiness * PR FB * Update AutoRest C# version (#20928) * Update AutoRest C# version to 3.0.0-beta.20210510.2 * Add newly needed Azure.Core.Experimental ref * Export new API Co-authored-by: Chris Hamons <chris.hamons@microsoft.com> * Update CHANGELOG.md with change info (#20988) # All SDK Contribution checklist: This checklist is used to make sure that common guidelines for a pull request are followed. - [ ] **Please open PR in `Draft` mode if it is:** - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. - [ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above. - [ ] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/master/CONTRIBUTING.md).** - [ ] **The pull request does not introduce [breaking changes](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md).** ### [General Guidelines and Best Practices](https://github.com/Azure/azure-sdk-for-net/blob/master/CONTRIBUTING.md#general-guidelines) - [ ] Title of the pull request is clear and informative. - [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/master/CONTRIBUTING.md#testing-guidelines) - [ ] Pull request includes test coverage for the included changes. ### [SDK Generation Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/master/CONTRIBUTING.md#sdk-generation-guidelines) - [ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only) - [ ] The `*.csproj` and `AssemblyInfo.cs` files have been updated with the new version of the SDK. Please double check nuget.org current release version. ## Additional management plane SDK specific contribution checklist: Note: Only applies to `Microsoft.Azure.Management.[RP]` or `Azure.ResourceManager.[RP]` - [ ] Include updated [management metadata](https://github.com/Azure/azure-sdk-for-net/tree/master/eng/mgmt/mgmtmetadata). - [ ] Update AzureRP.props to add/remove version info to maintain up to date API versions. ### Management plane SDK Troubleshooting - If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add `new service` label and/or contact assigned reviewer. - If the check fails at the `Verify Code Generation` step, please ensure: - Do not modify any code in generated folders. - Do not selectively include/remove generated files in the PR. - Do use `generate.ps1/cmd` to generate this PR instead of calling `autorest` directly. Please pay attention to the @microsoft.csharp version output after running `generate.ps1`. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version. **Note: We have recently updated the PSH module called by `generate.ps1` to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command**: `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules` ### Old outstanding PR cleanup Please note: If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers. * Increment version for confidentialledger releases (#20987) Increment package version after release of Azure.Storage.ConfidentialLedger * SQL V5 SDK Release (#20267) * Adding generated models * Add Usage model * Fix Threat Detection tests for release .SDK v5 (#1) * FIX TESTS WITH SDK VERSION 5 * small fixes * records of threat detection tests * Update ImportExport SDK to use newer Import method which is on DatabasesOperations and rerecorded tests (#3) * Fixed all tests * Add missing files * Fix TDE and Usage tests * Remove TDE test * Remove TDE api * Fixed build failures * Remove unwanted sql_resource-manager.txt file * Revert autorest.md file * Add missing discrepancies * Fix build errors * Fix git diff * Fix build error * Update versions in csproj and assemblyinfo Co-authored-by: ayeletshpigelman <ayshpige@microsoft.com> Co-authored-by: brandong-ms <44618010+brandong-ms@users.noreply.github.com> * [MetricsAdvisor] Renamed SkipCount to Skip (#20990) * Update Event Grid version (#21004) * Remove UseLegacyPowerShell (#20986) * Remove UseLegacyPowerShell option * Prepare Key Vault 4.2-beta release (#20901) * Make the query batch a simpler model (#21009) * [Communication] - Divide live test pipeline for each SDK (#20902) * Divide live test pipeline * Divide live test pipeline * Fix pipeline * Adding eng pipeline changes * Fix pipeline * Fix ci pipeline * Fix ci pipeline * Fix ci pipeline * Adding separate yaml files * Setting template as absolute path * Fix path * Fix path * Fix path * Fix default value * Revert tests.yml Co-authored-by: Minnie Liu <peiliu@microsoft.com> * [FR] Move to 2.1 GA (#20967) * oficially move to 2.1 GA * add 3.1.0 to readme * [TA] Targets service version 3.1-preview.5 (#20994) * generation + build + tests + disable healthcare * update public api with new version * Added new api version 2021-02-01 in Az networking (#20989) * Added mew api version 2021-02-01 in Az networking * Added new api version details * Reverted version to 20.5.0 instead of 20.6.0 * Increment version for keyvault releases (#21015) * Increment package version after release of Azure.Security.KeyVault.Administration * Increment package version after release of Azure.Security.KeyVault.Keys * Increment package version after release of Azure.Security.KeyVault.Certificates * Increment package version after release of Azure.Security.KeyVault.Secrets * Increment version for communication releases (#21012) Increment package version after release of Azure.Communication.Chat * Increment version for extensions releases (#21007) Increment package version after release of Microsoft.Extensions.Azure * Increment version for eventgrid releases (#21002) Increment package version after release of Azure.Messaging.EventGrid * Increment version for objectanchors releases (#20999) Increment package version after release of Azure.MixedReality.ObjectAnchors.Conversion * Increment version for containerregistry releases (#20998) Increment package version after release of Azure.Containers.ContainerRegistry * [LLC] Add draft of 'protocol method' help text (#20951) * Adding support for new storage serviceUri configurations (#19647) * Adding support for new storage extensions configurations * remove local artifact building * Adding Configuration tests for Blob and Queue extensions * fixing queue config tests * [CODEOWNERS] WebPubSub (#21003) The focus of these changes is to add the WebPubSub client library and Functions extension into CODEOWNERS. Also included is an update to the Event Hubs service team ownership. * [Smoke Tests] May Release Version Bumps (#21006) Bumping smoke test reference versions to account for the May releases. * Prepare for release (#21022) * Dispose non buffered content streams (#20985) * Prepared Storage for release (#21013) * set version to 3.1.0 (#21029) * Sync eng/common directory with azure-sdk-tools for PR 1594 (#20958) * Update sparse checkout create directory step name * plumb BaseBranchName to create pull request Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Unify Key Vault Administration APIs (#20968) * Rename operation classes and .models namespace * Change order of role definition methods * Use commit 1e2c9f3e for Administration package * Create CreateOrUpdateRoleDefinitionOptions * Rename KeyVaultRoleAssignmentPropertiesWithScope * Enable backup and restore sample * Updated custom role definition tests * Rename to KeyVaultSelectiveKeyRestoreOperation and Result * Update Changelog for 1.4.0 GA release (#21030) * Update Changelog for 1.4.0 GA release * changed back Tables api version from 2020-10 to 2020-08 (#20936) * Increment version for storage releases (#21034) * Increment package version after release of Azure.Storage.Blobs.Batch * Increment package version after release of Azure.Storage.Common * Increment package version after release of Azure.Storage.Blobs * Increment package version after release of Azure.Storage.Files.DataLake * Increment package version after release of Azure.Storage.Blobs.ChangeFeed * Increment package version after release of Azure.Storage.Queues * Increment package version after release of Azure.Storage.Files.Shares * Make Azure.Core cspell-clean (#21027) * [Communication] - Clean up communication pipeline parameters (#21033) * Clean up communication pipeline parameters * Remove tests.yml Co-authored-by: Minnie Liu <peiliu@microsoft.com> * Increment version for identity releases (#21037) Increment package version after release of Azure.Identity * [TSI] - Address comments from SDK Board API review (#20962) * Rename EV (#21036) * Remove note on v4 for Microsoft.Azure.ServiceBus as v5 is already out (#21041) This PR updates the text in the migration guide for Service Bus to avoid using version number on Microsoft.Azure.ServiceBus as newer version of the same is already out. Apologies, the rest of the changes are from my formatter. * [MetricsAdvisor] Updated test hook ID (#21039) * [TA] Add parameter DisableServiceLogs (#21028) * [Purview] Regenerate Catalog Client (#21008) * [Purview Catalog] Regenerate Based on Arch Board Feedback * [Purview Catalog] Reduce number of top level clients * [Purview] Snap Catalog to latest Swagger * [Purview Catalog] Update README.md and CHANGELOG.md * [Purview Scanning] Update README.md and CHANGELOG.md (#21014) * Update service bus dependency (#21044) * [MetricsAdvisor] Added Value and ExpectedValue properties (#20995) * Increment package version after release of Azure.Messaging.ServiceBus (#21043) * Increment version for eventgrid releases (#21052) Increment package version after release of Microsoft.Azure.WebJobs.Extensions.EventGrid * test changes for #13552 and #13578 (#21057) * Increment version for purview releases (#21049) Increment package version after release of Azure.Analytics.Purview.Scanning * Update owners (#20692) * Update owners For Log Analytics and Application Insights - new team members * Update CODEOWNERS Change danhadari74 to danhadari - He updated his user * Add StorageClientProvider support to EventHubs extension (#21047) * Fix AppendPath locic for escaped strings (#21061) * Fix AppendPath logic for escaped strings * Adding SDK for Microsoft.DataProtection (#20683) * adding dataprotection service * changes for sdk generated file * updating swagger sdk with stable version * refactoring naming * adding dummy test * fixing vault creation * policy json changes * updating remove flatten sdk * fixing policy cases * create BI added * changes fore removing friendly name * added backup and restore * added other operations tests * changes for new generate powershell sdk * changes for updated sdk * safejsonconvert changes * changes for adding operation status in mock * changes * recording json * resolving pr comments Co-authored-by: Mayank Aggarwal <mayaggar@microsoft.com> * [Storage] Upgrade API version to 2021-04-01 (#20939) * [synapse] Bump to fc5e2fbcfc3f585d38bdb1c513ce1ad2c570cf3d for hotfix (#21062) * generated new sdk and change test case (#20720) * generated new and change test case * Modified csproj file and assembly file * fixed wording * [Resources] Regenerate from API version 2021-01-01 and 2021-04-01 (#20643) * Regenerate from 2021-01-01 * Re-record deployment and What-If tests * Re-record policy tests * Re-record provider tests * Re-record resource group tests * Re-record resource tests * Re-record tags tests * Re-record template spec tests * Update versions and AzureApiTag * Update assembly file version * Update template spec tests * Update generate.ps1 * Restore managementgroups tests * Add release notes for 2021-01-01 * Add customizations to mitigate breaking changes * generate 2021-04-01 SDK * fix and rerun tests * merge conflict * rerun template specs tests with latest API version * update assembly version and rerun tests * remove launchSettings file * Fix signatures of custom constructors Co-authored-by: Wendy Chang <wendychang@gmail.com> * Remove analyzer suppressions (#21050) * Remove analyzer suppressions * Fix client creation * API update (not really but the file changed) * Remove receiver from MessageProcessor constructor (#21054) * [syanpse] Update CHANGELOG (#21064) # All SDK Contribution checklist: This checklist is used to make sure that common guidelines for a pull request are followed. - [ ] **Please open PR in `Draft` mode if it is:** - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. - [ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above. - [ ] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/master/CONTRIBUTING.md).** - [ ] **The pull request does not introduce [breaking changes](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md).** ### [General Guidelines and Best Practices](https://github.com/Azure/azure-sdk-for-net/blob/master/CONTRIBUTING.md#general-guidelines) - [ ] Title of the pull request is clear and informative. - [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/master/CONTRIBUTING.md#testing-guidelines) - [ ] Pull request includes test coverage for the included changes. ### [SDK Generation Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/master/CONTRIBUTING.md#sdk-generation-guidelines) - [ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only) - [ ] The `*.csproj` and `AssemblyInfo.cs` files have been updated with the new version of the SDK. Please double check nuget.org current release version. ## Additional management plane SDK specific contribution checklist: Note: Only applies to `Microsoft.Azure.Management.[RP]` or `Azure.ResourceManager.[RP]` - [ ] Include updated [management metadata](https://github.com/Azure/azure-sdk-for-net/tree/master/eng/mgmt/mgmtmetadata). - [ ] Update AzureRP.props to add/remove version info to maintain up to date API versions. ### Management plane SDK Troubleshooting - If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add `new service` label and/or contact assigned reviewer. - If the check fails at the `Verify Code Generation` step, please ensure: - Do not modify any code in generated folders. - Do not selectively include/remove generated files in the PR. - Do use `generate.ps1/cmd` to generate this PR instead of calling `autorest` directly. Please pay attention to the @microsoft.csharp version output after running `generate.ps1`. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version. **Note: We have recently updated the PSH module called by `generate.ps1` to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command**: `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules` ### Old outstanding PR cleanup Please note: If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers. * [CODEOWNERS] Remove Wildcards in Messaging (#21060) The focus of these changes is to remove the wildcard paths from the Messaging SDKs to try and allow more targeted alerting for the Azure Functions extensions. * Take Core reference (#21067) * Prepare for release (#21051) * Prepare for release * Update sdk/servicebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/CHANGELOG.md Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Breaking changes Co-authored-by: Jesse Squire <jesse.squire@gmail.com> * Add INT testing in sdk pipelines (#21068) * Add INT testing in sdk pipelines * Add Ignore SMS test check back * Ledger Digest Upload SDK (#21021) * adding ledger changes * all generated changes * adding ledger changes * all generated changes * generated files updates * adding tests, new generated files from databases * updating recorded tests for ledger * renaming file path * adding ListByServerWithHttpMessagesAsync to database operations customizations to fix breaking change * fixing newline spacing * upating based on most recent generation * adding sql_resource-manager.txt file * final updates to ListByServerWithHttpMessagesAsync interface and caller * Microsoft.StoragePool New Service SDK (#21040) * Initial commit * Fixing build errors Co-authored-by: Harshitha Akkaraju <hakkaraj@microsoft.com> * Update gallery example, use 'Reset' rather than 'ResetToPrivate' (#20907) * save the auto-generation work * add gallery application version update auto-generation * nit, add new line * update record json * update record json and add new tests for caps gallery with sharing profile and shared gallery * save work for gallery with sharing profile, caps side test * update blob as source code * uncheck shared gallery test which can not run right now * save * save * add shared gallery tests * generate files again * Revert "generate files again" This reverts commit 051be5469e1ceece14c9bd386de7a54607ce05c2. * update gallery * revert unnecessary change * update examples * Cplat gallery build (#20407) * Creating nuget package for blob as source (#20127) * save the auto-generation work * add gallery application version update auto-generation * nit, add new line * update record json * update record json and add new tests for caps gallery with sharing profile and shared gallery * save work for gallery with sharing profile, caps side test * update blob as source code * uncheck shared gallery test which can not run right now * save * save * add shared gallery tests * generate files again * Revert "generate files again" This reverts commit 051be5469e1ceece14c9bd386de7a54607ce05c2. * update gallery * revert unnecessary change * update examples * Update Microsoft.Azure.Management.Compute.csproj Co-authored-by: kangsun-ctrl <69279251+kangsun-ctrl@users.noreply.github.com> * Update AssemblyInfo.cs * Update Microsoft.Azure.Management.Compute.csproj * nit * Update Microsoft.Azure.Management.Compute.csproj * Update AssemblyInfo.cs * Create AssemblyInfo.cs * commit * update, address comments * update * update test Co-authored-by: Theodore Chang <thchan@microsoft.com> * Use column types for GetObject calls (#21071) * [Core] Improve OperationHelpers used by our LROs (#19105) * Prepare extensions release (#21077) * [Communication] - SMS - Repeatability accepted check for SMS tests (#21063) * Repeatability accepted check for SMS tests * Fix ci build failure Co-authored-by: Minnie Liu <peiliu@microsoft.com> * Update SubscriptionProperties.cs (#21081) the error description for MaxDeliveryCount returns incorrectr property name * allow multiple invocations of archetype-sdk-tests-generate (#21080) Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> * Update keyvault to enable live testing in sovereign clouds for multiple services (#20345) * Update keyvault to enable live testing in sovereign clouds for multiple services * resolve the conflict * Update the CloudConfig vaule. * Remove Preview from the Clouds list. * remove HSM tests * change Clouds to SupportedClouds Co-authored-by: Wenjie Yu (Wicresoft North America Ltd) <v-wenjyu@microsoft.com> * SDK changes for TrafficManager API 2018-08-01 (#20905) * [ACR] Implementation of API Updates for Beta 3 (#21078) * updates from new swagger file for Beta3 API * separate out ArtifactManifestReference type * update autorest.md * re-record repository tests * missed rename * update generated API listing * Update IoT Hub control plane to new version (#21072) * Increment version for extensions releases (#21086) * Increment package version after release of Azure.Extensions.AspNetCore.DataProtection.Blobs * Increment package version after release of Azure.Extensions.AspNetCore.DataProtection.Keys * Increment package version after release of Azure.Extensions.AspNetCore.Configuration.Secrets * [MetricsAdvisor] Re-enabled GetHooksAsync sample (#21091) * [MetricsAdvisor] Whitelisted redacted headers for logging (#21093) * enable healthcare again and updating pii tests (#21108) * update readme issue (#21103) * update readme issue (#21104) * [MetricsAdvisor] Removed HttpRequest and Elasticsearch data sources (#21095) * [Media] AVA SDK Addition (#20700) * regenerated and renamed to pipeline terminology * name update * fixing pr check errors * added public swagger * reverting old sdk * restoring old sdk * updating readme * cleaning up old terminology * addressing PR comments * addressing PR comments * fixes for PR checks: * pr comments * updating connectionstring * exported new api file * updating edge module version * Increment version for synapse releases (#21111) Increment package version after release of Azure.Analytics.Synapse.Artifacts * Use explicit service version (#20770) * Pass service version explicitly to search client options * Initial Checkin for AVA Management SDK (#21070) * Initial Checkin for AVA Management SDK * rerun autorest with rename * regenerate with checked in swaggers * let's see (#21116) * Blobs migration additions (#20965) * blob metadata section * Test new migration samples * sample link fix * pr feedback Co-authored-by: jschrepp-MSFT <41338290+jschrepp-MSFT@users.noreply.github.com> * Added support for message metadata. (#21097) Co-authored-by: Camilo Ramirez <juramir@microsoft.com> * Update AVA Management SDK to use beta instead of preview in version (#21122) * Update AMS Management SDK to use beta instead of preview * Update csproj to use beta instead of preview * add more to changelog (#21110) * add more to changelog * [TA] Implement new Analyze sentiment in Analyze endpoint (#21109) * Make AzureKeyVaultConfigurationProvider case insensitive again (#21141) * Updates for ACR Beta 3 (#21123) * flattening writable properties * correct build * make writeable properties writeable * API updates per consistency * make created on and last updated on required * add registry field back to model types * update registry name to registry login server name * follow-up * add constructors to property types * bug fix * missed API removal * regen API and some whitespace nits * Update sdk/containerregistry/Azure.Containers.ContainerRegistry/src/Models/RepositoryProperties.cs Co-authored-by: Christopher Scott <chriscott@hotmail.com> * Update sdk/containerregistry/Azure.Containers.ContainerRegistry/src/Models/RepositoryProperties.cs Co-authored-by: Christopher Scott <chriscott@hotmail.com> * pr fb Co-authored-by: Christopher Scott <chriscott@hotmail.com> * Add endpoint parameter to LogsClient and MetricsClient (#21073) * Increment version for extensions releases (#21146) Increment package version after release of Azure.Extensions.AspNetCore.Configuration.Secrets * Make MetricUnit an extensible enum, use DateTimeRange in MetricQueryResult (#21145) * add release date (#21147) * Storage Extension release prep. (#21151) * prep webjobs release. * sample config. * Increment version for textanalytics releases (#21154) Increment package version after release of Azure.AI.TextAnalytics * remove hardcoded latest (#21159) * update new swagger (#21158) * Increment version for eventhub releases (#21152) Increment package version after release of Microsoft.Azure.WebJobs.Extensions.EventHubs * [TA] Rename analyze to remove batch from the name (#21134) * rename analyze to remove batch * add changelog * Resource Identity fixes for SQL Server (#21136) * Resource Identity fixes for SQL Server * Modified assemblyinfo and csproj * Increment version for storage releases (#21168) Increment package version after release of Microsoft.Azure.WebJobs.Extensions.Storage.Blobs * Increment version for storage releases (#21169) Increment package version after release of Microsoft.Azure.WebJobs.Extensions.Storage.Queues * Generated a .NET SDK based on new api-version 2020-12-01 (#20300) * Generated based on new api-version 2020-12-01 * Addressed Code review comments. * 2020-12 version is reverted/ * Generated with 2020-12 version * Revert "Generated with 2020-12 version" This reverts commit e6178a7cb54aec24d7b9547cd6752b4d4978d41d. * .Net SDK generated for version "2020-12-01" * Latest changes for apiversion:2020-12 * Move DateTimeRange to Azure.Core.Experimental (#21149) * Statistics as BinaryData property and parameter renames (#21164) * Merge AppConfig 1.0.3 path branch (#21115) * Add metric query sample, cleanup logs samples (#21171) * Sync eng/common directory with azure-sdk-tools for PR 1585 (#21161) * Sparse checkout docs repository in release step * Detect default branch for custom sparse checkout repository * Use sparse checkout paths parameter in docs metadata release Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * SB extension API updates (#21165) * SB extension API updates * PR FB * [AVA] Updating links in ReadMe (#21176) * updating links and changelog * updating links * Fix ShareLink sample to be able to build again (#21170) * Fix ShareLink sample to be able to build again Relates to #21074 * Build Key Vault samples in CI * [Communication] - Azure.Communication.NetworkTraversal - Adding the ACS NetworkTraversal SDK (#21094) * Adding the Azure.Communication.NetworkTraversal SDK * Adding the Azure.Communication.NetworkTraversal SDK - update * [TextAnalytics] Updated Text Analytics to use new OperationInternal class (#21121) * [MetricsAdvisor] Moved Admin-related models to the Administration namespace (#21184) * [MetricsAdvisor] Updating code with the latest swagger changes (#21179) * Update CODEOWNERS (#21198) * Add heaths to codeowners for videoanalyzer (#21194) * Add heaths to codeowners for videoanalyzer * Use separate notification lists for VideoAnalyzer * Fix changelog. (#21201) * Increment package version after release of Microsoft.Azure.WebJobs.Extensions.ServiceBus (#21202) * Update ContentRange.cs due to large 2gb+ file transfers causing exception (#20734) * Update ContentRange.cs When using client side encryption for large files transfers you get an exception when downloading a large file from blob storage. Specifically file size greater then max int32 value 2147483647. The exception occurs during first stream access. Since long values are expected the string parsing should have been done with long.Parse(). Once changed the issue goes away. Exception Message : System.OverflowException: Value was either too large or too small for an Int32. at System.Number.ParseInt32(String s, NumberStyles style, NumberFormatInfo info) at Azure.Storage.Blobs.Models.ContentRange.Parse(String headerValue) at Azure.Storage.Blobs.BlobClientSideDecryptor.<DecryptInternal>d__2.MoveNext() --- End of stack trace from previous location where exception was thrown --- * Update ClientSideEncryptionTests.cs Test for issue with client side encryption for large files transfers you get an exception when downloading a large file from blob storage. Specifically file size greater then max int32 value 2147483647. The exception occurs during first stream access. Since long values are expected the string parsing should have been done with long.Parse(). Once changed the issue goes away. Exception Message : System.OverflowException: Value was either too large or too small for an Int32. at System.Number.ParseInt32(String s, NumberStyles style, NumberFormatInfo info) at Azure.Storage.Blobs.Models.ContentRange.Parse(String headerValue) at Azure.Storage.Blobs.BlobClientSideDecryptor.d__2.MoveNext() --- End of stack trace from previous location where exception was thrown --- * Update ClientSideEncryptionTests.cs * [TA] Add action types (#21197) * add action types * add , * rename TextAnalyticsActionDetails to TextAnalyticsActionResult (#21207) * Updated Changelog (#21210) * Update Key Vault READMEs with links for RBAC (#21212) Fixes #20957 * general change for all livetest pipelines (#20835) * [TSI] Address more feedback for API review (#21189) * Increment version for videoanalyzer releases (#21200) Increment package version after release of Azure.Media.VideoAnalyzer.Edge * Update AutoRest C# version (#21000) * Update AutoRest C# version to 3.0.0-beta.20210519.2 * Disable CS0169 warning due to https://github.com/Azure/autorest.csharp/issues/1255 Co-authored-by: Chris Hamons <chris.hamons@microsoft.com> * InteractiveBrowser LoginHint (#21082) * InteractiveBrowser LoginHint * Update order of resources in the support.md (#21163) GitHub issues should not be the last thing we mention in the support doc after community resources. This PR re-orders the resources in the order that we expect people to use * Add code samples for document translator sdk (#21214) * Add code samples for document translator sdk * adjust spacing * Add Document Translator Sample in README * allow passing document path in Document Translator code samples * Remove csproj and Program.cs from Document translator samples * address PR comments * edit comment in Document Translator Samples * modify sample to compy with our CI Co-authored-by: Fady Essam <faanis@microsoft.com> Co-authored-by: Mariana Rios Flores <mariari@microsoft.com> * SDK update for adding GetbackupUsageSummaries API in passive (#21221) * SDK update for adding GetbackupUsageSummaries API in passive stamp(2018-12-20) * Updating version * [DataFactory]Added new features into 4.19.0 (#21018) * [DataFactory]Added new features into 4.18.0 * [DataFactory]Added new features into 4.19.0 * enable custom forms no labels (#21233) * Update AutoRest C# version (#21232) * Update AutoRest C# version to 3.0.0-beta.20210520.3 * Move to new autorest auth option names * Update README.md (#21235) * [Farmbeats] Initial Package Generation (#20818) * Move GeoJson types to Azure.Core (#21208) * Add read-only lun field (#21220) Co-authored-by: Harshitha Akkaraju <hakkaraj@microsoft.com> * [NetAppFiles] Update to api-version 2021-02-01 (#21223) * Apply 2021-02-01 updates * Rename backup tests folder since it was ignored Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com> * Sync eng/common directory with azure-sdk-tools for PR 1615 (#21234) * Move docindex.yml from steps -> jobs * Add docindex.yml Co-authored-by: Daniel Jurek <djurek@microsoft.com> * [Event Grid Client] Overview README (#21190) The focus of these changes is to add the overview content as a README in the root of the SDK directory, which will be used by the MS Docs site to as the landing page: [Azure Event Grid libraries for .NET - Azure for .NET Developers](https://docs.microsoft.com/dotnet/api/overview/azure/eventgrid) * [FarmBeats] Use new directives in autorest.md (#21238) This is the work from #21232 applied to farm beats, the changes went in concurrently and didn't see one another. * API updates to support function level autocomplete (#21181) * API updates to support function level autocomplete. * Fix test * Fix docs * Updating autorest readme link (#21244) Co-authored-by: Minnie Liu <peiliu@microsoft.com> * reduce number of allocations. (#21243) * Rename StartSelectiveRestore to StartSelectiveKeyRestore (#21249) Resolves #21245 * Only ignore OperationCanceledException if cancellationToken is cancelled (#21250) * [ACR] Add performance tests for common scenarios (#21229) * initial addition of perf tests * further updates to perf tests * use separate scenarios * doc bug * pr fb * pr fb * [ACR] Remove delays after deletes in tests. (#21268) * remove delays before deletes * small renames and change test mode * generated sdk code Co-authored-by: Mariana Rios Flores <mariari@microsoft.com> Co-authored-by: Matt Ellis <matell@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Sam Cheung <sacheu@microsoft.com> Co-authored-by: Christopher Scott <chriss@microsoft.com> Co-authored-by: Anne Thompson <annelo@microsoft.com> Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> Co-authored-by: Yun Lu (MSFT) <53427149+Luyunmt@users.noreply.github.com> Co-authored-by: Wenjie Yu (Wicresoft North America Ltd) <v-wenjyu@microsoft.com> Co-authored-by: Tong Xu (Wicresoft North America Ltd) <v-xuto@microsoft.com> Co-authored-by: Chris Hamons <chris.hamons@microsoft.com> Co-authored-by: Pavel Krymets <pavel@krymets.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Jesse Squire <jesse.squire@gmail.com> Co-authored-by: bikamani <41314966+bikamani@users.noreply.github.com> Co-authored-by: David R. Williamson <drwill@microsoft.com> Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com> Co-authored-by: Jesse Squire <jsquire@microsoft.com> Co-authored-by: glorialimicrosoft <67171398+glorialimicrosoft@users.noreply.github.com> Co-authored-by: Aditi <12823918+aditimalladi@users.noreply.github.com> Co-authored-by: Aditi Malladi <amalladi@microsoft.com> Co-authored-by: Basel Rustum <barustum@microsoft.com> Co-authored-by: Elena <elraikhm@microsoft.com> Co-authored-by: Daniel Jurek <djurek@microsoft.com> Co-authored-by: Heath Stewart <heaths@outlook.com> Co-authored-by: Krista Pratico <krpratic@microsoft.com> Co-authored-by: Mitch Denny <midenn@microsoft.com> Co-authored-by: ankitarorabit <48968483+ankitarorabit@users.noreply.github.com> Co-authored-by: Scott Schaab <sschaab@microsoft.com> Co-authored-by: Gokul Premraj <gopremra@microsoft.com> Co-authored-by: Sean McCullough <44180881+seanmcc-msft@users.noreply.github.com> Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com> Co-authored-by: Mohit Chakraborty <8271806+Mohit-Chakraborty@users.noreply.github.com> Co-authored-by: chandrikagonuguntla <chandrikagonuguntla@users.noreply.github.com> Co-authored-by: Chandrika Gonuguntla <chgonugu@microsoft.com> Co-authored-by: Jorge Beauregard <69869951+jbeauregardb@users.noreply.github.com> Co-authored-by: minnieliu <minnieliu96@hotmail.com> Co-authored-by: Minnie Liu <peiliu@microsoft.com> Co-authored-by: Caio Saldanha <camaiaor@microsoft.com> Co-authored-by: jastenze <jastenze@microsoft.com> Co-authored-by: viparek <78561564+viparek@users.noreply.github.com> Co-authored-by: ayeletshpigelman <ayshpige@microsoft.com> Co-authored-by: brandong-ms <44618010+brandong-ms@users.noreply.github.com> Co-authored-by: Heath Stewart <heaths@microsoft.com> Co-authored-by: Mikhail <mikhail.tryakhov@gmail.com> Co-authored-by: karshinlin <lin.karshin@gmail.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> Co-authored-by: dabenhamMic <74346518+dabenhamMic@users.noreply.github.com> Co-authored-by: armansabaa <abdelrahman.elsabaa@gmail.com> Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com> Co-authored-by: omziv <80668253+omziv@users.noreply.github.com> Co-authored-by: Mayank Aggarwal <mayankagg9722@gmail.com> Co-authored-by: Mayank Aggarwal <mayaggar@microsoft.com> Co-authored-by: Wei Wei <weiwei@microsoft.com> Co-authored-by: ruiminhu <62581379+ruiminhu@users.noreply.github.com> Co-authored-by: Shenglong Li <shenglong.li@outlook.com> Co-authored-by: Wendy Chang <wendychang@gmail.com> Co-authored-by: rewongmicrosoft <57964114+rewongmicrosoft@users.noreply.github.com> Co-authored-by: Harshitha Akkaraju <24836340+harshitha-akkaraju@users.noreply.github.com> Co-authored-by: Harshitha Akkaraju <hakkaraj@microsoft.com> Co-authored-by: kangsun-ctrl <69279251+kangsun-ctrl@users.noreply.github.com> Co-authored-by: Theodore Chang <thchan@microsoft.com> Co-authored-by: Oscar Cabrero <osac@microsoft.com> Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> Co-authored-by: zedy <81678720+zedy-wj@users.noreply.github.com> Co-authored-by: allencal <31420469+allencal@users.noreply.github.com> Co-authored-by: Yilin Hu (MSFT) <76771069+v-yilinhu@users.noreply.github.com> Co-authored-by: hivyas <61890270+hivyas@users.noreply.github.com> Co-authored-by: giakas <giakas@microsoft.com> Co-authored-by: Kamil Sobol <61715331+kasobol-msft@users.noreply.github.com> Co-authored-by: James <41338290+jaschrep-msft@users.noreply.github.com> Co-authored-by: jschrepp-MSFT <41338290+jschrepp-MSFT@users.noreply.github.com> Co-authored-by: Camilo Ramirez <camilo.ramirez@microsoft.com> Co-authored-by: Camilo Ramirez <juramir@microsoft.com> Co-authored-by: Christopher Scott <chriscott@hotmail.com> Co-authored-by: Kamil Sobol <kasobol@microsoft.com> Co-authored-by: Kota Sudhakar Reddy <60102891+Kotasudhakarreddy@users.noreply.github.com> Co-authored-by: Andrew Peacock <ajpeacock0@outlook.com> Co-authored-by: csolonowicz <csolonowicz@users.noreply.github.com> Co-authored-by: Amanda Nguyen <48961492+amnguye@users.noreply.github.com> Co-authored-by: paola Mariana vicencio Hernandez <pvicencio@microsoft.com> Co-authored-by: Fady Essam <fadyesam1996@gmail.com> Co-authored-by: Fady Essam <faanis@microsoft.com> Co-authored-by: Pratima Upadhyay <pratima.upadhyay02@gmail.com> Co-authored-by: Jingshu923 <52914166+Jingshu923@users.noreply.github.com> Co-authored-by: Auðunn <audunn@netapp.com> Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com> Co-authored-by: Mike Harder <mharder@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are couple more things to add, coming in a follow up PR.