Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit pass on AuthorizationCodeCredential class description #22198

Merged
merged 4 commits into from
Jun 30, 2021

Conversation

scottaddie
Copy link
Member

Remove the hard-coded locale and change "and" to "an".

Remove the hard-coded locale and change "and" to "an".
Copy link
Member

@christothes christothes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @scottaddie !

@joshfree joshfree added Client This issue points to a problem in the data-plane of the library. Docs labels Jun 25, 2021
@joshfree joshfree added this to the [2021] July milestone Jun 25, 2021
Co-authored-by: Jesse Squire <jsquire@microsoft.com>
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

@scottaddie scottaddie merged commit 22a5250 into main Jun 30, 2021
@scottaddie scottaddie deleted the scottaddie/class-desc-typos branch June 30, 2021 16:55
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Feb 22, 2023
release 2023 02 01 (Azure#22474)

* Adds base for updating Microsoft.SecurityInsights from version stable/2022-11-01 to version 2023-02-01

* Updates readme

* Updates API version in new specs and examples

* Provider sync properties (Azure#22198)

* Alert Rules - add alert details override changes and PUT example (Azure#22196)

* add alert details override changes and PUT example

* add missing brace

* add closing brace for alertDetailsOverride

* add dynamic properties to 200 response

* add dynamic details to 201 response

---------

Co-authored-by: ShaniFelig <shfelifelig@microsoft.com>

* Release Metadata 2023-02-01 stable version. (Azure#22161)

* Release Metadata 2023-02-01 stable version.

* Fix Swagger spec validation errors.

* Revert Metadata service version to 2022-12-01-preview

* Bring back changes for version 2023-02-01

* Fix model validation

---------

Co-authored-by: Dor Siso <60354892+dosiso@users.noreply.github.com>
Co-authored-by: ShaniFelig <74960756+ShaniFelig@users.noreply.github.com>
Co-authored-by: ShaniFelig <shfelifelig@microsoft.com>
Co-authored-by: Samuel Kuang <samuk@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants