Release Azure.ResourceManager.KeyVault

.github/CODEOWNERS

@@ -1,5 +1,5 @@
 # Instructions for CODEOWNERS file format and automatic build failure notifications:
-# https://github.com/Azure/azure-sdk/blob/master/docs/policies/opensource.md#codeowners
+# https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners
 
 #########
 # SDK
@@ -113,6 +113,10 @@
 # ServiceLabel: %Cloud Shell %Service Attention
 #/<NotInRepo>/            @maertendMSFT
 
+# PRLabel: %Cognitive - Language
+# ServiceLabel: %Cognitive - Language %Service Attention
+/sdk/cognitivelanguage/                         @heaths @rokulka
+
 # ServiceLabel: %Cognitive - Anomaly Detector %Service Attention
 /sdk/cognitiveservices/AnomalyDetector/            @yingqunpku @bowgong
 
@@ -177,7 +181,8 @@
 #/<NotInRepo>/            @ms-premp @qiaozha
 
 # PRLabel: %Communication
-/sdk/communication/                             @acsdevx-msft
+/sdk/communication/                              @acsdevx-msft
+/sdk/communication/Azure.Communication.Identity/ @petrsvihlik @martinbarnas-ms
 
 # ServiceLabel: %Compute %Service Attention
 # PRLabel: %Compute
@@ -269,11 +274,11 @@
 
 # PRLabel: %Digital Twins
 # ServiceLabel: %Digital Twins %Service Attention
-/sdk/digitaltwins/                              @drwill-ms @timtay-microsoft @abhipsaMisra @vinagesh @azabbasi @bikamani @barustum @jamdavi
+/sdk/digitaltwins/                              @drwill-ms @timtay-microsoft @abhipsaMisra @vinagesh @azabbasi @barustum @jamdavi
 
 # PRLabel: %IoT Models Repository
 # ServiceLabel: %IoT Models Repository %Service Attention
-/sdk/modelsrepository/                              @drwill-ms @timtay-microsoft @abhipsaMisra @vinagesh @azabbasi @bikamani @barustum @jamdavi @digimaun
+/sdk/modelsrepository/                              @drwill-ms @timtay-microsoft @abhipsaMisra @vinagesh @azabbasi @barustum @jamdavi @digimaun
 
 # PRLabel: %TimeSeriesInsights
 # ServiceLabel: %TimeSeriesInsights %Service Attention
@@ -290,7 +295,7 @@
 /sdk/eventhub/                                  @serkantkaraca @jsquire
 
 # PRLabel: %Event Hubs %Functions
-/sdk/eventhub/eventhub/Microsoft.Azure.WebJobs.Extensions.EventHubs/ @pakrym @JoshLove-msft @jsquire
+/sdk/eventhub/Microsoft.Azure.WebJobs.Extensions.EventHubs/ @pakrym @JoshLove-msft @jsquire
 
 # ServiceLabel: %Event Hubs %Service Attention
 /sdk/eventhub/Microsoft.Azure.EventHubs/   @serkantkaraca @sjkwak @kasun04
@@ -320,7 +325,7 @@
 #/<NotInRepo>/            @madhurinms
 
 # PRLabel: %Iot
-/sdk/iot/                               @drwill-ms @timtay-microsoft @abhipsaMisra @vinagesh @azabbasi @bikamani @barustum @jamdavi
+/sdk/iot/                               @drwill-ms @timtay-microsoft @abhipsaMisra @vinagesh @azabbasi @barustum @jamdavi
 
 # ServiceLabel: %IotCentral %Service Attention
 /sdk/iotcentral/Microsoft.Azure.Management.IotCentral/           @iluican @jlian
@@ -330,7 +335,7 @@
 
 # PRLabel: %IotHub
 # ServiceLabel: %IotHub %Service Attention
-/sdk/iothub/                            @drwill-ms @timtay-microsoft @abhipsaMisra @vinagesh @azabbasi @bikamani @barustum @jamdavi
+/sdk/iothub/                            @drwill-ms @timtay-microsoft @abhipsaMisra @vinagesh @azabbasi @barustum @jamdavi
 
 # ServiceLabel: %IotHub %Service Attention
 /sdk/iothub/Microsoft.Azure.Management.IotHub/            @rkmanda @chieftn
@@ -602,7 +607,7 @@ sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/            @tmsupp
 
 # ServiceLabel: %Synapse %Service Attention
 # PRLabel: %Synapse
-/sdk/synapse/            @aim-for-better @idear1203 @chamons
+/sdk/synapse/            @aim-for-better @idear1203 @annelo-msft
 
 # PRLabel: %Tables
 /sdk/tables/                                    @christothes
@@ -636,8 +641,8 @@ sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/            @tmsupp
 
 # ######## Management Plane ########
 
-/**/*Management*/                               @allenjzhang @m-nash @markcowl @YalinLi0312 @nisha-bhatia
-/**/Azure.ResourceManager*/                     @allenjzhang @m-nash @markcowl @YalinLi0312 @nisha-bhatia
+/**/*Management*/                               @m-nash @fengzhou-msft @archerzz @ArcturusZhang @yungezz
+/**/Azure.ResourceManager*/                     @m-nash @fengzhou-msft @archerzz @ArcturusZhang @yungezz
 
 # Reviewers to double check any API changes
 /sdk/**/api/                                    @KrzysztofCwalina @tg-msft
@@ -647,7 +652,10 @@ sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/            @tmsupp
 
 
 # ######## Eng Sys ######## 
-/eng/           @weshaggard @chidozieononiwu @mitchdenny @danieljurek
+/eng/           @weshaggard @chidozieononiwu @danieljurek
 /eng/mgmt/      @allenjzhang @m-nash @markcowl
 /**/tests.yml   @benbp
-/**/ci.yml      @mitchdenny
+/**/ci.yml      @chidozieononiwu
+
+# Add owners for notifications for specific pipelines
+/eng/pipelines/aggregate-reports.yml            @AlexGhiondea @maririos

.github/pull_request_assignment.yml

@@ -5,9 +5,8 @@
       - "sdk/**/Microsoft.Azure.Management*/**"
       - "sdk/**/Azure.ResourceManger*/**"
     reviewers:
-      - allenjzhang
-      - YalinLi0312
       - m-nash
-      - markcowl
-      - nisha-bhatia
-      - JonathanCrd
+      - fengzhou-msft
+      - archerzz
+      - ArcturusZhang
+      - yungezz

.vscode/cspell.json

@@ -35,6 +35,7 @@
     "azsdk",
     "blazor",
     "contoso",
+    "deserializable",
     "deserializes",
     "diagnoser",
     "dtmf",
@@ -72,6 +73,21 @@
     {
       "filename": "**/eng/pipelines/templates/jobs/ci.yml",
       "words": ["warnaserror"]
+    },
+    {
+      "filename": "**/sdk/storage/**/*.cs",
+      "words": [
+        "Aadds",
+        "Deprovisioning",
+        "Gzrs",
+        "Ntfs",
+        "Posix",
+        "Ragrs",
+        "Ragzrs",
+        "Rehydrated",
+        "Skus",
+        "Undelete"
+      ]
     }
   ],
   "allowCompoundWords": true

common/ManagementTestShared/Redesign/ManagementGroupCleanupPolicy.cs

@@ -0,0 +1,37 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using Azure.Core;
+using Azure.Core.Pipeline;
+using System.Collections.Generic;
+using System.Text.RegularExpressions;
+
+namespace Azure.ResourceManager.TestFramework
+{
+    public class ManagementGroupCleanupPolicy : HttpPipelineSynchronousPolicy
+    {
+        private readonly object _listLock = new object();
+        private Regex _mgmtGroupPattern = new Regex(@"(/providers/Microsoft\.Management/managementGroups/[^?/]+)\?api-version");
+        private readonly IList<string> _mgmtGroupCreated = new List<string>();
+
+        public IList<string> ManagementGroupsCreated
+        {
+            get { return _mgmtGroupCreated; }
+        }
+
+        public override void OnSendingRequest(HttpMessage message)
+        {
+            if (message.Request.Method == RequestMethod.Put)
+            {
+                var match = _mgmtGroupPattern.Match(message.Request.Uri.ToString());
+                if (match.Success)
+                {
+                    lock (_listLock)
+                    {
+                        _mgmtGroupCreated.Add(match.Groups[1].Value);
+                    }
+                }
+            }
+        }
+    }
+}

common/ManagementTestShared/Redesign/ManagementRecordedTestBase.cs

@@ -17,9 +17,13 @@ namespace Azure.ResourceManager.TestFramework
     public abstract class ManagementRecordedTestBase<TEnvironment> : RecordedTestBase<TEnvironment>
         where TEnvironment: TestEnvironment, new()
     {
-        protected ResourceGroupCleanupPolicy CleanupPolicy = new ResourceGroupCleanupPolicy();
+        protected ResourceGroupCleanupPolicy ResourceGroupCleanupPolicy = new ResourceGroupCleanupPolicy();
 
-        protected ResourceGroupCleanupPolicy OneTimeCleanupPolicy = new ResourceGroupCleanupPolicy();
+        protected ResourceGroupCleanupPolicy OneTimeResourceGroupCleanupPolicy = new ResourceGroupCleanupPolicy();
+
+        protected ManagementGroupCleanupPolicy ManagementGroupCleanupPolicy = new ManagementGroupCleanupPolicy();
+
+        protected ManagementGroupCleanupPolicy OneTimeManagementGroupCleanupPolicy = new ManagementGroupCleanupPolicy();
 
         protected ArmClient GlobalClient { get; private set; }
 
@@ -47,8 +51,7 @@ private void Initialize()
         {
             if (Mode == RecordedTestMode.Playback)
             {
-                var opInternalType = typeof(OperationInternals);
-                var pollField = opInternalType.GetField("<DefaultPollingInterval>k__BackingField", BindingFlags.Static | BindingFlags.NonPublic);
+                var pollField = typeof(OperationInternals).GetField("<DefaultPollingInterval>k__BackingField", BindingFlags.Static | BindingFlags.NonPublic);
                 pollField.SetValue(null, TimeSpan.Zero);
             }
         }
@@ -59,6 +62,7 @@ private ArmClient GetCleanupClient()
             {
                 return new ArmClient(
                         TestEnvironment.SubscriptionId,
+                        GetUri(TestEnvironment.ResourceManagerUrl),
                         TestEnvironment.Credential,
                         new ArmClientOptions());
             }
@@ -70,14 +74,21 @@ private ArmClient GetCleanupClient()
         protected ArmClient GetArmClient(ArmClientOptions clientOptions = default)
         {
             var options = InstrumentClientOptions(clientOptions ?? new ArmClientOptions());
-            options.AddPolicy(CleanupPolicy, HttpPipelinePosition.PerCall);
+            options.AddPolicy(ResourceGroupCleanupPolicy, HttpPipelinePosition.PerCall);
+            options.AddPolicy(ManagementGroupCleanupPolicy, HttpPipelinePosition.PerCall);
 
             return CreateClient<ArmClient>(
                 TestEnvironment.SubscriptionId,
+                GetUri(TestEnvironment.ResourceManagerUrl),
                 TestEnvironment.Credential,
                 options);
         }
 
+        private Uri GetUri(string endpoint)
+        {
+            return !string.IsNullOrEmpty(endpoint) ? new Uri(endpoint) : null;
+        }
+
         [SetUp]
         protected void CreateCleanupClient()
         {
@@ -89,7 +100,7 @@ protected void CleanupResourceGroups()
         {
             if (Mode != RecordedTestMode.Playback)
             {
-                Parallel.ForEach(CleanupPolicy.ResourceGroupsCreated, resourceGroup =>
+                Parallel.ForEach(ResourceGroupCleanupPolicy.ResourceGroupsCreated, resourceGroup =>
                 {
                     try
                     {
@@ -98,7 +109,19 @@ protected void CleanupResourceGroups()
                     }
                     catch (RequestFailedException e) when (e.Status == 404)
                     {
-                        //we assume the test case cleaned up it up if it no longer exists.
+                        //we assume the test case cleaned it up if it no longer exists.
+                    }
+                });
+
+                Parallel.ForEach(ManagementGroupCleanupPolicy.ManagementGroupsCreated, mgmtGroupId =>
+                {
+                    try
+                    {
+                        _cleanupClient.GetManagementGroupOperations(mgmtGroupId).StartDelete();
+                    }
+                    catch (RequestFailedException e) when (e.Status == 404 || e.Status == 403)
+                    {
+                        //we assume the test case cleaned it up if it no longer exists.
                     }
                 });
             }
@@ -138,10 +161,12 @@ public void OneTimeSetUp()
             StartSessionRecording();
 
             var options = InstrumentClientOptions(new ArmClientOptions(), SessionRecording);
-            options.AddPolicy(OneTimeCleanupPolicy, HttpPipelinePosition.PerCall);
+            options.AddPolicy(OneTimeResourceGroupCleanupPolicy, HttpPipelinePosition.PerCall);
+            options.AddPolicy(OneTimeManagementGroupCleanupPolicy, HttpPipelinePosition.PerCall);
 
             GlobalClient = CreateClient<ArmClient>(
                 SessionEnvironment.SubscriptionId,
+                GetUri(SessionEnvironment.ResourceManagerUrl),
                 SessionEnvironment.Credential,
                 options);
         }
@@ -174,11 +199,15 @@ public void OneTimeCleanupResourceGroups()
         {
             if (Mode != RecordedTestMode.Playback)
             {
-                Parallel.ForEach(OneTimeCleanupPolicy.ResourceGroupsCreated, resourceGroup =>
+                Parallel.ForEach(OneTimeResourceGroupCleanupPolicy.ResourceGroupsCreated, resourceGroup =>
                 {
                     var sub = _cleanupClient.GetSubscriptions().TryGet(SessionEnvironment.SubscriptionId);
                     sub?.GetResourceGroups().Get(resourceGroup).Value.StartDelete();
                 });
+                Parallel.ForEach(OneTimeManagementGroupCleanupPolicy.ManagementGroupsCreated, mgmtGroupId =>
+                {
+                    _cleanupClient.GetManagementGroupOperations(mgmtGroupId).StartDelete();
+                });
             }
 
             if (!(GlobalClient is null))

common/ManagementTestShared/Redesign/MockTestBase.cs

@@ -0,0 +1,53 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using Azure.Core.TestFramework;
+using Azure.ResourceManager.Resources;
+using System;
+using System.Net.Sockets;
+using System.Threading.Tasks;
+
+namespace Azure.ResourceManager.TestFramework
+{
+    public abstract class MockTestBase : ManagementRecordedTestBase<MockTestEnvironment>
+    {
+        public MockTestBase(bool isAsync) : base(isAsync)
+        {
+            EnsureMockServerRunning();
+        }
+
+        public MockTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode)
+        {
+            EnsureMockServerRunning();
+        }
+
+        protected async Task<ResourceGroupContainer> GetResourceGroupContainer(ArmClientOptions clientOptions = default)
+        {
+            var client = GetArmClient(clientOptions);
+            var sub = await client.GetSubscriptions().GetAsync(TestEnvironment.SubscriptionId);
+            return sub.Value.GetResourceGroups();
+        }
+
+        private void EnsureMockServerRunning()
+        {
+            if (Mode == RecordedTestMode.Record)
+                TestMockServerRunning();
+        }
+
+        private void TestMockServerRunning()
+        {
+            using (var tcpClient = new TcpClient())
+            {
+                try
+                {
+                    var uri = new Uri(TestEnvironment.MockEndPoint);
+                    tcpClient.Connect(uri.Host, uri.Port);
+                }
+                catch (SocketException)
+                {
+                    throw new InvalidOperationException("The mock server is not running, please start the mock server following this guide `https://devdiv.visualstudio.com/DevDiv/_git/avs?path=%2FREADME.md` in order to record the test");
+                }
+            }
+        }
+    }
+}

common/ManagementTestShared/Redesign/MockTestEnvironment.cs

@@ -0,0 +1,24 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using Azure.Core;
+using Azure.Core.TestFramework;
+using System;
+
+namespace Azure.ResourceManager.TestFramework
+{
+    public class MockTestEnvironment : TestEnvironment
+    {
+        public MockTestEnvironment() : base()
+        {
+            Environment.SetEnvironmentVariable("SUBSCRIPTION_ID", "00000000-0000-0000-0000-000000000000");
+            Environment.SetEnvironmentVariable("RESOURCE_MANAGER_URL", MockEndPoint);
+        }
+
+        public virtual string MockEndPoint => $"https://localhost:8441";
+
+        private TokenCredential _mockCredential;
+
+        public override TokenCredential Credential => _mockCredential ??= new MockCredential();
+    }
+}

common/Perf/Azure.Test.Perf/Azure.Test.Perf.csproj

@@ -10,6 +10,7 @@
     <PackageReference Include="System.Reflection.Emit" />
     <PackageReference Include="System.Text.Json" />
     <PackageReference Include="System.Threading.Channels" />
+    <PackageReference Include="BenchmarkDotNet" />
     <Reference Include="System.Net.Http" Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'" />
   </ItemGroup>