Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp PR for pipeline diagnosis #23022

Closed
wants to merge 9 commits into from
Closed

Temp PR for pipeline diagnosis #23022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6c2d566
Workaround fix for nigthly test failure in VSCC
schaabs Jul 29, 2021
4c14e09
Enable VSCC test logging to diagnose pipeline
schaabs Jul 30, 2021
5fb4254
wip
schaabs Jul 30, 2021
06d5c9b
logging to console
schaabs Jul 30, 2021
ddd7592
adding temp fix for log collection
schaabs Jul 31, 2021
72dbfd2
back to TestContext
schaabs Jul 31, 2021
f01d0c0
try scope used by UPC tests
schaabs Aug 2, 2021
00fce05
modifying live test pipeline to only run VSCC tests
schaabs Aug 9, 2021
c03125d
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-net int…
schaabs Aug 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/pipelines/templates/jobs/live.tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ jobs:
- pwsh: >
dotnet test eng/service.proj
--framework $(TestTargetFramework)
--filter "TestCategory!=Manually"
--filter "(TestCategory!=Manually)&(FullyQualifiedName~Azure.Identity.Tests.VisualStudioCodeCredentialLiveTests)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is adding this to the shared test template the only way to exclude this? Why can't we just disable the test in source?

--logger "trx"
--logger:"console;verbosity=normal"
/p:SDKType=${{ parameters.SDKType }}
Expand Down
2 changes: 1 addition & 1 deletion sdk/identity/Azure.Identity/tests/CredentialTestHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ public static async Task<string> GetRefreshTokenAsync(IdentityTestEnvironment te
.Build();

var retriever = new RefreshTokenRetriever(client.UserTokenCache);
await client.AcquireTokenByUsernamePassword(new[] { ".default" }, username, password.ToSecureString()).ExecuteAsync();
await client.AcquireTokenByUsernamePassword(new[] { "https://vault.azure.net/.default" }, username, password.ToSecureString()).ExecuteAsync();

StaticCachesUtilities.ClearStaticMetadataProviderCache();
StaticCachesUtilities.ClearAuthorityEndpointResolutionManagerCache();
Expand Down
16 changes: 16 additions & 0 deletions sdk/identity/Azure.Identity/tests/VisualStudioCodeCredentialLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,39 @@
// Licensed under the MIT License.

using System;
using System.Diagnostics.Tracing;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
using Azure.Core;
using Azure.Core.Diagnostics;
using Azure.Core.TestFramework;
using NUnit.Framework;

namespace Azure.Identity.Tests
{
[NonParallelizable]
public class VisualStudioCodeCredentialLiveTests : IdentityRecordedTestBase
{
private const string ExpectedServiceName = "VS Code Azure";
private AzureEventSourceListener _logListener;

public VisualStudioCodeCredentialLiveTests(bool isAsync) : base(isAsync)
{
}

[SetUp]
public void EnableLogging()
{
_logListener = new AzureEventSourceListener((_, message) => TestContext.WriteLine(message), EventLevel.Verbose);
}

[TearDown]
public void DisableLogging()
{
_logListener.Dispose();
}

[Test]
[RunOnlyOnPlatforms(Windows = true, OSX = true, ContainerNames = new[] { "ubuntu_netcore_keyring" })]
public async Task AuthenticateWithVscCredential()
Expand Down