Do not print red success message #23210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heaths
requested review from
chidozieononiwu,
danieljurek and
weshaggard
as code owners
heaths
commented
Aug 9, 2021
| Console.ForegroundColor = ConsoleColor.Red; | ||
|
|
||
| Console.Error.WriteLine(e.ToString()); | ||
| WriteError(e.ToString()); |
There was a problem hiding this comment.
I realize this prints to stdout instead of stderr, but the error in the changes above also print to stdout. I don't see a clear reason why we should use stderr for a fatal error anyway. Not everyone knows how to redirect both stdout and stderr.
|
I think the code is being moved to https://github.com/Azure/azure-sdk-tools/tree/main/tools/snippet-generator |
|
Thank you for this, @heaths! |
|
Talked to @chidozieononiwu and it is being ported, but not in use yet. We could take this one, and I can port it to the new location so it's ready once he gets Azure/azure-sdk-tools deploying. |
|
/azp run net - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/check-enforcer evaluate |
pakrym
approved these changes
Aug 30, 2021
chidozieononiwu
approved these changes
Aug 30, 2021
heaths
added a commit
to heaths/azure-sdk-tools
that referenced
this pull request
Aug 30, 2021
Resolves Azure/azure-sdk-for-net#22347 and is a port of Azure/azure-sdk-for-net#23210
weshaggard
pushed a commit
to Azure/azure-sdk-tools
that referenced
this pull request
Aug 31, 2021
Resolves Azure/azure-sdk-for-net#22347 and is a port of Azure/azure-sdk-for-net#23210
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22347