Update Roslyn Analyzers #23793
Merged
Update Roslyn Analyzers #23793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heaths
requested review from
chidozieononiwu,
danieljurek,
schaabs and
weshaggard
as code owners
ghost
added
the
weshaggard
approved these changes
Sep 3, 2021
pakrym
approved these changes
Sep 3, 2021
|
Oops, I forgot to create this branch from my |
heaths
force-pushed
the
azure-sdk-issue1961
branch
from
9660304 to
2054711
Compare
Update Azure.ClientSdk.Analyzers and suppress newly-added AZC0016. Relates to Azure/azure-sdk-tools#1961
heaths
force-pushed
the
azure-sdk-issue1961
branch
from
2054711 to
bbbbcec
Compare
|
@pakrym @ShivangiReja @AlexanderSher turns out the generator generates lowercase "-preview" suffixes. I can't really add exceptions, either. I would have to define hand-written models, but presumably none of these versions have shipped yet because they are all under "Generated". So should we just "break" them instead? Presumably, few if any people will be broken because for all but a couple of these it's the only version. Or in cases like this for generated code, should we use project-global suppressions? |
heaths
requested review from
aim-for-better,
AlexGhiondea,
annelo-msft,
christothes,
idear1203,
JialinXin,
martinbarnas-ms,
Mohit-Chakraborty,
orenmichaely,
petrsvihlik,
tyclintw and
vicancy
as code owners
This was referenced Sep 21, 2021
heaths
commented
Sep 21, 2021
sdk/webpubsub/Azure.Messaging.WebPubSub/src/WebPubSubServiceClientOptions.ServiceVersion.cs
Show resolved
Hide resolved
Mohit-Chakraborty
approved these changes
Sep 21, 2021
danielortega-msft
added a commit
to danielortega-msft/azure-sdk-for-net
that referenced
this pull request
Dec 30, 2021
Manually declaring this class and supressing codegen ensures that: 1. ServiceVersion members are not overwritten, preserving compatibility 2. ServiceVersion members can now use PascalCase For more information on this issues, see: - Azure/autorest.csharp#1524 - Azure#24153 - Azure#23793 - Azure/autorest.csharp#1497
whisper6284
pushed a commit
that referenced
this pull request
Jan 18, 2022
…ew API version in the PhoneNumbers SDK (#26029) * Generate SDK for PhoneNumbers API version 2022-01-11-preview2 * Add session recordings for latest API version * Update recorded sessions for failing tests These recordings are the same as the previous ones, but with the new API version. This had to be done due to an issue with the sanitizer. * Suppress ServiceVersion member name checks * Add missing ServiceVersion member * Don't auto generate PhoneNumbersClientOptions Manually declaring this class and supressing codegen ensures that: 1. ServiceVersion members are not overwritten, preserving compatibility 2. ServiceVersion members can now use PascalCase For more information on this issues, see: - Azure/autorest.csharp#1524 - #24153 - #23793 - Azure/autorest.csharp#1497 * Update API version in client and test recordings TODO: Update autorest config file once the spec is merged * Use latest autorest spec * Add changelog entry for 1.1.0-beta.1 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Azure/azure-sdk-tools#1961