-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TA] Added SingleCategoryClassify functionality #24235
[TA] Added SingleCategoryClassify functionality #24235
Conversation
You can't modify the
If you want to "trick" the SDK so that it reflects what the current behavior of the service is, you could write a transform and add it to the When the service fixes the bug, you can undo the transform. |
I agree with what @maririos said. Fortunately, the swagger got updated today and this issue has been fixed so you just need to re-generate with the latest version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments so far from .NET implementation perspective. Didn't look at test or sample implementation.
@deyaaeldeen and @mssfang could you review from the design and terminology perspective?
sdk/textanalytics/Azure.AI.TextAnalytics/samples/Sample10_SingleCategoryClassify.md
Outdated
Show resolved
Hide resolved
sdk/textanalytics/Azure.AI.TextAnalytics/samples/Sample10_SingleCategoryClassify.md
Outdated
Show resolved
Hide resolved
sdk/textanalytics/Azure.AI.TextAnalytics/samples/Sample10_SingleCategoryClassify.md
Show resolved
Hide resolved
sdk/textanalytics/Azure.AI.TextAnalytics/samples/Sample10_SingleCategoryClassify.md
Outdated
Show resolved
Hide resolved
sdk/textanalytics/Azure.AI.TextAnalytics/src/Internal/CustomEntitiesTaskParameters.cs
Outdated
Show resolved
Hide resolved
sdk/textanalytics/Azure.AI.TextAnalytics/src/SingleCategoryClassifyActionResult.cs
Outdated
Show resolved
Hide resolved
sdk/textanalytics/Azure.AI.TextAnalytics/src/SingleCategoryClassifyActionResult.cs
Outdated
Show resolved
Hide resolved
sdk/textanalytics/Azure.AI.TextAnalytics/src/TextAnalyticsModelFactory.cs
Outdated
Show resolved
Hide resolved
...textanalytics/Azure.AI.TextAnalytics/tests/Infrastructure/TextAnalyticsClientLiveTestBase.cs
Outdated
Show resolved
Hide resolved
// View operation results. | ||
await foreach (AnalyzeActionsResult documentsInPage in operation.Value) | ||
{ | ||
IReadOnlyCollection<SingleCategoryClassifyActionResult> classificationResultsCollection = documentsInPage.SingleCategoryClassifyResults; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is singleClassificationActionResults? a better name? I thought classificationResultsCollection
is the document result collections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. So you think I should replace classificationResultsCollection
with singleClassificationActionResults
. Correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR LGTM :) Just need to re-record some failing tests and make sure CI passes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked offline where Ahmed reminded me that not all endpoints are deployed so test failing is expected
* [TextAnalytics] Generated client from 3.2-preview.2 swagger (#23536) * [TA] Added SingleCategoryClassify functionality (#24235) * [TA] Added MultiCategoryClassify Functionality (#24237) * [TA] Added RecognizeCustomEntities Functionality (#24245) * [TA] Expose ActionName and enable multiple actions from same type (#24619) * Rerecorded all tests excluding AAD ones (#24913) * re-record AAD tests (#24919) * [TA] Enable CI for live tests for custom features (#24916) * add comments Co-authored-by: Caio Saldanha <camaiaor@microsoft.com> Co-authored-by: Ahmed Leithy <v-aleithy@microsoft.com> Co-authored-by: Salah Mostafa <zulamostafa@gmail.com> Co-authored-by: Salah Mostafa <v-samostafa@microsoft.com>
This PR contains the implementation of the Single Category Classify API interface as explained in #24061. Renames post the meeting with the architecture board have been taken into consideration in this PR.
The two known issues are:
"projectName" and "deploymentName" are expected to be "project-name" and "deployment-name" by the PPE. This change can also be temporarily made in CustomSingleClassificationTaskParameters.Serialization.cs
the PPE does not currently support old actions, and thus session records for them cannot yet be rerecorded.
No long-term solution can currently be done about the previous two issues, but they can be solved in another PR.