-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QualityForRecognition to Face Detection #25236
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the optional attribute QualityForRecognition to Face Detection API. Also includes some document discrepancy bugfixes.
This reverts commit 56fca85.
lulululululu
approved these changes
Nov 22, 2021
dipidoo
reviewed
Nov 22, 2021
dipidoo
reviewed
Nov 22, 2021
sdk/cognitiveservices/Vision.Face/src/Generated/Models/LargePersonGroup.cs
Outdated
Show resolved
Hide resolved
dipidoo
reviewed
Nov 22, 2021
sdk/cognitiveservices/Vision.Face/src/Generated/Models/LargeFaceList.cs
Outdated
Show resolved
Hide resolved
dipidoo
previously requested changes
Nov 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some reordered parameters of same type (string) that may be confusing for people who upgrades
11 tasks
msyache
dismissed
dipidoo’s stale review
November 23, 2021 03:59
Comments addressed, but we can't find where to resolve the changes requested block
dipidoo
approved these changes
Nov 23, 2021
jsquire
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the optional attribute QualityForRecognition to Face Detection API.
Also includes some document discrepancy bugfixes.
Related swagger change PR:
Azure/azure-rest-api-specs#14556
Azure/azure-rest-api-specs#15187
Azure/azure-rest-api-specs#16449
Azure/azure-rest-api-specs#16846
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new service
label and/or contact assigned reviewer.If the check fails at the
Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1
. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1
to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.