Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute API Version 2021 08 01 #25436

Merged
merged 13 commits into from
Jan 4, 2022
Merged

Compute API Version 2021 08 01 #25436

merged 13 commits into from
Jan 4, 2022

Conversation

haagha
Copy link
Member

@haagha haagha commented Nov 19, 2021

Swagger PR:
Azure/azure-rest-api-specs#16945

Swagger PR flags breaking change, but the breaking change was approved in previous PR Azure/azure-rest-api-specs#16099 on 2021-07-01 api version.

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
    

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@ghost ghost added the Compute label Nov 19, 2021
haagha and others added 5 commits November 19, 2021 17:33
* Adding tests for TVM/CVM for api-version 2021-08-01

* adding test for DES CRUD of CVM type
* added test for DiskRestorePoint and AcceleratedNetwork

* added recorded tests

Co-authored-by: REDMOND\rytruong <rytruong@microsoft.com>
@Yao725
Copy link
Member

Yao725 commented Dec 15, 2021

LGTM, let's merge this one after the swagger is merged.

@haagha
Copy link
Member Author

haagha commented Jan 3, 2022

@Yao725 can we please merge this PR now that Swagger is merged.

@Yao725
Copy link
Member

Yao725 commented Jan 4, 2022

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Yao725
Copy link
Member

Yao725 commented Jan 4, 2022

/azp run net - compute - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Yao725 Yao725 merged commit 1d27afd into main Jan 4, 2022
@Yao725 Yao725 deleted the feature/cplat-2021-08-01 branch January 4, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants