[CLU] renaming confidenceScore to confidence and making targetKind public #25551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmedLeithy
requested review from
heaths,
KrzysztofCwalina and
tg-msft
as code owners
|
API changes have been detected in |
heaths
approved these changes
Nov 29, 2021
sdk/cognitivelanguage/Azure.AI.Language.Conversations/src/Models/TargetIntentResult.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the following PR for renaming the confidenceScore property to
confidencefor all classes has been merged, I have regenerated the client with the new names. I have also added custom models for the renaming the Question Answering related models (AnswerSpanandKnowledgeBaseAnswer), since there was the swagger reference did not get changed.Additionally, while using the conversations SDK in a different project, I ran into an issue where the
targetKindproperty in theTargetIntentResultclass is internal. I have made this property public to so that the kind of target project for orchestration responses is exposed to the user. (LUIS vs QA vs Conversations).