-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQL] Generate SDK for Endpoint Certificates API #27910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
swagger PR merged Azure/azure-rest-api-specs#18502
Hi @m-nash, can you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few breaking changes are found. It seems that some of them do not have backward compatibility (like removal of property). Please bump the major version to 3.0.0.0
.
sdk/sqlmanagement/Microsoft.Azure.Management.Sql/src/Generated/IReplicationLinksOperations.cs
Outdated
Show resolved
Hide resolved
sdk/sqlmanagement/Microsoft.Azure.Management.Sql/src/Generated/IReplicationLinksOperations.cs
Outdated
Show resolved
Hide resolved
sdk/sqlmanagement/Microsoft.Azure.Management.Sql/src/Generated/IReplicationLinksOperations.cs
Outdated
Show resolved
Hide resolved
sdk/sqlmanagement/Microsoft.Azure.Management.Sql/src/Generated/Models/Database.cs
Show resolved
Hide resolved
sdk/sqlmanagement/Microsoft.Azure.Management.Sql/src/Generated/Models/DatabaseIdentity.cs
Show resolved
Hide resolved
sdk/sqlmanagement/Microsoft.Azure.Management.Sql/src/Generated/Models/DatabaseUpdate.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the removal of delegatedResources
and primaryDelegatedIdentityClientId
in Database*
files, this change has been applied to the API version that's currently in use - which means this change was already implicitly propagated to SDK and downstream clients.
For that reason, I am not sure if this SDK update itself is a breaking one (whether it requires a major version bump) Also, I couldn't find any references to these classes/props in PowerShell code.
For the reference, this is the PR that changed the current API version Azure/azure-rest-api-specs#18209
cc: @viparek
sdk/sqlmanagement/Microsoft.Azure.Management.Sql/src/Generated/Models/IPv6FirewallRuleList.cs
Show resolved
Hide resolved
We've reverted some breaking changes (from swagger). The one that's left ( |
Thanks @ostojicb Can you bump |
* initial generate * Add tests * run generate.ps1 script * Bump versions * revert collateral damage * run generate.ps1, take 2 * revive replication links * run generate.ps1 * bump to 3.0.0 * Bump AssemblyVersion
* initial generate * Add tests * run generate.ps1 script * Bump versions * revert collateral damage * run generate.ps1, take 2 * revive replication links * run generate.ps1 * bump to 3.0.0 * Bump AssemblyVersion
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:[SQL] Add EndpointCertificates API to V5 SDK tag azure-rest-api-specs#18502
General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new service
label and/or contact assigned reviewer.If the check fails at the
Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1
. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1
to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.