Fix SDK automation script #28186
Merged
Fix SDK automation script #28186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShivangiReja
requested review from
chidozieononiwu,
weshaggard and
benbp
as code owners
christothes
reviewed
Apr 13, 2022
christothes
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR - Azure/azure-rest-api-specs#18628
Issue - https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1493678&view=logs&j=03afb3bb-7296-55ad-aa07-ceee610c73b2&t=0f320c29-1c90-5304-d2d3-c58a6bb76437&l=128
Currently SDK automation script updates sha in autorest.md for only the changed files in the PR.
We found an issue in ConfidentialLedger, It has three input files in autorest.md and this PR updates only one input file. So current script replaces the sha only for the changed input file, and it has a common.json reference but other input files also have a common.json reference, so we load 2 different common.json because of there is 2 different hash to the input files, therefore the generation fails with duplicate schema names error.
Fix: If there is any match found in autorest.md for the changed input files, update sha for all the input files.