add eula/privacy statement to gallery SDK release #28238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangsun-ctrl
requested review from
m-nash,
fengzhou-msft,
archerzz,
ArcturusZhang,
Yao725 and
ArthurMa1978
as code owners
ghost
added
the
Sandido
requested changes
Apr 18, 2022
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/Gallery.cs
Show resolved
Hide resolved
Yao725
approved these changes
Apr 19, 2022
Sandido
approved these changes
Apr 21, 2022
Sandido
requested changes
Apr 21, 2022
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/CommunityGalleryImage.cs
Show resolved
Hide resolved
Sandido
requested changes
Apr 25, 2022
| @@ -105,6 +105,8 @@ private void ValidateCommunityGalleryImage(CommunityGalleryImage communityGaller | |||
| { | |||
| string expectedId = "/CommunityGalleries/" + PublicGalleryName + "/Images/" + GalleryImageName; | |||
| Assert.Equal(expectedId, communityGalleryImage.UniqueId); | |||
| Assert.NotNull(communityGalleryImage.Eula); | |||
There was a problem hiding this comment.
Can you check for the exact expected value?
There was a problem hiding this comment.
Just in case something unexpectedly changes the value in an incorrect or breaking way.
There was a problem hiding this comment.
the exact value is a random string i put. It does not add much value here to check exact value because it might gets updated by mistake and this test will fail. But the only thing we want here is the string flow-through and NotNull assert do can 100% of that job right.
This was referenced May 5, 2022
Closed
ArthurMa1978
pushed a commit
that referenced
this pull request
Jun 10, 2022
* set up feature branch * set up feature branch * new recordings * Gallery 01 03 SDK (#27466) * save * save * update * update * save * save * sanitization * add eula/privacy statement to gallery SDK release (#28238) * save * update * update * update test * SDK changes for new properties "settings" and "advancedSettings" to gallery application version (#28250) * Generated SDK using 0c46c6ca375c5b61de701f790db5673d76ceb8b6 * Updated test and recording * removed SAS tokens from recorded test * generated SDK with updated comments from API PR * removed "sig=" tokens from recorded test * added customization and sanitized keys in recorded tests * Restored older customization * fixed customization * Made enableHealthCheck optional parameter because it appears after settings and advancedSettings, as the WIKI states. * Update AssemblyInfo.cs .Net version update * Update Microsoft.Azure.Management.Compute.csproj * save (#29131) test rerecord that was needed * Update compute_resource-manager.txt * Update AzSdk.RP.props Co-authored-by: Adam Sandor <adsandor@microsoft.com> Co-authored-by: kangsun-ctrl <69279251+kangsun-ctrl@users.noreply.github.com> Co-authored-by: Bhaskar Brahma <bhbrahma@microsoft.com>
sarkar-rajarshi
pushed a commit
to sarkar-rajarshi/azure-sdk-for-net
that referenced
this pull request
Jun 10, 2022
* set up feature branch * set up feature branch * new recordings * Gallery 01 03 SDK (Azure#27466) * save * save * update * update * save * save * sanitization * add eula/privacy statement to gallery SDK release (Azure#28238) * save * update * update * update test * SDK changes for new properties "settings" and "advancedSettings" to gallery application version (Azure#28250) * Generated SDK using 0c46c6ca375c5b61de701f790db5673d76ceb8b6 * Updated test and recording * removed SAS tokens from recorded test * generated SDK with updated comments from API PR * removed "sig=" tokens from recorded test * added customization and sanitized keys in recorded tests * Restored older customization * fixed customization * Made enableHealthCheck optional parameter because it appears after settings and advancedSettings, as the WIKI states. * Update AssemblyInfo.cs .Net version update * Update Microsoft.Azure.Management.Compute.csproj * save (Azure#29131) test rerecord that was needed * Update compute_resource-manager.txt * Update AzSdk.RP.props Co-authored-by: Adam Sandor <adsandor@microsoft.com> Co-authored-by: kangsun-ctrl <69279251+kangsun-ctrl@users.noreply.github.com> Co-authored-by: Bhaskar Brahma <bhbrahma@microsoft.com>
archerzz
pushed a commit
that referenced
this pull request
Jun 16, 2022
* set up feature branch * generated with new changes * set up feature branch * new recordings * Gallery 01 03 SDK (#27466) * save * save * update * update * save * save * sanitization * add eula/privacy statement to gallery SDK release (#28238) * save * update * update * update test * generated with new changes * SDK generation * Updated SDK * SDK changes for new properties "settings" and "advancedSettings" to gallery application version (#28250) * Generated SDK using 0c46c6ca375c5b61de701f790db5673d76ceb8b6 * Updated test and recording * removed SAS tokens from recorded test * generated SDK with updated comments from API PR * removed "sig=" tokens from recorded test * added customization and sanitized keys in recorded tests * Restored older customization * fixed customization * Made enableHealthCheck optional parameter because it appears after settings and advancedSettings, as the WIKI states. * federatedclientid change * adding tests for restore point with securityprofile (#28949) * Update AssemblyInfo.cs .Net version update * Update Microsoft.Azure.Management.Compute.csproj * save (#29131) test rerecord that was needed * Test recordings * Adding Customizations * adding test recordings * update azsdk.rp.props and compute_resource-manager.txt * credscan Co-authored-by: Theodore Chang <thchan@microsoft.com> Co-authored-by: Adam Sandor <adsandor@microsoft.com> Co-authored-by: kangsun-ctrl <69279251+kangsun-ctrl@users.noreply.github.com> Co-authored-by: Bhaskar Brahma <bhbrahma@microsoft.com> Co-authored-by: anshulsolanki21 <73930854+anshulsolanki21@users.noreply.github.com>
zhihaoxue
pushed a commit
to zhihaoxue/azure-sdk-for-net
that referenced
this pull request
Jul 27, 2022
* set up feature branch * set up feature branch * new recordings * Gallery 01 03 SDK (Azure#27466) * save * save * update * update * save * save * sanitization * add eula/privacy statement to gallery SDK release (Azure#28238) * save * update * update * update test * SDK changes for new properties "settings" and "advancedSettings" to gallery application version (Azure#28250) * Generated SDK using 0c46c6ca375c5b61de701f790db5673d76ceb8b6 * Updated test and recording * removed SAS tokens from recorded test * generated SDK with updated comments from API PR * removed "sig=" tokens from recorded test * added customization and sanitized keys in recorded tests * Restored older customization * fixed customization * Made enableHealthCheck optional parameter because it appears after settings and advancedSettings, as the WIKI states. * Update AssemblyInfo.cs .Net version update * Update Microsoft.Azure.Management.Compute.csproj * save (Azure#29131) test rerecord that was needed * Update compute_resource-manager.txt * Update AzSdk.RP.props Co-authored-by: Adam Sandor <adsandor@microsoft.com> Co-authored-by: kangsun-ctrl <69279251+kangsun-ctrl@users.noreply.github.com> Co-authored-by: Bhaskar Brahma <bhbrahma@microsoft.com>
zhihaoxue
pushed a commit
to zhihaoxue/azure-sdk-for-net
that referenced
this pull request
Jul 27, 2022
* set up feature branch * generated with new changes * set up feature branch * new recordings * Gallery 01 03 SDK (Azure#27466) * save * save * update * update * save * save * sanitization * add eula/privacy statement to gallery SDK release (Azure#28238) * save * update * update * update test * generated with new changes * SDK generation * Updated SDK * SDK changes for new properties "settings" and "advancedSettings" to gallery application version (Azure#28250) * Generated SDK using 0c46c6ca375c5b61de701f790db5673d76ceb8b6 * Updated test and recording * removed SAS tokens from recorded test * generated SDK with updated comments from API PR * removed "sig=" tokens from recorded test * added customization and sanitized keys in recorded tests * Restored older customization * fixed customization * Made enableHealthCheck optional parameter because it appears after settings and advancedSettings, as the WIKI states. * federatedclientid change * adding tests for restore point with securityprofile (Azure#28949) * Update AssemblyInfo.cs .Net version update * Update Microsoft.Azure.Management.Compute.csproj * save (Azure#29131) test rerecord that was needed * Test recordings * Adding Customizations * adding test recordings * update azsdk.rp.props and compute_resource-manager.txt * credscan Co-authored-by: Theodore Chang <thchan@microsoft.com> Co-authored-by: Adam Sandor <adsandor@microsoft.com> Co-authored-by: kangsun-ctrl <69279251+kangsun-ctrl@users.noreply.github.com> Co-authored-by: Bhaskar Brahma <bhbrahma@microsoft.com> Co-authored-by: anshulsolanki21 <73930854+anshulsolanki21@users.noreply.github.com>
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-net
that referenced
this pull request
Dec 7, 2022
* set up feature branch * generated with new changes * set up feature branch * new recordings * Gallery 01 03 SDK (Azure#27466) * save * save * update * update * save * save * sanitization * add eula/privacy statement to gallery SDK release (Azure#28238) * save * update * update * update test * generated with new changes * SDK generation * Updated SDK * SDK changes for new properties "settings" and "advancedSettings" to gallery application version (Azure#28250) * Generated SDK using 0c46c6ca375c5b61de701f790db5673d76ceb8b6 * Updated test and recording * removed SAS tokens from recorded test * generated SDK with updated comments from API PR * removed "sig=" tokens from recorded test * added customization and sanitized keys in recorded tests * Restored older customization * fixed customization * Made enableHealthCheck optional parameter because it appears after settings and advancedSettings, as the WIKI states. * federatedclientid change * adding tests for restore point with securityprofile (Azure#28949) * Update AssemblyInfo.cs .Net version update * Update Microsoft.Azure.Management.Compute.csproj * save (Azure#29131) test rerecord that was needed * Test recordings * Adding Customizations * adding test recordings * update azsdk.rp.props and compute_resource-manager.txt * credscan Co-authored-by: Theodore Chang <thchan@microsoft.com> Co-authored-by: Adam Sandor <adsandor@microsoft.com> Co-authored-by: kangsun-ctrl <69279251+kangsun-ctrl@users.noreply.github.com> Co-authored-by: Bhaskar Brahma <bhbrahma@microsoft.com> Co-authored-by: anshulsolanki21 <73930854+anshulsolanki21@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.