Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Grid: Add missing pagination support to listing nested event subscriptions #28709

Merged
merged 3 commits into from
May 18, 2022

Conversation

Brandon411
Copy link
Contributor

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@ghost ghost added the Event Grid label May 12, 2022
@Brandon411 Brandon411 changed the title Evebt Grid: Add missing pagination support to listing nested event subscriptions Event Grid: Add missing pagination support to listing nested event subscriptions May 12, 2022
@fengzhou-msft
Copy link
Member

fengzhou-msft commented May 13, 2022

What is the release plan? I do not see a version update in csproj file and AssemblyInfo.cs in this PR. Considering this is a breaking change, we need to bump the major version.

@Brandon411
Copy link
Contributor Author

What is the release plan? I do not see a version update in csproj file and AssemblyInfo.cs in this PR. Considering this is a breaking change, we need to bump the major version.

We got approval from ARM to update the swagger with the missing pagination as a breaking change without bumping the version number. Azure/azure-rest-api-specs#18895

@Brandon411
Copy link
Contributor Author

I have updated the version from 7.1.0 to 7.1.1.

@Brandon411
Copy link
Contributor Author

Updated the major version because of the breaking change

@fengzhou-msft fengzhou-msft merged commit 9faa2ef into Azure:main May 18, 2022
sarkar-rajarshi pushed a commit to sarkar-rajarshi/azure-sdk-for-net that referenced this pull request Jun 10, 2022
zhihaoxue pushed a commit to zhihaoxue/azure-sdk-for-net that referenced this pull request Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants