-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Face Public Preview to 2.8.0-preview.3 #32573
Merged
msyache
merged 7 commits into
Azure:feature/face-public-preview
from
msyache:yache/face-280p2
Dec 14, 2022
Merged
Update Face Public Preview to 2.8.0-preview.3 #32573
msyache
merged 7 commits into
Azure:feature/face-public-preview
from
msyache:yache/face-280p2
Dec 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msyache
force-pushed
the
yache/face-280p2
branch
from
November 23, 2022 01:28
53fdef2
to
d93c572
Compare
dipidoo
reviewed
Dec 6, 2022
sdk/cognitiveservices/Vision.Face/src/Generated/FaceOperations.cs
Outdated
Show resolved
Hide resolved
dipidoo
reviewed
Dec 6, 2022
sdk/cognitiveservices/Vision.Face/src/Generated/FaceOperations.cs
Outdated
Show resolved
Hide resolved
msyache
force-pushed
the
yache/face-280p2
branch
from
December 6, 2022 22:54
5ee5ad1
to
20a8b35
Compare
dipidoo
reviewed
Dec 6, 2022
sdk/cognitiveservices/Vision.Face/src/Generated/PersonDirectoryExtensions.cs
Show resolved
Hide resolved
dipidoo
reviewed
Dec 6, 2022
sdk/cognitiveservices/Vision.Face/src/Generated/PersonDirectoryExtensions.cs
Outdated
Show resolved
Hide resolved
dipidoo
reviewed
Dec 6, 2022
dipidoo
reviewed
Dec 8, 2022
sdk/cognitiveservices/Vision.Face/src/Generated/PersonDirectoryExtensions.cs
Show resolved
Hide resolved
dipidoo
reviewed
Dec 8, 2022
sdk/cognitiveservices/Vision.Face/src/Generated/PersonDirectoryExtensions.cs
Show resolved
Hide resolved
dipidoo
reviewed
Dec 12, 2022
sdk/cognitiveservices/Vision.Face/src/Generated/IPersonDirectory.cs
Outdated
Show resolved
Hide resolved
dipidoo
reviewed
Dec 12, 2022
...ionRecords/FacePersonDirectoryTests/FacePersonDirectoryCreateDynamicPersonGroupPositive.json
Outdated
Show resolved
Hide resolved
dipidoo
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. a leftover xmldoc comment might benefit from removal before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated changes from
Azure/azure-rest-api-specs@049415c
Azure/azure-rest-api-specs@66dc2c9
Azure/azure-rest-api-specs#21831