Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build snippets during Analyze job by default #33878

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Build snippets during Analyze job by default #33878

merged 3 commits into from
Feb 6, 2023

Conversation

heaths
Copy link
Member

@heaths heaths commented Feb 3, 2023

Resolves #33877

@heaths heaths requested a review from JoshLove-msft February 3, 2023 00:25
jsquire
jsquire approved these changes Feb 3, 2023
View reviewed changes
sdk/iot/ci.yml Outdated Show resolved Hide resolved
sdk/dns/ci.mgmt.yml Outdated Show resolved Hide resolved
annelo-msft
annelo-msft approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@annelo-msft annelo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACR LGTM, Thanks @heaths!

weshaggard
weshaggard approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks reasonable to me.

heaths added 2 commits February 3, 2023 16:58
@heaths
Resolve PR feedback
d799b9e
@heaths
Don't build snippets for Core
442f1b7 
Core has a few issues actually compiling with SNIPPET symbol because it
tries to elide some code for brevity. Fixing that changes the extracted
snippets and may make the samples more confusing so leaving as-is.
@pallavit
Copy link
Contributor

pallavit commented Feb 6, 2023

Do we want to create follow-up issues for the SDKs where we had to manually set this to false? This looks great, thank you for doing it.

@heaths
Copy link
Member Author

heaths commented Feb 6, 2023

Do we want to create follow-up issues for the SDKs where we had to manually set this to false? This looks great, thank you for doing it.

@pallavit already did. :) See #20431. I updated the OP with individual tracking issues as tasks.

@heaths heaths merged commit bf02a2a into Azure:main Feb 6, 2023
@heaths heaths deleted the issue33877 branch February 6, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshLove-msft JoshLove-msft JoshLove-msft approved these changes

@annelo-msft annelo-msft annelo-msft approved these changes

@pallavit pallavit pallavit approved these changes

@weshaggard weshaggard weshaggard approved these changes

@jsquire jsquire jsquire approved these changes

@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

@ShivangiReja ShivangiReja Awaiting requested review from ShivangiReja ShivangiReja is a code owner

@kinelski kinelski Awaiting requested review from kinelski kinelski is a code owner

@tg-msft tg-msft Awaiting requested review from tg-msft tg-msft is a code owner

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner

@drwill-ms drwill-ms Awaiting requested review from drwill-ms

@timtay-microsoft timtay-microsoft Awaiting requested review from timtay-microsoft

@abhipsaMisra abhipsaMisra Awaiting requested review from abhipsaMisra

@andyk-ms andyk-ms Awaiting requested review from andyk-ms

@brycewang-microsoft brycewang-microsoft Awaiting requested review from brycewang-microsoft

@serkantkaraca serkantkaraca Awaiting requested review from serkantkaraca

@m-redding m-redding Awaiting requested review from m-redding m-redding is a code owner

@joseharriaga joseharriaga Awaiting requested review from joseharriaga joseharriaga is a code owner

@christothes christothes Awaiting requested review from christothes christothes is a code owner

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina

Assignees
No one assigned
Labels
Cognitive - Metrics Advisor Cognitive - Text Analytics Communication Event Hubs IoT KeyVault Search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change default BuildSnippets to check all snippets are used
6 participants
@heaths @pallavit @jsquire @weshaggard @annelo-msft @JoshLove-msft