Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt fix GetMetrics_ReturnsExpectedResult failing in live tests #34356

Merged
merged 7 commits into from
Feb 21, 2023
Merged

Attempt fix GetMetrics_ReturnsExpectedResult failing in live tests #34356

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
32aef89
Attempt to fix live tests for GetMetrics tests from Target Based Scal…
amnguye Feb 17, 2023
546190f
Remove unncessary packages
amnguye Feb 17, 2023
f3b2e6f
Change test queue from mock queue to fixture queue
amnguye Feb 19, 2023
13cd3aa
Change metric provider constructor to only change for the success met…
amnguye Feb 19, 2023
d2740c6
Correcting test to use fixture queue
amnguye Feb 19, 2023
b624962
Removing duplicate queues for same tests
amnguye Feb 20, 2023
81eb707
shorter queue name
amnguye Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ...rage/Microsoft.Azure.WebJobs.Extensions.Storage.Queues/tests/QueueMetricsProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ public void SetUp()
_loggerProvider = new TestLoggerProvider();
_loggerFactory.AddProvider(_loggerProvider);
_mockQueue = new Mock<QueueClient>(new Uri("https://test.queue.core.windows.net/testqueue"), new QueueClientOptions());
_mockQueue.Setup(x => x.Name).Returns("testqueue");
_metricsProvider = new QueueMetricsProvider(_mockQueue.Object, _loggerFactory);
}

Expand All @@ -53,7 +54,8 @@ public void OneTimeTearDown()
[Test]
public async Task GetMetrics_ReturnsExpectedResult()
{
var metrics = await _metricsProvider.GetMetricsAsync();
QueueMetricsProvider _provider = new QueueMetricsProvider(Fixture.Queue, _loggerFactory);
var metrics = await _provider.GetMetricsAsync();

Assert.AreEqual(0, metrics.QueueLength);
Assert.AreEqual(TimeSpan.Zero, metrics.QueueTime);
Expand All @@ -67,14 +69,14 @@ public async Task GetMetrics_ReturnsExpectedResult()

await Task.Delay(TimeSpan.FromSeconds(5));

metrics = await _metricsProvider.GetMetricsAsync();
metrics = await _provider.GetMetricsAsync();

Assert.AreEqual(5, metrics.QueueLength);
Assert.True(metrics.QueueTime.Ticks > 0);
Assert.AreNotEqual(default(DateTime), metrics.Timestamp);

// verify non-generic interface works as expected
metrics = (QueueTriggerMetrics)(await _metricsProvider.GetMetricsAsync());
metrics = (QueueTriggerMetrics)(await _provider.GetMetricsAsync());
Assert.AreEqual(5, metrics.QueueLength);
}

Expand All @@ -101,7 +103,7 @@ public async Task GetMetrics_HandlesStorageExceptions()

public class TestFixture : IDisposable
{
private const string TestQueuePrefix = "queuelistenertests";
private const string TestQueuePrefix = "metrictests";

public TestFixture()
{
Expand Down