Autorest Regen Preview to 3.0.0-alpha.20230712.2 by Dapeng Zhang from refs/pull/3373/merge #37553
Conversation
github-actions
bot
added
Cognitive - Form Recognizer
Mixed Reality
Open AI
Search
Synapse
labels
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
ArcturusZhang
force-pushed
the
auto-update-autorest-3.0.0-alpha.20230712.2
branch
from
a754e3b to
dcc80f2
Compare
| @@ -41,6 +41,6 @@ internal ChatChoice(ChatMessage message, int index, CompletionsFinishReason fini | |||
| /// <summary> The ordered index associated with this chat completions choice. </summary> | |||
| public int Index { get; } | |||
| /// <summary> The reason that this chat completions choice completed its generated. </summary> | |||
| public CompletionsFinishReason FinishReason { get; } | |||
| public CompletionsFinishReason? FinishReason { get; } | |||
There was a problem hiding this comment.
Here is the corresponding typespec definition: https://github.com/Azure/azure-rest-api-specs/blob/982929d15d73166dbb9378e15c88b6e2ae5c4b80/specification/cognitiveservices/OpenAI.Inference/models/chat.completions.tsp#L196
This property is required and nullable, therefore this code change is expected.
There was a problem hiding this comment.
@joseharriaga does this mean Azure/autorest.csharp#3600 is fixed?
There was a problem hiding this comment.
or @ArcturusZhang is this part of the change in 3373?
There was a problem hiding this comment.
Looks like 3373 is fixing it, can we add fixes 3600 to the description on that PR
|
Close in favor of #37768 |
Triggered from Azure/autorest.csharp#3373