Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS JobRouter] Missing usage of Azure.Etag in RouterQueueItem #37573

Merged
merged 3 commits into from
Jul 13, 2023
Merged

[ACS JobRouter] Missing usage of Azure.Etag in RouterQueueItem #37573

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4eb3310
missing usage of Azure.Etag in RouterQueueItem
sarkar-rajarshi Jul 12, 2023
363aee1
remove empty classes
sarkar-rajarshi Jul 12, 2023
c4ef39c
remove setter of ScheduleAndSuspendMode from JobMatchingMode
sarkar-rajarshi Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...ication/Azure.Communication.JobRouter/api/Azure.Communication.JobRouter.netstandard2.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,7 +768,6 @@ public static partial class CommunicationJobRouterModelFactory
public static Azure.Communication.JobRouter.Models.AcceptJobOfferResult AcceptJobOfferResult(string assignmentId = null, string jobId = null, string workerId = null) { throw null; }
public static Azure.Communication.JobRouter.Models.RouterJobAssignment RouterJobAssignment(string assignmentId = null, string workerId = null, System.DateTimeOffset assignedAt = default(System.DateTimeOffset), System.DateTimeOffset? completedAt = default(System.DateTimeOffset?), System.DateTimeOffset? closedAt = default(System.DateTimeOffset?)) { throw null; }
public static Azure.Communication.JobRouter.Models.RouterJobOffer RouterJobOffer(string offerId = null, string jobId = null, int capacityCost = 0, System.DateTimeOffset? offeredAt = default(System.DateTimeOffset?), System.DateTimeOffset? expiresAt = default(System.DateTimeOffset?)) { throw null; }
public static Azure.Communication.JobRouter.Models.RouterQueueItem RouterQueueItem(Azure.Communication.JobRouter.Models.RouterQueue queue = null, string etag = null) { throw null; }
public static Azure.Communication.JobRouter.Models.RouterQueueStatistics RouterQueueStatistics(string queueId = null, int length = 0, System.Collections.Generic.IReadOnlyDictionary<string, double> estimatedWaitTimeMinutes = null, double? longestJobWaitTimeMinutes = default(double?)) { throw null; }
public static Azure.Communication.JobRouter.Models.RouterWorkerAssignment RouterWorkerAssignment(string assignmentId = null, string jobId = null, int capacityCost = 0, System.DateTimeOffset assignedAt = default(System.DateTimeOffset)) { throw null; }
public static Azure.Communication.JobRouter.Models.UnassignJobResult UnassignJobResult(string jobId = null, int unassignmentCount = 0) { throw null; }
Expand Down Expand Up @@ -912,7 +911,7 @@ internal RouterQueue() { }
public partial class RouterQueueItem
{
internal RouterQueueItem() { }
public string Etag { get { throw null; } }
public Azure.ETag ETag { get { throw null; } }
public Azure.Communication.JobRouter.Models.RouterQueue Queue { get { throw null; } }
}
public partial class RouterQueueStatistics
Expand Down
9 changes: 0 additions & 9 deletions ...ication/Azure.Communication.JobRouter/src/Generated/CommunicationJobRouterModelFactory.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions sdk/communication/Azure.Communication.JobRouter/src/Generated/Models/RouterQueueItem.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions sdk/communication/Azure.Communication.JobRouter/src/Models/RouterQueueItem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,20 @@ namespace Azure.Communication.JobRouter.Models
[CodeGenModel("RouterQueueItem")]
public partial class RouterQueueItem
{
[CodeGenMember("Etag")]
internal string _etag
{
get
{
return ETag.ToString();
}
set
{
ETag = new ETag(value);
}
}

/// <summary> (Optional) The Concurrency Token. </summary>
public ETag ETag { get; internal set; }
}
}