Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for common-types #37875

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Remove workaround for common-types #37875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions sdk/networkcloud/Azure.ResourceManager.NetworkCloud/src/autorest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,6 @@ rename-rules:
Etag: ETag|etag

directive:
# The core library Azure.ResourceManager has been generated when the subscriptionId was not marked as an uuid.
# v5 of common-types defines `subscriptionId` as `guid` format and needs to be removed in order to generate valid code.
- from: types.json
where: $.parameters.SubscriptionIdParameter
transform: >
delete $['format'];
- from: networkcloud.json
where: $.definitions
transform:
Expand All @@ -72,11 +66,6 @@ directive:
'principalId',
'applicationId'
];
# CodeGen don't support some definitions in v4 & v5 common types, here is an issue https://github.com/Azure/autorest.csharp/issues/3537 opened to fix this problem
- from: v5/types.json
where: $.definitions
transform: >
delete $.Resource.properties.id.format;
# `delete` transformations are to remove APIs/methods that result in Access Denied for end users.
- remove-operation: BareMetalMachines_CreateOrUpdate
- remove-operation: BareMetalMachines_Delete
Expand Down