Draft of adding an AOT compatibility CI Pipeline #38634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heaths
reviewed
Sep 28, 2023
|
|
||
| <ItemGroup> | ||
| <!-- Update this dependency to its latest, which has all the annotations --> | ||
| <PackageReference Include="Microsoft.Extensions.Logging.Configuration" Version="8.0.0-preview.7.23375.6" /> |
There was a problem hiding this comment.
If I check in #38500 you should remove the Version attribute.
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\..\sdk\$ServiceDirectory\$PackageName\src\$PackageName.csproj" /> | ||
| <TrimmerRootAssembly Include="$PackageName" /> |
| } | ||
| } | ||
|
|
||
| Write-Host "Checking against expected number of warnings" |
There was a problem hiding this comment.
This seems very fragile. Can we instead check against an array of patterns e.g.,
$patterns = @(
'IL2026.*Azure.Core.RequestContentHelper.FromEnumerable\(IEnumerable`1<BinaryData>\)'
'IL3050.*Azure.Core.RequestContentHelper.FromEnumerable\(IEnumerable`1<BinaryData>\)'
# ...
)
$output = `dotnet publish` # and any other args
$warnings = $output -split "`n" | select-string -pattern 'IL\d+' | select-string -pattern $patterns -notmatch
if ($warnings.Count -gt 0) {
Write-Host "Found additional warnings:`n$warnings"
exit $warnings.Count
}
m-redding
changed the title
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>net7.0</TargetFramework> |
There was a problem hiding this comment.
Per Vitek, this should target net8.0 #39428 (comment)
Suggested change
| <TargetFramework>net7.0</TargetFramework> | |
| <TargetFramework>net8.0</TargetFramework> |
There was a problem hiding this comment.
I'm working on this in a separate branch because I ended up needing to change the approach a bit, but we can't target net 8 in the CI yet :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.