Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min tls version to 1.2 for digital twins live test event hub #39405

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Bump min tls version to 1.2 for digital twins live test event hub #39405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0741370
Bump min tls version to 1.2 for digital twins live test storage account
benbp Oct 19, 2023
ab14325
Bump min tls version to 1.2 for digital twins live test event hub
benbp Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions sdk/digitaltwins/test-resources.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ resource digitaltwinRoleAssignment 'Microsoft.Authorization/roleAssignments@2020
scope: digitaltwin
}

resource eventHubNamespace 'Microsoft.EventHub/namespaces@2018-01-01-preview' = {
resource eventHubNamespace 'Microsoft.EventHub/namespaces@2022-01-01-preview' = {
name: baseName
location: location
sku: {
Expand All @@ -47,6 +47,7 @@ resource eventHubNamespace 'Microsoft.EventHub/namespaces@2018-01-01-preview' =
isAutoInflateEnabled: false
maximumThroughputUnits: 0
kafkaEnabled: false
minimumTlsVersion: 'TLS1_2'
}
}

Expand All @@ -69,7 +70,7 @@ resource eventHubNamespaceAuthRules 'Microsoft.EventHub/namespaces/Authorization
]
}
}

resource eventHubNamespaceEventHubAuthRules 'Microsoft.EventHub/namespaces/eventhubs/authorizationRules@2017-04-01' = {
name: '${eventHubNamespaceEventHub.name}/owner'
properties: {
Expand Down Expand Up @@ -103,6 +104,9 @@ resource storageAccount 'Microsoft.Storage/storageAccounts@2022-05-01' = {
name: 'Standard_LRS'
}
kind: 'StorageV2'
properties: {
minimumTlsVersion: 'TLS1_2'
}

resource blobService 'blobServices' = {
name: 'default'
Expand Down Expand Up @@ -164,4 +168,4 @@ resource deploymentScript 'Microsoft.Resources/deploymentScripts@2020-10-01' = {
}
}

output INPUT_BLOB_URI string = 'https://${storageAccount.name}.blob.${environment().suffixes.storage}/${containerName}/${blobName}'
output INPUT_BLOB_URI string = 'https://${storageAccount.name}.blob.${environment().suffixes.storage}/${containerName}/${blobName}'
7 changes: 1 addition & 6 deletions sdk/digitaltwins/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,8 @@ extends:
template: ../../eng/pipelines/templates/stages/archetype-sdk-tests.yml
parameters:
ServiceDirectory: digitaltwins
# Enable canary and public cloud testing in separate subscriptions, so that the tests-weekly builds
# don't exceed the 10 azure digital twin instance hard limit
CloudConfig:
Public:
SubscriptionConfiguration: $(sub-config-azure-cloud-test-resources)
Location: westcentralus
Canary:
SubscriptionConfiguration: $(sub-config-azure-cloud-test-resources-preview)
Location: eastus2euap
Clouds: Public,Canary
Clouds: Public