ClientModel: Reshuffle some whitespace and files for consistency across ClientModel #41425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annelo-msft
commented
Jan 19, 2024
annelo-msft
commented
Jan 19, 2024
sdk/core/System.ClientModel/tests/client/ClientShared/ModelReaderWriterExtensions.cs
Show resolved
Hide resolved
annelo-msft
commented
Jan 19, 2024
sdk/core/System.ClientModel/tests/client/ModelReaderWriter/Models/DiscriminatorSet/BaseModel.cs
Show resolved
Hide resolved
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
annelo-msft
requested review from
JoshLove-msft,
christothes and
KrzysztofCwalina
as code owners
annelo-msft
requested review from
m-nash,
jsquire,
AlexanderSher and
pallavit
|
Fixes #40758 |
JoshLove-msft
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR#6 to get all of the changes in the Azure.Core 2.0 feature branch directly related to ClientModel code merged into main.
It adds a few tests for
BinaryContentthat had previously only lived in the feature branch, but mostly just shuffles files around and makes whitespace updates for consistency with other ClientModel conventions. Specific categories of changes are flagged in PR comments.