[Search] Add support for sbyte and int16 types to FieldBuilder
#42378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 4, 2024 12:55
|
API change check API changes are not detected in this pull request. |
alzimmermsft
reviewed
Mar 4, 2024
Comment on lines
+30
to
+31
| [typeof(sbyte)] = SearchFieldDataType.SByte, | ||
| [typeof(short)] = SearchFieldDataType.Int16, |
There was a problem hiding this comment.
@jairmyree FYI, we should do the same thing in Java for Int16, will need to look into if SByte can be supported
There was a problem hiding this comment.
Java has a concept of byte which is equivalent to SByte
alzimmermsft
approved these changes
Mar 4, 2024
angiurgiu
pushed a commit
that referenced
this pull request
Mar 20, 2024
…42378) * [Search] Add support for `sbyte` and `int16` types to FieldBuilder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following:
sbyteandint16types toFieldBuilder.