Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding WebPubSubService provisioning #43027

Merged
merged 6 commits into from
May 11, 2024
Merged

Adding WebPubSubService provisioning #43027

merged 6 commits into from
May 11, 2024

Conversation

vicancy
Copy link
Member

@vicancy vicancy commented Mar 27, 2024

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

Adding WebPubSubService provisioning for dotnet/aspire#2495

@vicancy vicancy changed the title Adding WebPubSubService Adding WebPubSubService provisioning Mar 27, 2024
@jsquire jsquire requested review from JoshLove-msft and m-nash March 27, 2024 14:21
@jsquire jsquire requested a review from tg-msft March 27, 2024 14:21
@pallavit
Copy link
Contributor

@jsquire do we want to add this to the codeowners list too? I think it would be valuable but I usually see you gatekeep so wanted to check with you.

@jsquire
Copy link
Member

jsquire commented Mar 27, 2024

@jsquire do we want to add this to the codeowners list too? I think it would be valuable but I usually see you gatekeep so wanted to check with you.

Yeah, it's past time that @JoshLove-msft and @tg-msft were added as owners for provisioning. I'll put out a PR for this tomorrow if Josh doesn't beat me to it.

@vicancy
Copy link
Member Author

vicancy commented Apr 1, 2024

Hi @JoshLove-msft, could you provide guidance on running and testing the test? The CI throws with System.InvalidOperationException : WebPubSubData does not implement IPersistableModel however WebPubSubData does implement IPersistableModel, do you have any hints how to fix the test? Do I need to prepare something for the test?

https://github.com/Azure/azure-sdk-for-net/blob/47a7099bd35293a864a6bdcc6b7640bbad3fdbda/sdk/webpubsub/Azure.ResourceManager.WebPubSub/api/Azure.ResourceManager.WebPubSub.netstandard2.0.cs#L20C211-L20C228

@JoshLove-msft
Copy link
Member

Hi @JoshLove-msft, could you provide guidance on running and testing the test? The CI throws with System.InvalidOperationException : WebPubSubData does not implement IPersistableModel however WebPubSubData does implement IPersistableModel, do you have any hints how to fix the test? Do I need to prepare something for the test?

https://github.com/Azure/azure-sdk-for-net/blob/47a7099bd35293a864a6bdcc6b7640bbad3fdbda/sdk/webpubsub/Azure.ResourceManager.WebPubSub/api/Azure.ResourceManager.WebPubSub.netstandard2.0.cs#L20C211-L20C228

Yes, we would need to generate the bicep serialization in the Azure.ResourceManager.WebPubSub library. Here is an example https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/servicebus/Azure.ResourceManager.ServiceBus/src/autorest.md showing the property that needs to be set:

enable-bicep-serialization: true

Once this property is set, you would need to regenerate that library, and then we would need to ship a new GA version with the bicep serialization.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Provisioning

@vicancy
Copy link
Member Author

vicancy commented Apr 28, 2024

Looks like CI fails on unrelated tests
image
Hi @JoshLove-msft could you help review the PR?

@JoshLove-msft JoshLove-msft merged commit 14f1ccd into main May 11, 2024
49 checks passed
@JoshLove-msft JoshLove-msft deleted the lianwei/wps branch May 11, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants