Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STG 93 API View Comments #43999

Merged
merged 2 commits into from
May 13, 2024

Conversation

seanmcc-msft
Copy link
Member

@seanmcc-msft seanmcc-msft commented May 12, 2024

Applied the comments from these API views:

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label May 12, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented May 12, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Storage.Blobs
Azure.Storage.Common

Copy link
Member

@jaschrep-msft jaschrep-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there was a bit too broad of a scope for renames in comments. Some share file properties were hit. Revert before merging. Looks good otherwise.

@seanmcc-msft seanmcc-msft merged commit b716566 into Azure:main May 13, 2024
17 checks passed
@seanmcc-msft seanmcc-msft deleted the feature/storage/stg93gaApiView branch May 13, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants