Simplifying and unifying every Base class constructors to go via comm… #4529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
shahabhijeet
commented
Jul 6, 2018
shahabhijeet
commented
- Simplifying and unifying every Base class constructors to go via common code path.
- Simplifying logic to avoid adding duplicate userAgent strings.
- Making sure we use ConfigureAwait(false) where it was missing.
- Adding tests
…on code path. Simplifying logic to avoid adding duplicate userAgent strings. Making sure we use ConfigureAwait(false) where it was missing. Adding tests.
9 tasks
EricDahlvang
suggested changes
Jul 6, 2018
| foreach(ProductInfoHeaderValue piHv in defaultUserAgentInfoList) | ||
| { | ||
| if(!HttpClient.DefaultRequestHeaders.UserAgent.Any<ProductInfoHeaderValue>((hv) => hv.Product.Name.Equals(piHv.Product.Name, StringComparison.OrdinalIgnoreCase))); | ||
| if(!HttpClient.DefaultRequestHeaders.UserAgent.Any<ProductInfoHeaderValue>((hv) => hv.Product.Name.Equals(piHv.Product.Name, StringComparison.OrdinalIgnoreCase))) |
There was a problem hiding this comment.
This does not account for UserAgent strings that are comments only. They will NOT have a .Product property... this will throw a null reference exception. If this constructor is used https://technet.microsoft.com/en-us/library/hh138008(v=vs.110) then ProductInfoHeaderValue will have only a comment.
| private void AddUserAgentEntry(ProductInfoHeaderValue pInfoHeaderValue) | ||
| { | ||
| if (!HttpClient.DefaultRequestHeaders.UserAgent.Contains<ProductInfoHeaderValue>(pInfoHeaderValue, | ||
| new ObjectComparer<ProductInfoHeaderValue>((left, right) => left.Product.Name.Equals(right.Product.Name, StringComparison.OrdinalIgnoreCase)))) |
There was a problem hiding this comment.
This does not account for UserAgent strings that are comments only. They will NOT have a .Product property... this will throw a null reference exception.
| { | ||
| } | ||
|
|
||
| : this(serviceHttpClient: null, rootHandler: CreateRootHandler(), disposeHttpClient: true, delHandlers: null) { } |
There was a problem hiding this comment.
CreateRootHandler is called by this constructor. This code creates a HttpClientHandler or WebRequestHandler that is then never disposed. Please see #3712
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.