Add abstract UpdateStatus methods to OperationResult #45475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
annelo-msft
commented
Aug 13, 2024
sdk/core/System.ClientModel/tests/Convenience/PageCollectionScenarioTests.cs
Show resolved
Hide resolved
annelo-msft
commented
Aug 13, 2024
annelo-msft
requested review from
jsquire,
tg-msft,
christothes,
KrzysztofCwalina,
trrwilson,
ShivangiReja,
joseharriaga,
JoshLove-msft and
m-nash
KrzysztofCwalina
approved these changes
Aug 13, 2024
sdk/core/System.ClientModel/src/Internal/CancellationTokenExtensions.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per feedback from @stephentoub, having an
IsCompletedproperty on the SCM LRO abstraction withoutUpdateStatusleaves the abstraction incomplete, since no valid use case exists for theIsCompletedproperty by itself. This PR adds an abstractUpdateStatusmethod, similar to the API in the Azure.CoreOperationtype, and reimplementsWaitForCompletionas a virtual method over derived types' implementations ofUpdateStatus. As such, it pulls in several internal files that had originally been intended to be emitted by the generator for use by generated client subtypes, and adds tests for implemented methods.