Structured message cherrypick stg96 #45496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial implementation and basic test * seek/write tests * fix test param * fix exceptions
* enum rename and footer read/write methods * align encode/decode tests | update encoding stream * decode stream footer * rename
* decode tests & bugfixes * roundtrip tests * more tests * better errors | remove duplicate test
* validate stream length * tests
* regenerate and stage block uses structured message * page and append * testproxy * cleanup * fix datalake/share tests * testproxy * testproxy * re-add null-safe access
* download range structured message * testproxy * throw when service fails to give back structured message * test * testproxy
* putblob structured message * testproxy * fixes
* datalake append * null fix * fixes
* retriable decode * rewind mock test * bugfix * bugfix * tests
* blobs retriable structured message download * test proxy * testproxy * remove commented code
* blockblob working * revert testing change * page/append * datalake file * testfix * bug fixes | test fixes * disable new API for presenting CRC from structured message * fix nunit * whitespace * fix/test-proxy * csproj * more csproj removeals This is building fine locally idk what's up * Trigger Fresh Build * fileshare testproxy * fix mock * Update macos image from 11 to latest (Azure#44607) * Update macos image from 11 to latest * Update eng/pipelines/templates/jobs/ci.mgmt.yml Co-authored-by: Ben Broderick Phillips <ben@benbp.net> --------- Co-authored-by: Ben Broderick Phillips <ben@benbp.net> * Revert "Update macos image from 11 to latest (Azure#44607)" this is causing too many problems. skipping macos tests for now. They'll run when this feature branch merges into main. This reverts commit 29e87b4. --------- Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
* impl * testproxy * shares fix * testproxy
* block blob fix * testproxy
* rename and validation * fix
* expose crc from structured message * testproxy * undo typo * exportapi
jaschrep-msft
requested review from
seanmcc-msft,
amnguye,
schaabs,
tg-msft and
nickliu-msft
as code owners
|
API change check API changes are not detected in this pull request. |
|
There's some TODOs that got lost in the workflow earlier. Will handle those here. |
jalauzon-msft
approved these changes
Aug 20, 2024
jaschrep-msft
merged commit 8e97158
into
Azure:feature/storage/stg96base2
27 of 30 checks passed
seanmcc-msft
added a commit
that referenced
this pull request
Aug 21, 2024
This reverts commit 8e97158.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of content validation work over to stg96.
This review is mainly for cherry-pick correctness.