-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ComputerVision C# SDK auto-generated code. #4579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any version change. I also see breaking change.
Please update version, release notes.
Hi @shahabhijeet, I've bumped the versions... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the branch and address the comments
@@ -7,8 +7,8 @@ | |||
[assembly: AssemblyTitle("Microsoft Cognitive Services ComputerVision SDK")] | |||
[assembly: AssemblyDescription("Provides access to the Microsoft Cognitive Services ComputerVision APIs.")] | |||
|
|||
[assembly: AssemblyVersion("3.0.0.0")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AssemblyVersion remains the same but AssemblyFileVersion must be bumped
Hi @dsajanice, I fixed the issue, thanks. |
@yangyuan Please pull from upstream psSdkJson6 and update this PR |
Hi @dsgouda, I did pull it from psSdkJson6, but anyway I have debased the branch to newest psSdkJson6. |
@shahabhijeet please approve |
ping @shahabhijeet :) |
REST spec PR Azure/azure-rest-api-specs#3440
Please hold for @cthrash's review.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK.