Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ComputerVision C# SDK auto-generated code. #4579

Merged
merged 3 commits into from Jul 30, 2018
Merged

Update ComputerVision C# SDK auto-generated code. #4579

merged 3 commits into from Jul 30, 2018

Conversation

yangyuan
Copy link
Member

@yangyuan yangyuan commented Jul 23, 2018

REST spec PR Azure/azure-rest-api-specs#3440

Please hold for @cthrash's review.

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Member

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any version change. I also see breaking change.
Please update version, release notes.

@yangyuan
Copy link
Member Author

Hi @shahabhijeet, I've bumped the versions...
Please noticed that 3.0.0 are unlisted, so the release notes contains the changes from 2.0.0.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the branch and address the comments

@@ -7,8 +7,8 @@
[assembly: AssemblyTitle("Microsoft Cognitive Services ComputerVision SDK")]
[assembly: AssemblyDescription("Provides access to the Microsoft Cognitive Services ComputerVision APIs.")]

[assembly: AssemblyVersion("3.0.0.0")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AssemblyVersion remains the same but AssemblyFileVersion must be bumped

@yangyuan
Copy link
Member Author

Hi @dsajanice, I fixed the issue, thanks.

@dsgouda
Copy link
Contributor

dsgouda commented Jul 26, 2018

@yangyuan Please pull from upstream psSdkJson6 and update this PR

@yangyuan
Copy link
Member Author

Hi @dsgouda, I did pull it from psSdkJson6, but anyway I have debased the branch to newest psSdkJson6.

@dsgouda
Copy link
Contributor

dsgouda commented Jul 26, 2018

@shahabhijeet please approve

@yangyuan
Copy link
Member Author

ping @shahabhijeet :)

@dsgouda dsgouda merged commit ba02f20 into Azure:psSdkJson6 Jul 30, 2018
@yangyuan yangyuan deleted the yuanyang/endpoint_computer_vision branch February 25, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants