Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cogs Face] Update Face SDK‘s auto-generated code to 3.0.0-preview with latest swagger. #4618

Merged
merged 2 commits into from
Aug 3, 2018
Merged

[Cogs Face] Update Face SDK‘s auto-generated code to 3.0.0-preview with latest swagger. #4618

merged 2 commits into from
Aug 3, 2018

Conversation

lebronJ
Copy link
Contributor

@lebronJ lebronJ commented Aug 2, 2018

Regenerate Face SDK with latest spec Azure/azure-rest-api-specs#3552

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@lebronJ lebronJ changed the title [Cogs Face] Update Face SDK‘s auto-generated code with latest swagger. [Cogs Face] Update Face SDK‘s auto-generated code to 3.0.0-preview with latest swagger. Aug 2, 2018
@huxuan
Copy link

huxuan commented Aug 2, 2018

LGTM.

yangyuan
yangyuan approved these changes Aug 2, 2018
View reviewed changes
Copy link
Member

@yangyuan yangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dsgouda
dsgouda suggested changes Aug 2, 2018
View reviewed changes
...tiveServices/dataPlane/Vision/Face/Face/Microsoft.Azure.CognitiveServices.Vision.Face.csproj Outdated
@@ -6,14 +6,15 @@
<PropertyGroup>
<PackageId>Microsoft.Azure.CognitiveServices.Vision.Face</PackageId>
<Description>This client library provides access to the Microsoft Cognitive Services Face APIs.</Description>
<Version>2.1.0-preview</Version>
<Version>3.0.0-preview</Version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this is a major version bump?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a properties.cs similar to this and assign the appropriate version numbers

Copy link

@huxuan huxuan Aug 2, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By adding support of LargeFaceList and LargePersonGroup, there are some breaking changes in those operations like FindSimilar, Identify and Verify. So we propose a major version upgrade. Please let me know if you have any further concern.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When in preview, you can release a breaking change with a minor version bump, i.e., 2.2.0-preview

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, we will follow that rule. Thanks for the information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved by adding properties.cs and change version to 2.2.0-preview. Regenerate SDK by master swagger and regenerate test records. Thanks.

@dsgouda
Copy link
Contributor

dsgouda commented Aug 3, 2018

LGTM

@dsgouda dsgouda merged commit b3dafdb into Azure:psSdkJson6 Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huxuan huxuan huxuan left review comments

@dsgouda dsgouda dsgouda approved these changes

@yangyuan yangyuan yangyuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lebronJ @huxuan @dsgouda @yangyuan