Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark AzureAuthorityHosts.AzureGermany as Obsolete. #46371

Merged
merged 7 commits into from
Oct 16, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Eagle3386 authored Sep 30, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 5515c3409c53baac5459bdf0493880e82ea26403
1 change: 1 addition & 0 deletions sdk/identity/Azure.Identity/src/AzureAuthorityHosts.cs
Original file line number Diff line number Diff line change
@@ -27,6 +27,7 @@ public static class AzureAuthorityHosts
/// <summary>
/// The host of the Microsoft Entra authority for tenants in the Azure German Cloud.
/// </summary>
[Obsolete("Microsoft Cloud Germany was closed on October 29th, 2021.")]
Eagle3386 marked this conversation as resolved.
Show resolved Hide resolved
christothes marked this conversation as resolved.
Show resolved Hide resolved
public static Uri AzureGermany { get; } = new Uri(AzureGermanyHostUrl);

/// <summary>

Unchanged files with check annotations Beta

[Test]
public void CustomAuthorityHost()
{
string envHostValue = AzureAuthorityHosts.AzureGermany.ToString();

Check failure on line 60 in sdk/identity/Azure.Identity/tests/TokenCredentialOptionsTests.cs

Azure Pipelines / net - identity - ci (Build Test Ubuntu2004_NET60_PackageRef_Debug)

sdk/identity/Azure.Identity/tests/TokenCredentialOptionsTests.cs#L60

sdk/identity/Azure.Identity/tests/TokenCredentialOptionsTests.cs(60,35): Error CS0618: 'AzureAuthorityHosts.AzureGermany' is obsolete: 'Microsoft Cloud Germany was closed on October 29th, 2021.'

Check failure on line 60 in sdk/identity/Azure.Identity/tests/TokenCredentialOptionsTests.cs

Azure Pipelines / net - identity - ci (Build Test MacOS_NET60_PackageRef_Debug)

sdk/identity/Azure.Identity/tests/TokenCredentialOptionsTests.cs#L60

sdk/identity/Azure.Identity/tests/TokenCredentialOptionsTests.cs(60,35): Error CS0618: 'AzureAuthorityHosts.AzureGermany' is obsolete: 'Microsoft Cloud Germany was closed on October 29th, 2021.'

Check failure on line 60 in sdk/identity/Azure.Identity/tests/TokenCredentialOptionsTests.cs

Azure Pipelines / net - identity - ci (Build Test Ubuntu2004_NET80_ProjectRef_Release)

sdk/identity/Azure.Identity/tests/TokenCredentialOptionsTests.cs#L60

sdk/identity/Azure.Identity/tests/TokenCredentialOptionsTests.cs(60,35): Error CS0618: 'AzureAuthorityHosts.AzureGermany' is obsolete: 'Microsoft Cloud Germany was closed on October 29th, 2021.'

Check failure on line 60 in sdk/identity/Azure.Identity/tests/TokenCredentialOptionsTests.cs

Azure Pipelines / net - identity - ci

sdk/identity/Azure.Identity/tests/TokenCredentialOptionsTests.cs#L60

sdk/identity/Azure.Identity/tests/TokenCredentialOptionsTests.cs(60,35): Error CS0618: 'AzureAuthorityHosts.AzureGermany' is obsolete: 'Microsoft Cloud Germany was closed on October 29th, 2021.'

Check failure on line 60 in sdk/identity/Azure.Identity/tests/TokenCredentialOptionsTests.cs

Azure Pipelines / net - identity - ci (Build Test MacOS_NET80_ProjectRef_Release)

sdk/identity/Azure.Identity/tests/TokenCredentialOptionsTests.cs#L60

sdk/identity/Azure.Identity/tests/TokenCredentialOptionsTests.cs(60,35): Error CS0618: 'AzureAuthorityHosts.AzureGermany' is obsolete: 'Microsoft Cloud Germany was closed on October 29th, 2021.'
using (new TestEnvVar("AZURE_AUTHORITY_HOST", envHostValue))
{
// params
// az thrown Exception message, expected message, expected exception
yield return new object[] { AzureAuthorityHosts.AzureChina };
yield return new object[] { AzureAuthorityHosts.AzureGermany };

Check failure on line 1116 in sdk/identity/Azure.Identity/tests/ManagedIdentityCredentialTests.cs

Azure Pipelines / net - identity - ci (Build Test Ubuntu2004_NET60_PackageRef_Debug)

sdk/identity/Azure.Identity/tests/ManagedIdentityCredentialTests.cs#L1116

sdk/identity/Azure.Identity/tests/ManagedIdentityCredentialTests.cs(1116,41): Error CS0618: 'AzureAuthorityHosts.AzureGermany' is obsolete: 'Microsoft Cloud Germany was closed on October 29th, 2021.'

Check failure on line 1116 in sdk/identity/Azure.Identity/tests/ManagedIdentityCredentialTests.cs

Azure Pipelines / net - identity - ci (Build Test MacOS_NET60_PackageRef_Debug)

sdk/identity/Azure.Identity/tests/ManagedIdentityCredentialTests.cs#L1116

sdk/identity/Azure.Identity/tests/ManagedIdentityCredentialTests.cs(1116,41): Error CS0618: 'AzureAuthorityHosts.AzureGermany' is obsolete: 'Microsoft Cloud Germany was closed on October 29th, 2021.'

Check failure on line 1116 in sdk/identity/Azure.Identity/tests/ManagedIdentityCredentialTests.cs

Azure Pipelines / net - identity - ci (Build Test Ubuntu2004_NET80_ProjectRef_Release)

sdk/identity/Azure.Identity/tests/ManagedIdentityCredentialTests.cs#L1116

sdk/identity/Azure.Identity/tests/ManagedIdentityCredentialTests.cs(1116,41): Error CS0618: 'AzureAuthorityHosts.AzureGermany' is obsolete: 'Microsoft Cloud Germany was closed on October 29th, 2021.'

Check failure on line 1116 in sdk/identity/Azure.Identity/tests/ManagedIdentityCredentialTests.cs

Azure Pipelines / net - identity - ci

sdk/identity/Azure.Identity/tests/ManagedIdentityCredentialTests.cs#L1116

sdk/identity/Azure.Identity/tests/ManagedIdentityCredentialTests.cs(1116,41): Error CS0618: 'AzureAuthorityHosts.AzureGermany' is obsolete: 'Microsoft Cloud Germany was closed on October 29th, 2021.'

Check failure on line 1116 in sdk/identity/Azure.Identity/tests/ManagedIdentityCredentialTests.cs

Azure Pipelines / net - identity - ci (Build Test MacOS_NET80_ProjectRef_Release)

sdk/identity/Azure.Identity/tests/ManagedIdentityCredentialTests.cs#L1116

sdk/identity/Azure.Identity/tests/ManagedIdentityCredentialTests.cs(1116,41): Error CS0618: 'AzureAuthorityHosts.AzureGermany' is obsolete: 'Microsoft Cloud Germany was closed on October 29th, 2021.'
yield return new object[] { AzureAuthorityHosts.AzureGovernment };
yield return new object[] { AzureAuthorityHosts.AzurePublicCloud };
}